#include "rfc1524.h"
#include "rfc2047.h"
#include "nntp.h"
+#include "sidebar.h"
+#include "buffy.h"
#include "mutt_crypt.h"
static unsigned int _checked = 0;
+void nntp_sync_sidebar (NNTP_DATA* data) {
+ int i = 0;
+ BUFFY* tmp = NULL;
+ char buf[STRING];
+
+ if (list_empty (Incoming))
+ return;
+
+ /* unfortunately, NNTP_DATA::group only is the plain
+ * group name, so for every single update, we need to
+ * compose the full string which must be defined via
+ * mailboxes command ;-((( FIXME
+ */
+ buf[0] = '\0';
+ snprintf (buf, sizeof (buf), "nntp%s://%s%s%s%s/%s",
+ (data->nserv->conn->account.flags & M_ACCT_SSL) ? "s" : "",
+ NONULL (data->nserv->conn->account.user),
+ *data->nserv->conn->account.pass ? ":" : "",
+ *data->nserv->conn->account.pass ? data->nserv->conn->account.pass : "",
+ data->nserv->conn->account.host,
+ data->group);
+ debug_print (4, ("group == '%s'\n", buf));
+
+ /* bail out if group not found via mailboxes */
+ if ((i = buffy_lookup (buf)) < 0)
+ return;
+
+ tmp = (BUFFY*) Incoming->data[i];
+ /* copied from browser.c */
+ if (option (OPTMARKOLD) &&
+ data->lastCached >= data->firstMessage &&
+ data->lastCached <= data->lastMessage)
+ tmp->msg_unread = data->lastMessage - data->lastCached;
+ else
+ tmp->msg_unread = data->unread;
+ tmp->new = data->unread > 0;
+ /* this is closest to a "total" count we can get */
+ tmp->msgcount = data->lastMessage - data->firstMessage;
+}
+
static void nntp_error (const char *where, const char *msg) {
debug_print (1, ("unexpected response in %s: %s\n", where, msg));
}
return -1;
}
- if (safe_strncmp ("281", buf, 3)) {
+ if (str_ncmp ("281", buf, 3)) {
conn->account.flags = flags;
mutt_error _("Login failed.");
if (mutt_socket_readln (buf, sizeof (buf), conn) < 0)
return nntp_connect_error (serv);
- if (!safe_strncmp ("200", buf, 3))
+ if (!str_ncmp ("200", buf, 3))
mutt_message (_("Connected to %s. Posting ok."), conn->account.host);
- else if (!safe_strncmp ("201", buf, 3))
+ else if (!str_ncmp ("201", buf, 3))
mutt_message (_("Connected to %s. Posting NOT ok."), conn->account.host);
else {
mutt_socket_close (conn);
if (mutt_socket_readln (buf, sizeof (buf), conn) < 0)
return nntp_connect_error (serv);
- if (!(conn->account.flags & M_ACCT_USER) && safe_strncmp ("480", buf, 3)) {
+ if (!(conn->account.flags & M_ACCT_USER) && str_ncmp ("480", buf, 3)) {
serv->status = NNTP_OK;
return 0;
}
char buf[LONG_STRING];
CONNECTION *conn = serv->conn;
- mutt_socket_write (conn, "LISTGROUP\r\n");
- if (mutt_socket_readln (buf, sizeof (buf), conn) < 0)
- return (nntp_connect_error (serv));
- if (safe_strncmp ("500", buf, 3))
- serv->hasLISTGROUP = 1;
-
mutt_socket_write (conn, "XOVER\r\n");
if (mutt_socket_readln (buf, sizeof (buf), conn) < 0)
return nntp_connect_error (serv);
- if (safe_strncmp ("500", buf, 3))
+ if (str_ncmp ("500", buf, 3))
serv->hasXOVER = 1;
mutt_socket_write (conn, "XPAT\r\n");
if (mutt_socket_readln (buf, sizeof (buf), conn) < 0)
return nntp_connect_error (serv);
- if (safe_strncmp ("500", buf, 3))
+ if (str_ncmp ("500", buf, 3))
serv->hasXPAT = 1;
+ mutt_socket_write (conn, "LISTGROUP\r\n");
+ if (mutt_socket_readln (buf, sizeof (buf), conn) < 0)
+ return (nntp_connect_error (serv));
+ if (str_ncmp ("500", buf, 3))
+ serv->hasLISTGROUP = 1;
+
mutt_socket_write (conn, "XGTITLE +\r\n");
if (mutt_socket_readln (buf, sizeof (buf), conn) < 0)
return nntp_connect_error (serv);
- if (safe_strncmp ("500", buf, 3))
+ if (str_ncmp ("500", buf, 3))
serv->hasXGTITLE = 1;
- if (!safe_strncmp ("282", buf, 3)) {
+ if (!str_ncmp ("282", buf, 3)) {
do {
if (mutt_socket_readln (buf, sizeof (buf), conn) < 0)
return nntp_connect_error (serv);
if (*line)
done = FALSE;
}
- else if ((!safe_strncmp ("480", buf, 3)) && nntp_auth (data->nserv) < 0)
+ else if ((!str_ncmp ("480", buf, 3)) && nntp_auth (data->nserv) < 0)
return -1;
} while (!done);
ret = 0;
line = 0;
- inbuf = safe_malloc (sizeof (buf));
+ inbuf = mem_malloc (sizeof (buf));
FOREVER {
chunk = mutt_socket_readln_d (buf, sizeof (buf), nntp_data->nserv->conn,
strfcpy (inbuf + lenbuf, p, sizeof (buf));
if (chunk >= sizeof (buf)) {
- lenbuf += safe_strlen (p);
+ lenbuf += str_len (p);
}
else {
line++;
lenbuf = 0;
}
- safe_realloc (&inbuf, lenbuf + sizeof (buf));
+ mem_realloc (&inbuf, lenbuf + sizeof (buf));
}
- FREE (&inbuf);
+ mem_free (&inbuf);
funct (NULL, data);
}
while (!done);
if (colon) {
*colon = '\0';
colon++;
- nntp_get_status (ctx, h, p, atoi (colon));
- if (h && h->article_num == 0 && safe_strcmp (group, b) == 0)
+ nntp_get_status (ctx, h, b, atoi (colon));
+ if (h && h->article_num == 0 && str_cmp (group, b) == 0)
h->article_num = atoi (colon);
}
}
d++;
debug_print (2, ("group: %s, desc: %s\n", line, d));
if ((data = (NNTP_DATA *) hash_find (news->newsgroups, line)) != NULL &&
- safe_strcmp (d, data->desc)) {
- FREE (&data->desc);
- data->desc = safe_strdup (d);
+ str_cmp (d, data->desc)) {
+ mem_free (&data->desc);
+ data->desc = str_dup (d);
}
return 0;
#undef news
int x, done = 0;
hdr->env = mutt_new_envelope ();
- hdr->env->newsgroups = safe_strdup (nntp_data->group);
+ hdr->env->newsgroups = str_dup (nntp_data->group);
hdr->content = mutt_new_body ();
hdr->content->type = TYPETEXT;
- hdr->content->subtype = safe_strdup ("plain");
+ hdr->content->subtype = str_dup ("plain");
hdr->content->encoding = ENC7BIT;
hdr->content->disposition = DISPINLINE;
hdr->content->length = -1;
nntp_get_status (ctx, hdr, NULL, hdr->article_num);
break;
case 1:
- hdr->env->subject = safe_strdup (b);
- /* Now we need to do the things which would normally be done in
- * mutt_read_rfc822_header() */
- if (hdr->env->subject) {
- regmatch_t pmatch[1];
-
- rfc2047_decode (&hdr->env->subject);
-
- if (regexec (ReplyRegexp.rx, hdr->env->subject, 1, pmatch, 0) == 0)
- hdr->env->real_subj = hdr->env->subject + pmatch[0].rm_eo;
- else
- hdr->env->real_subj = hdr->env->subject;
- }
+ hdr->env->subject = str_dup (b);
break;
case 2:
rfc822_free_address (&hdr->env->from);
hdr->env->from = rfc822_parse_adrlist (hdr->env->from, b);
- rfc2047_decode_adrlist (hdr->env->from);
+ /* same as for mutt_parse_rfc822_line():
+ * don't leave from info NULL if there's an invalid address (or
+ * whatever) in From: field; mutt would just display it as empty
+ * and mark mail/(esp.) news article as your own. aaargh! this
+ * bothered me for _years_ */
+ if (!hdr->env->from) {
+ hdr->env->from = rfc822_new_address ();
+ hdr->env->from->personal = str_dup (b);
+ }
break;
case 3:
hdr->date_sent = mutt_parse_date (b, hdr);
hdr->received = hdr->date_sent;
break;
case 4:
- FREE (&hdr->env->message_id);
- hdr->env->message_id = safe_strdup (b);
+ mem_free (&hdr->env->message_id);
+ hdr->env->message_id = str_dup (b);
break;
case 5:
mutt_free_list (&hdr->env->references);
break;
case 8:
if (!hdr->read)
- FREE (&hdr->env->xref);
+ mem_free (&hdr->env->xref);
b = b + 6; /* skips the "Xref: " */
- hdr->env->xref = safe_strdup (b);
+ hdr->env->xref = str_dup (b);
nntp_parse_xref (ctx, nntp_data->group, b, hdr);
}
+ rfc2047_decode_envelope (hdr->env);
if (!*p)
return -1;
b = p;
{
char buf[HUGE_STRING];
char *msg = _("Fetching message headers...");
+ char *msg2 = _("Fetching headers from cache...");
NNTP_DATA *nntp_data = ((NNTP_DATA *) ctx->data);
int ret;
int num;
fc.ctx = ctx;
fc.base = first;
fc.last = last;
- fc.messages = safe_calloc (last - first + 1, sizeof (unsigned short));
+ fc.messages = mem_calloc (last - first + 1, sizeof (unsigned short));
if (nntp_data->nserv->hasLISTGROUP) {
snprintf (buf, sizeof (buf), "LISTGROUP %s\r\n", nntp_data->group);
if (mutt_nntp_fetch (nntp_data, buf, NULL, nntp_fetch_numbers, &fc, 0) !=
#ifdef DEBUG
nntp_error ("nntp_fetch_headers()", buf);
#endif
- FREE (&fc.messages);
+ mem_free (&fc.messages);
return -1;
}
}
else {
- /* mutt_nntp_query() issues a 'GROUP nntp_data->group'
- * command on its own if !*buf */
- buf[0] = '\0';
- mutt_nntp_query (nntp_data, buf, sizeof (buf));
- if (sscanf (buf + 4, "%d %u %u %s", &num, &fc.first, &fc.last, buf) != 4) {
- mutt_error (_("GROUP command failed: %s"), buf);
- FREE (&fc.messages);
- return (-1);
- }
- else {
- for (num = fc.first; num < fc.last; num++)
- _nntp_fetch_numbers (num, &fc);
- }
+ for (num = 0; num < last - first + 1; num++)
+ fc.messages[num] = 1;
}
/* CACHE: must be loaded xover cache here */
num = nntp_data->lastCached - first + 1;
if (option (OPTNEWSCACHE) && nntp_data->cache && num > 0) {
nntp_cache_expand (buf, nntp_data->cache);
- mutt_message _("Fetching headers from cache...");
+ mutt_message (msg2);
if ((f = safe_fopen (buf, "r"))) {
- int r = 0;
+ int r = 0, c = 0;
/* counting number of lines */
while (fgets (buf, sizeof (buf), f) != NULL)
fc.first = first;
fc.last = first + num - 1;
fc.msg = NULL;
- while (fgets (buf, sizeof (buf), f) != NULL)
+ while (fgets (buf, sizeof (buf), f) != NULL) {
+ if (ReadInc && ((++c) % ReadInc == 0))
+ mutt_message ("%s %d/%d", msg2, c, r);
add_xover_line (buf, &fc);
+ }
fclose (f);
nntp_data->lastLoaded = fc.last;
first = fc.last + 1;
}
num = last - first + 1;
if (num <= 0) {
- FREE (&fc.messages);
+ mem_free (&fc.messages);
return 0;
}
#ifdef DEBUG
nntp_error ("nntp_fetch_headers()", buf);
#endif
- FREE (&fc.messages);
+ mem_free (&fc.messages);
return -1;
}
/* fetched OK */
else
mutt_free_header (&h); /* skip it */
if (ret == -1) {
- FREE (&fc.messages);
+ mem_free (&fc.messages);
return -1;
}
if (current > nntp_data->lastLoaded)
nntp_data->lastLoaded = current;
}
- FREE (&fc.messages);
+ mem_free (&fc.messages);
nntp_data->lastLoaded = last;
mutt_clear_error ();
return 0;
unsigned int first;
ACCOUNT acct;
+ memset (&acct, 0, sizeof (ACCOUNT));
+
if (nntp_parse_url (ctx->path, &acct, buf, sizeof (buf)) < 0 || !*buf) {
mutt_error (_("%s is an invalid newsgroup specification!"), ctx->path);
mutt_sleep (2);
/* create NNTP-specific state struct if nof found in list */
if ((nntp_data = (NNTP_DATA *) hash_find (serv->newsgroups, buf)) == NULL) {
- nntp_data = safe_calloc (1, sizeof (NNTP_DATA) + safe_strlen (buf) + 1);
+ nntp_data = mem_calloc (1, sizeof (NNTP_DATA) + str_len (buf) + 1);
nntp_data->group = (char *) nntp_data + sizeof (NNTP_DATA);
strcpy (nntp_data->group, buf);
hash_insert (serv->newsgroups, nntp_data->group, nntp_data, 0);
return -1;
}
- if (safe_strncmp ("211", buf, 3)) {
+ if (str_ncmp ("211", buf, 3)) {
LIST *l = serv->list;
/* GROUP command failed */
- if (!safe_strncmp ("411", buf, 3)) {
+ if (!str_ncmp ("411", buf, 3)) {
mutt_error (_("Newsgroup %s not found on server %s"),
nntp_data->group, serv->conn->account.host);
cache->index = ctx->hdrs[msgno]->index;
mutt_mktemp (path);
- cache->path = safe_strdup (path);
+ cache->path = str_dup (path);
if (!(msg->fp = safe_fopen (path, "w+"))) {
- FREE (&cache->path);
+ mem_free (&cache->path);
return -1;
}
if (ret) {
fclose (msg->fp);
unlink (path);
- FREE (&cache->path);
+ mem_free (&cache->path);
return -1;
}
buf[0] = '.';
buf[1] = '\0';
while (fgets (buf + 1, sizeof (buf) - 2, f) != NULL) {
- len = safe_strlen (buf);
+ len = str_len (buf);
if (buf[len - 1] == '\n') {
buf[len - 1] = '\r';
buf[len] = '\n';
}
fclose (f);
- if (buf[safe_strlen (buf) - 1] != '\n')
+ if (buf[str_len (buf) - 1] != '\n')
mutt_socket_write_d (nntp_data->nserv->conn, "\r\n", M_SOCK_LOG_HDR);
mutt_socket_write_d (nntp_data->nserv->conn, ".\r\n", M_SOCK_LOG_HDR);
if (mutt_socket_readln (buf, sizeof (buf), nntp_data->nserv->conn) < 0) {
{
char buf[LONG_STRING];
CONNECTION *conn;
- CONNECTION *tmp;
conn = mutt_socket_head ();
while (conn) {
- tmp = conn;
-
+ CONNECTION* next = conn->next;
if (conn->account.type == M_ACCT_TYPE_NNTP) {
mutt_message (_("Closing connection to %s..."), conn->account.host);
mutt_socket_write (conn, "QUIT\r\n");
mutt_socket_readln (buf, sizeof (buf), conn);
mutt_clear_error ();
mutt_socket_close (conn);
-
- mutt_socket_free (tmp);
+ mutt_socket_free (conn);
}
-
- conn = conn->next;
+ conn = next;
}
}
for (i = 0; i < NNTP_CACHE_LEN; i++) {
if (data->acache[i].path) {
unlink (data->acache[i].path);
- FREE (&data->acache[i].path);
+ mem_free (&data->acache[i].path);
}
}
}
if (!p)
return;
- FREE (&data->entries);
- FREE (&data->desc);
- FREE (&data->cache);
+ mem_free (&data->entries);
+ mem_free (&data->desc);
+ mem_free (&data->cache);
nntp_free_acache (data);
- FREE (p);
+ mem_free (p);
}
int nntp_sync_mailbox (CONTEXT * ctx, int unused1, int* unused2)
if ((tmp = hash_find (data->nserv->newsgroups, data->group)) == NULL
|| tmp != data)
nntp_delete_data (data);
+ else
+ nntp_sync_sidebar (data);
}
/* commit changes and terminate connection */
#endif
return -1;
}
- if (safe_strncmp ("211", buf, 3)) {
+ if (str_ncmp ("211", buf, 3)) {
buf[0] = 0;
if (mutt_nntp_query (nntp_data, buf, sizeof (buf)) < 0) {
#ifdef DEBUG
return -1;
}
}
- if (!safe_strncmp ("211", buf, 3)) {
+ if (!str_ncmp ("211", buf, 3)) {
int first;
int last;
/* active was renumbered? */
if (last < nntp_data->lastLoaded) {
if (!nntp_data->max) {
- nntp_data->entries = safe_calloc (5, sizeof (NEWSRC_ENTRY));
+ nntp_data->entries = mem_calloc (5, sizeof (NEWSRC_ENTRY));
nntp_data->max = 5;
}
nntp_data->lastCached = 0;
nntp_data->entries[0].first = 1;
nntp_data->entries[0].last = 0;
}
+ nntp_sync_sidebar (nntp_data);
}
time (&nntp_data->nserv->check_time);
return 0;
if ((nntp_data = (NNTP_DATA *) hash_find (s->newsgroups, group)) == NULL) {
n++;
- nntp_data = safe_calloc (1, sizeof (NNTP_DATA) + safe_strlen (group) + 1);
+ nntp_data = mem_calloc (1, sizeof (NNTP_DATA) + str_len (group) + 1);
nntp_data->group = (char *) nntp_data + sizeof (NNTP_DATA);
strcpy (nntp_data->group, group);
nntp_data->nserv = s;
else
nntp_data->allowed = 0;
if (nntp_data->desc)
- FREE (&nntp_data->desc);
+ mem_free (&nntp_data->desc);
if (*desc)
- nntp_data->desc = safe_strdup (desc);
+ nntp_data->desc = str_dup (desc);
if (nntp_data->rc || nntp_data->lastCached)
mutt_newsgroup_stat (nntp_data);
else if (nntp_data->lastMessage &&
if (l->data && ((NNTP_DATA *) l->data)->subscribed)
_nntp_check_mailbox (NULL, (NNTP_DATA *) l->data);
}
+ sidebar_draw (CurrentMenu);
}
else if (!force)
return 0;
return 0;
}
else {
- FREE (&serv->cache);
+ mem_free (&serv->cache);
return -1;
}
}
if (cc->ctx->hdrs[i]->article_num == n)
return 0;
if (cc->num >= cc->max)
- safe_realloc (&cc->child, sizeof (unsigned int) * (cc->max += 25));
+ mem_realloc (&cc->child, sizeof (unsigned int) * (cc->max += 25));
cc->child[cc->num++] = n;
return 0;
cc.ctx = ctx;
cc.num = 0;
cc.max = 25;
- cc.child = safe_malloc (sizeof (unsigned int) * 25);
+ cc.child = mem_malloc (sizeof (unsigned int) * 25);
if (mutt_nntp_fetch (nntp_data, buf, NULL, check_children, &cc, 0)) {
- FREE (&cc.child);
+ mem_free (&cc.child);
return -1;
}
/* dont try to read the xover cache. check_children() already
}
if (tmp)
set_option (OPTNEWSCACHE);
- FREE (&cc.child);
+ mem_free (&cc.child);
return ret;
}