projects
/
apps
/
madmutt.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
simplify mutt_expand_path
[apps/madmutt.git]
/
pop
/
pop_lib.c
diff --git
a/pop/pop_lib.c
b/pop/pop_lib.c
index
2880de5
..
b3bac5a
100644
(file)
--- a/
pop/pop_lib.c
+++ b/
pop/pop_lib.c
@@
-7,53
+7,41
@@
* please see the file GPL in the top level source directory.
*/
* please see the file GPL in the top level source directory.
*/
-#if HAVE_CONFIG_H
-# include "config.h"
-#endif
+#include <lib-lib/lib-lib.h>
+#include <lib-mx/mx.h>
#include "mutt.h"
#include "mutt.h"
-#include "mx.h"
-#include "url.h"
#include "pop.h"
#include "pop.h"
-#if
def USE_SSL
-# include
"mutt_ssl.h"
+#if
defined (USE_SSL) || defined (USE_GNUTLS)
+# include
<lib-sys/mutt_ssl.h>
#endif
#endif
-#include "lib/mem.h"
-#include "lib/intl.h"
-#include "lib/debug.h"
-#include "lib/str.h"
-
-#include <string.h>
-#include <unistd.h>
-#include <ctype.h>
-
/* given an POP mailbox name, return host, port, username and password */
/* given an POP mailbox name, return host, port, username and password */
-int pop_parse_path (const char *path, ACCOUNT * ac
c
t)
+int pop_parse_path (const char *path, ACCOUNT * act)
{
ciss_url_t url;
char *c;
int ret = -1;
/* Defaults */
{
ciss_url_t url;
char *c;
int ret = -1;
/* Defaults */
- ac
c
t->flags = 0;
- ac
c
t->port = POP_PORT;
- ac
c
t->type = M_ACCT_TYPE_POP;
+ act->flags = 0;
+ act->port = POP_PORT;
+ act->type = M_ACCT_TYPE_POP;
- c =
safe_strdup
(path);
+ c =
m_strdup
(path);
url_parse_ciss (&url, c);
if (url.scheme == U_POP || url.scheme == U_POPS) {
if (url.scheme == U_POPS) {
url_parse_ciss (&url, c);
if (url.scheme == U_POP || url.scheme == U_POPS) {
if (url.scheme == U_POPS) {
- ac
c
t->flags |= M_ACCT_SSL;
- ac
c
t->port = POP_SSL_PORT;
+ act->flags |= M_ACCT_SSL;
+ act->port = POP_SSL_PORT;
}
}
- if ((!url.path || !*url.path) && mutt_account_fromurl (ac
c
t, &url) == 0)
+ if ((!url.path || !*url.path) && mutt_account_fromurl (act, &url) == 0)
ret = 0;
}
ret = 0;
}
-
FREE
(&c);
+
p_delete
(&c);
return ret;
}
return ret;
}
@@
-65,16
+53,14
@@
void pop_error (POP_DATA * pop_data, char *msg)
t = strchr (pop_data->err_msg, '\0');
c = msg;
t = strchr (pop_data->err_msg, '\0');
c = msg;
- if (!safe_strncmp (msg, "-ERR ", 5)) {
- c2 = msg + 5;
- SKIPWS (c2);
-
+ if (!m_strncmp(msg, "-ERR ", 5)) {
+ c2 = vskipspaces(msg + 5);
if (*c2)
c = c2;
}
if (*c2)
c = c2;
}
-
strfcpy (t, c, sizeof (pop_data->err_msg) - strlen (pop_data->err_msg)
);
-
str_skip_trailws
(pop_data->err_msg);
+
m_strcpy(t, sizeof(pop_data->err_msg) - strlen(pop_data->err_msg), c
);
+
m_strrtrim
(pop_data->err_msg);
}
/* Parse CAPA output */
}
/* Parse CAPA output */
@@
-84,10
+70,9
@@
static int fetch_capa (char *line, void *data)
char *c;
if (!ascii_strncasecmp (line, "SASL", 4)) {
char *c;
if (!ascii_strncasecmp (line, "SASL", 4)) {
- FREE (&pop_data->auth_list);
- c = line + 4;
- SKIPWS (c);
- pop_data->auth_list = safe_strdup (c);
+ p_delete(&pop_data->auth_list);
+ c = vskipspaces(line + 4);
+ pop_data->auth_list = m_strdup(c);
}
else if (!ascii_strncasecmp (line, "STLS", 4))
}
else if (!ascii_strncasecmp (line, "STLS", 4))
@@
-111,12
+96,10
@@
static int fetch_auth (char *line, void *data)
POP_DATA *pop_data = (POP_DATA *) data;
if (!pop_data->auth_list) {
POP_DATA *pop_data = (POP_DATA *) data;
if (!pop_data->auth_list) {
- pop_data->auth_list = safe_malloc (strlen (line) + 1);
- *pop_data->auth_list = '\0';
- }
- else {
- safe_realloc (&pop_data->auth_list,
- strlen (pop_data->auth_list) + strlen (line) + 2);
+ pop_data->auth_list = p_new(char, strlen(line) + 1);
+ } else {
+ p_realloc(&pop_data->auth_list,
+ strlen(pop_data->auth_list) + strlen(line) + 2);
strcat (pop_data->auth_list, " "); /* __STRCAT_CHECKED__ */
}
strcat (pop_data->auth_list, line); /* __STRCAT_CHECKED__ */
strcat (pop_data->auth_list, " "); /* __STRCAT_CHECKED__ */
}
strcat (pop_data->auth_list, line); /* __STRCAT_CHECKED__ */
@@
-148,18
+131,19
@@
static pop_query_status pop_capabilities (POP_DATA * pop_data, int mode)
pop_data->resp_codes = 0;
pop_data->expire = 1;
pop_data->login_delay = 0;
pop_data->resp_codes = 0;
pop_data->expire = 1;
pop_data->login_delay = 0;
-
FREE
(&pop_data->auth_list);
+
p_delete
(&pop_data->auth_list);
}
/* Execute CAPA command */
if (mode == 0 || pop_data->cmd_capa != CMD_NOT_AVAILABLE) {
}
/* Execute CAPA command */
if (mode == 0 || pop_data->cmd_capa != CMD_NOT_AVAILABLE) {
-
strfcpy (buf, "CAPA\r\n", sizeof (buf)
);
+
m_strcpy(buf, sizeof(buf), "CAPA\r\n"
);
switch (pop_fetch_data (pop_data, buf, NULL, fetch_capa, pop_data)) {
case PQ_OK:
{
pop_data->cmd_capa = CMD_AVAILABLE;
break;
}
switch (pop_fetch_data (pop_data, buf, NULL, fetch_capa, pop_data)) {
case PQ_OK:
{
pop_data->cmd_capa = CMD_AVAILABLE;
break;
}
+ case PFD_FUNCT_ERROR:
case PQ_ERR:
{
pop_data->cmd_capa = CMD_NOT_AVAILABLE;
case PQ_ERR:
{
pop_data->cmd_capa = CMD_NOT_AVAILABLE;
@@
-176,7
+160,7
@@
static pop_query_status pop_capabilities (POP_DATA * pop_data, int mode)
pop_data->cmd_uidl = CMD_UNKNOWN;
pop_data->cmd_top = CMD_UNKNOWN;
pop_data->cmd_uidl = CMD_UNKNOWN;
pop_data->cmd_top = CMD_UNKNOWN;
-
strfcpy (buf, "AUTH\r\n", sizeof (buf)
);
+
m_strcpy(buf, sizeof(buf), "AUTH\r\n"
);
if (pop_fetch_data (pop_data, buf, NULL, fetch_auth, pop_data) == PQ_NOT_CONNECTED)
return PQ_NOT_CONNECTED;
}
if (pop_fetch_data (pop_data, buf, NULL, fetch_auth, pop_data) == PQ_NOT_CONNECTED)
return PQ_NOT_CONNECTED;
}
@@
-221,7
+205,7
@@
pop_query_status pop_connect (POP_DATA * pop_data)
pop_data->status = POP_CONNECTED;
pop_data->status = POP_CONNECTED;
- if (
safe_strncmp
(buf, "+OK", 3)) {
+ if (
m_strncmp
(buf, "+OK", 3)) {
*pop_data->err_msg = '\0';
pop_error (pop_data, buf);
mutt_error ("%s", pop_data->err_msg);
*pop_data->err_msg = '\0';
pop_error (pop_data, buf);
mutt_error ("%s", pop_data->err_msg);
@@
-260,9
+244,11
@@
pop_query_status pop_open_connection (POP_DATA * pop_data)
return PQ_ERR;
}
return PQ_ERR;
}
-#if (defined(USE_SSL) || defined(USE_GNUTLS))
&& !defined(USE_NSS)
+#if (defined(USE_SSL) || defined(USE_GNUTLS))
/* Attempt STLS if available and desired. */
/* Attempt STLS if available and desired. */
- if (pop_data->cmd_stls && !pop_data->conn->ssf) {
+ if (!pop_data->conn->ssf && (pop_data->cmd_stls || option(OPTSSLFORCETLS))) {
+ if (option (OPTSSLFORCETLS))
+ pop_data->use_stls = 2;
if (pop_data->use_stls == 0) {
ret = query_quadoption (OPT_SSLSTARTTLS,
_("Secure connection with TLS?"));
if (pop_data->use_stls == 0) {
ret = query_quadoption (OPT_SSLSTARTTLS,
_("Secure connection with TLS?"));
@@
-273,7
+259,7
@@
pop_query_status pop_open_connection (POP_DATA * pop_data)
pop_data->use_stls = 2;
}
if (pop_data->use_stls == 2) {
pop_data->use_stls = 2;
}
if (pop_data->use_stls == 2) {
-
strfcpy (buf, "STLS\r\n", sizeof (buf)
);
+
m_strcpy(buf, sizeof(buf), "STLS\r\n"
);
ret = pop_query (pop_data, buf, sizeof (buf));
if (ret == PQ_NOT_CONNECTED)
goto err_conn;
ret = pop_query (pop_data, buf, sizeof (buf));
if (ret == PQ_NOT_CONNECTED)
goto err_conn;
@@
-281,10
+267,8
@@
pop_query_status pop_open_connection (POP_DATA * pop_data)
mutt_error ("%s", pop_data->err_msg);
mutt_sleep (2);
}
mutt_error ("%s", pop_data->err_msg);
mutt_sleep (2);
}
-#if
def USE_SSL
+#if
defined (USE_SSL) || defined (USE_GNUTLS)
else if (mutt_ssl_starttls (pop_data->conn))
else if (mutt_ssl_starttls (pop_data->conn))
-#elif USE_GNUTLS
- else if (mutt_gnutls_starttls (pop_data->conn))
#endif
{
mutt_error (_("Could not negotiate TLS connection"));
#endif
{
mutt_error (_("Could not negotiate TLS connection"));
@@
-303,6
+287,12
@@
pop_query_status pop_open_connection (POP_DATA * pop_data)
}
}
}
}
}
}
+
+ if (option(OPTSSLFORCETLS) && !pop_data->conn->ssf) {
+ mutt_error _("Encrypted connection unavailable");
+ mutt_sleep (1);
+ return -2;
+ }
#endif
ret = pop_authenticate (pop_data);
#endif
ret = pop_authenticate (pop_data);
@@
-323,7
+313,7
@@
pop_query_status pop_open_connection (POP_DATA * pop_data)
}
/* get total size of mailbox */
}
/* get total size of mailbox */
-
strfcpy (buf, "STAT\r\n", sizeof (buf)
);
+
m_strcpy(buf, sizeof(buf), "STAT\r\n"
);
ret = pop_query (pop_data, buf, sizeof (buf));
if (ret == PQ_NOT_CONNECTED)
goto err_conn;
ret = pop_query (pop_data, buf, sizeof (buf));
if (ret == PQ_NOT_CONNECTED)
goto err_conn;
@@
-356,12
+346,12
@@
void pop_logout (CONTEXT * ctx)
mutt_message _("Closing connection to POP server...");
if (ctx->readonly) {
mutt_message _("Closing connection to POP server...");
if (ctx->readonly) {
-
strfcpy (buf, "RSET\r\n", sizeof (buf)
);
+
m_strcpy(buf, sizeof(buf), "RSET\r\n"
);
ret = pop_query (pop_data, buf, sizeof (buf));
}
if (ret != PQ_NOT_CONNECTED) {
ret = pop_query (pop_data, buf, sizeof (buf));
}
if (ret != PQ_NOT_CONNECTED) {
-
strfcpy (buf, "QUIT\r\n", sizeof (buf)
);
+
m_strcpy(buf, sizeof(buf), "QUIT\r\n"
);
pop_query (pop_data, buf, sizeof (buf));
}
pop_query (pop_data, buf, sizeof (buf));
}
@@
-378,23
+368,14
@@
void pop_logout (CONTEXT * ctx)
* -1 - conection lost,
* -2 - invalid command or execution error.
*/
* -1 - conection lost,
* -2 - invalid command or execution error.
*/
-pop_query_status pop_query
_d (POP_DATA * pop_data, char *buf, size_t buflen, char *msg
)
+pop_query_status pop_query
(POP_DATA * pop_data, char *buf, size_t buflen
)
{
{
- int dbg = M_SOCK_LOG_CMD;
char *c;
if (pop_data->status != POP_CONNECTED)
return PQ_NOT_CONNECTED;
char *c;
if (pop_data->status != POP_CONNECTED)
return PQ_NOT_CONNECTED;
-#ifdef DEBUG
- /* print msg instaed of real command */
- if (msg) {
- dbg = M_SOCK_LOG_FULL;
- debug_print (M_SOCK_LOG_CMD, ("> %s", msg));
- }
-#endif
-
- mutt_socket_write_d (pop_data->conn, buf, dbg);
+ mutt_socket_write(pop_data->conn, buf);
c = strpbrk (buf, " \r\n");
*c = '\0';
c = strpbrk (buf, " \r\n");
*c = '\0';
@@
-404,7
+385,7
@@
pop_query_status pop_query_d (POP_DATA * pop_data, char *buf, size_t buflen, cha
pop_data->status = POP_DISCONNECTED;
return PQ_NOT_CONNECTED;
}
pop_data->status = POP_DISCONNECTED;
return PQ_NOT_CONNECTED;
}
- if (!
safe_strncmp
(buf, "+OK", 3))
+ if (!
m_strncmp
(buf, "+OK", 3))
return PQ_OK;
pop_error (pop_data, buf);
return PQ_OK;
pop_error (pop_data, buf);
@@
-420,27
+401,27
@@
pop_query_status pop_query_d (POP_DATA * pop_data, char *buf, size_t buflen, cha
* -2 - invalid command or execution error,
* -3 - error in funct(*line, *data)
*/
* -2 - invalid command or execution error,
* -3 - error in funct(*line, *data)
*/
-pop_query_status pop_fetch_data (POP_DATA * pop_data, c
har *query, char *msg
,
+pop_query_status pop_fetch_data (POP_DATA * pop_data, c
onst char *query, progress_t* bar
,
int (*funct) (char *, void *), void *data)
{
char buf[LONG_STRING];
char *inbuf;
char *p;
pop_query_status ret;
int (*funct) (char *, void *), void *data)
{
char buf[LONG_STRING];
char *inbuf;
char *p;
pop_query_status ret;
- int chunk, line = 0;
+ int chunk = 0;
+ long pos = 0;
size_t lenbuf = 0;
size_t lenbuf = 0;
-
strfcpy (buf, query, sizeof (buf)
);
+
m_strcpy(buf, sizeof(buf), query
);
ret = pop_query (pop_data, buf, sizeof (buf));
if (ret != PQ_OK)
return ret;
ret = pop_query (pop_data, buf, sizeof (buf));
if (ret != PQ_OK)
return ret;
- inbuf =
safe_malloc (sizeof
(buf));
+ inbuf =
p_new(char, sizeof
(buf));
-
FOREVER
{
+
for (;;)
{
chunk =
chunk =
- mutt_socket_readln_d (buf, sizeof (buf), pop_data->conn,
- M_SOCK_LOG_HDR);
+ mutt_socket_readln(buf, sizeof (buf), pop_data->conn);
if (chunk < 0) {
pop_data->status = POP_DISCONNECTED;
ret = PQ_NOT_CONNECTED;
if (chunk < 0) {
pop_data->status = POP_DISCONNECTED;
ret = PQ_NOT_CONNECTED;
@@
-454,38
+435,36
@@
pop_query_status pop_fetch_data (POP_DATA * pop_data, char *query, char *msg,
p++;
}
p++;
}
- strfcpy (inbuf + lenbuf, p, sizeof (buf));
+ m_strcpy(inbuf + lenbuf,sizeof(buf), p);
+ pos += chunk;
- if (chunk >= s
izeof
(buf)) {
+ if (chunk >= s
sizeof
(buf)) {
lenbuf += strlen (p);
lenbuf += strlen (p);
- }
- else {
- line++;
- if (msg && ReadInc && (line % ReadInc == 0))
- mutt_message ("%s %d", msg, line);
+ } else {
+ if (bar)
+ mutt_progress_bar (bar, pos);
if (ret == 0 && funct (inbuf, data) < 0)
ret = PFD_FUNCT_ERROR;
lenbuf = 0;
}
if (ret == 0 && funct (inbuf, data) < 0)
ret = PFD_FUNCT_ERROR;
lenbuf = 0;
}
-
safe_realloc (&inbuf, lenbuf + sizeof
(buf));
+
p_realloc(&inbuf, lenbuf + sizeof
(buf));
}
}
-
FREE
(&inbuf);
+
p_delete
(&inbuf);
return ret;
}
/* find message with this UIDL and set refno */
static int check_uidl (char *line, void *data)
{
return ret;
}
/* find message with this UIDL and set refno */
static int check_uidl (char *line, void *data)
{
- int i;
- unsigned int index;
- CONTEXT *ctx = (CONTEXT *) data;
+ int i, idx;
+ CONTEXT *ctx = (CONTEXT *)data;
- sscanf (line, "%u %s", &i
nde
x, line);
+ sscanf (line, "%u %s", &i
d
x, line);
for (i = 0; i < ctx->msgcount; i++) {
for (i = 0; i < ctx->msgcount; i++) {
- if (!m
utt_strcmp
(ctx->hdrs[i]->data, line)) {
- ctx->hdrs[i]->refno = i
nde
x;
+ if (!m
_strcmp
(ctx->hdrs[i]->data, line)) {
+ ctx->hdrs[i]->refno = i
d
x;
break;
}
}
break;
}
}
@@
-498,26
+477,28
@@
pop_query_status pop_reconnect (CONTEXT * ctx)
{
pop_query_status ret;
POP_DATA *pop_data = (POP_DATA *) ctx->data;
{
pop_query_status ret;
POP_DATA *pop_data = (POP_DATA *) ctx->data;
+ progress_t bar;
if (pop_data->status == POP_CONNECTED)
return PQ_OK;
if (pop_data->status == POP_BYE)
return PQ_NOT_CONNECTED;
if (pop_data->status == POP_CONNECTED)
return PQ_OK;
if (pop_data->status == POP_BYE)
return PQ_NOT_CONNECTED;
-
FOREVER
{
+
for (;;)
{
mutt_socket_close (pop_data->conn);
ret = pop_open_connection (pop_data);
if (ret == PQ_OK) {
mutt_socket_close (pop_data->conn);
ret = pop_open_connection (pop_data);
if (ret == PQ_OK) {
- char *msg = _("Verifying message indexes...");
int i;
int i;
+ bar.msg = _("Verifying message indexes...");
+ bar.size = 0;
+ mutt_progress_bar (&bar, 0);
+
for (i = 0; i < ctx->msgcount; i++)
ctx->hdrs[i]->refno = -1;
for (i = 0; i < ctx->msgcount; i++)
ctx->hdrs[i]->refno = -1;
- mutt_message (msg);
-
- ret = pop_fetch_data (pop_data, "UIDL\r\n", msg, check_uidl, ctx);
+ ret = pop_fetch_data(pop_data, "UIDL\r\n", &bar, check_uidl, ctx);
if (ret == PQ_ERR) {
mutt_error ("%s", pop_data->err_msg);
mutt_sleep (2);
if (ret == PQ_ERR) {
mutt_error ("%s", pop_data->err_msg);
mutt_sleep (2);