#endif
#include <lib-lib/mem.h>
+#include <lib-lib/ascii.h>
+#include <lib-lib/macros.h>
+#include <lib-hash/hash.h>
+#include <lib-lib/debug.h>
#include "mutt.h"
-#include "ascii.h"
#include "mx.h"
-#include "md5.h"
#include "pop.h"
-#include "lib/intl.h"
-#include "lib/debug.h"
#include <string.h>
#include <unistd.h>
if (!method)
method = pop_data->auth_list;
- FOREVER {
+ for (;;) {
#ifdef USE_SASL
rc =
sasl_client_start (saslconn, method, &interaction, &pc, &olen, &mech);
olen = strlen (buf);
/* looping protocol */
- FOREVER {
- strfcpy (buf + olen, "\r\n", sizeof (buf) - olen);
+ for (;;) {
+ m_strcpy(buf + olen, sizeof(buf) - olen, "\r\n");
mutt_socket_write (pop_data->conn, buf);
if (mutt_socket_readln (inbuf, sizeof (inbuf), pop_data->conn) < 0) {
sasl_dispose (&saslconn);
break;
#ifdef USE_SASL
- if (!str_ncmp (inbuf, "+ ", 2)
+ if (!m_strncmp(inbuf, "+ ", 2)
&& sasl_decode64 (inbuf, strlen (inbuf), buf, LONG_STRING - 1,
&len) != SASL_OK)
#endif
}
if (!client_start)
- FOREVER {
+ for (;;) {
rc = sasl_client_step (saslconn, buf, len, &interaction, &pc, &olen);
if (rc != SASL_INTERACT)
break;
if (rc != SASL_OK)
goto bail;
- if (!str_ncmp (inbuf, "+OK", 3)) {
+ if (!m_strncmp(inbuf, "+OK", 3)) {
mutt_sasl_setup_conn (pop_data->conn, saslconn);
return POP_A_SUCCESS;
}
sasl_dispose (&saslconn);
/* terminate SASL sessoin if the last responce is not +OK nor -ERR */
- if (!str_ncmp (inbuf, "+ ", 2)) {
+ if (!m_strncmp(inbuf, "+ ", 2)) {
snprintf (buf, sizeof (buf), "*\r\n");
if (pop_query (pop_data, buf, sizeof (buf)) == PQ_NOT_CONNECTED)
return POP_A_SOCKET;
if ((p1 = strchr (buf, '<')) && (p2 = strchr (p1, '>'))) {
p2[1] = '\0';
- pop_data->timestamp = str_dup (p1);
+ pop_data->timestamp = m_strdup(p1);
}
}
strlen (pop_data->conn->account.pass));
MD5Final (digest, &mdContext);
- for (i = 0; i < sizeof (digest); i++)
+ for (i = 0; i < ssizeof(digest); i++)
sprintf (hash + 2 * i, "%02x", digest[i]);
/* Send APOP command to server */
- snprintf (buf, sizeof (buf), "APOP %s %s\r\n", pop_data->conn->account.user,
- hash);
+ snprintf(buf, sizeof(buf), "APOP %s %s\r\n", pop_data->conn->account.user,
+ hash);
switch (pop_query (pop_data, buf, sizeof (buf))) {
case PQ_OK:
*/
pop_query_status pop_authenticate (POP_DATA * pop_data)
{
- ACCOUNT *acct = &pop_data->conn->account;
+ ACCOUNT *act = &pop_data->conn->account;
pop_auth_t *authenticator;
char *methods;
char *comma;
int attempts = 0;
int ret = POP_A_UNAVAIL;
- if (mutt_account_getuser (acct) || !acct->user[0] ||
- mutt_account_getpass (acct) || !acct->pass[0])
+ if (mutt_account_getuser (act) || !act->user[0] ||
+ mutt_account_getpass (act) || !act->pass[0])
return PFD_FUNCT_ERROR;
if (PopAuthenticators && *PopAuthenticators) {
/* Try user-specified list of authentication methods */
- methods = str_dup (PopAuthenticators);
+ methods = m_strdup(PopAuthenticators);
method = methods;
while (method) {