X-Git-Url: http://git.madism.org/?a=blobdiff_plain;ds=sidebyside;f=nntp%2Fnewsrc.c;h=c919d86f54a654439f02fcf3372c540a49ce7ec3;hb=1f34780e2ee55984ebd4265bd7b308c6aeee348f;hp=4d45c0dc1142176c4e463d6cd4a228ade1a1850f;hpb=23e6291cb5d5b4cd2008403d8b628007fd75ff23;p=apps%2Fmadmutt.git

diff --git a/nntp/newsrc.c b/nntp/newsrc.c
index 4d45c0d..c919d86 100644
--- a/nntp/newsrc.c
+++ b/nntp/newsrc.c
@@ -9,46 +9,23 @@
  * please see the file GPL in the top level source directory.
  */
 
-#ifdef HAVE_CONFIG_H
-#include <config.h>
-#endif
-
-#include <unistd.h>
-#include <string.h>
-#include <ctype.h>
-#include <stdlib.h>
-#include <libgen.h>
-#include <sys/stat.h>
+#include <lib-lib/lib-lib.h>
 
-#include <lib-lib/mem.h>
-#include <lib-lib/str.h>
-#include <lib-lib/file.h>
-#include <lib-lib/macros.h>
+#include <libgen.h>
 
 #include <lib-mime/mime.h>
-
 #include <lib-ui/curses.h>
+#include <lib-mx/mx.h>
 
 #include "mutt.h"
 #include "sort.h"
-#include "mx.h"
 #include "nntp.h"
-#include "rfc1524.h"
 
-void nntp_add_to_list (NNTP_SERVER * s, NNTP_DATA * d)
+void nntp_add_to_list(NNTP_SERVER *s, NNTP_DATA *d)
 {
-  string_list_t *l;
-
-  if (!s || !d)
-    return;
-
-  l = p_new(string_list_t, 1);
-  if (s->list)
-    s->tail->next = l;
-  else
-    s->list = l;
-  s->tail = l;
-  l->data = (void *) d;
+    *s->tail = p_new(string_list_t, 1);
+    (*s->tail)->data = (void *)d;
+    s->tail = &(*s->tail)->next;
 }
 
 static int nntp_parse_newsrc_line (NNTP_SERVER * news, char *line)
@@ -69,9 +46,7 @@ static int nntp_parse_newsrc_line (NNTP_SERVER * news, char *line)
     p++;
   if (!*p)
     return -1;
-  len = p + 1 - line;
-  if (len > sizeof (group))
-    len = sizeof (group);
+  len = MIN(p + 1 - line, ssizeof(group));
   m_strcpy(group, len, line);
   if ((data = (NNTP_DATA *) hash_find (news->newsgroups, group)) == NULL) {
     data = xmalloc(sizeof(NNTP_DATA) + m_strlen(group) + 1);
@@ -80,9 +55,8 @@ static int nntp_parse_newsrc_line (NNTP_SERVER * news, char *line)
     data->nserv = news;
     data->deleted = 1;
     if (news->newsgroups->nelem < news->newsgroups->curnelem * 2)
-      news->newsgroups =
         hash_resize (news->newsgroups, news->newsgroups->nelem * 2);
-    hash_insert (news->newsgroups, data->group, data, 0);
+    hash_insert (news->newsgroups, data->group, data);
     nntp_add_to_list (news, data);
   }
   else
@@ -143,7 +117,7 @@ static int slurp_newsrc (NNTP_SERVER * news)
     return -1;
   /* hmm, should we use dotlock? */
   if (mx_lock_file (news->newsrc, fileno (fp), 0, 0, 1)) {
-    fclose (fp);
+    m_fclose(&fp);
     return -1;
   }
 
@@ -153,7 +127,7 @@ static int slurp_newsrc (NNTP_SERVER * news)
   p_delete(&buf);
 
   mx_unlock_file (news->newsrc, fileno (fp), 0);
-  fclose (fp);
+  m_fclose(&fp);
   return 0;
 }
 
@@ -178,7 +152,7 @@ static int nntp_parse_cacheindex (NNTP_SERVER * news)
   if (!news || !news->conn || !news->conn->account.host)
     return -1;
   unset_option (OPTNEWSCACHE);
-  if (!NewsCacheDir || !*NewsCacheDir)
+  if (m_strisempty(NewsCacheDir))
     return 0;
 
   m_strcpy(dir, sizeof(dir), NewsCacheDir);
@@ -231,9 +205,8 @@ static int nntp_parse_cacheindex (NNTP_SERVER * news)
         data->nserv = news;
         data->deleted = 1;
         if (news->newsgroups->nelem < news->newsgroups->curnelem * 2)
-          news->newsgroups =
             hash_resize (news->newsgroups, news->newsgroups->nelem * 2);
-        hash_insert (news->newsgroups, data->group, data, 0);
+        hash_insert (news->newsgroups, data->group, data);
         nntp_add_to_list (news, data);
       }
       data->cache = m_strdup(file);
@@ -249,16 +222,18 @@ static int nntp_parse_cacheindex (NNTP_SERVER * news)
         mutt_newsgroup_stat (data);
     }
   }
-  fclose (idx);
+  m_fclose(&idx);
   return 0;
 }
 
-const char *nntp_format_str (char *dest, ssize_t destlen, char op,
-                             const char *src, const char *fmt,
-                             const char *ifstring, const char *elsestring,
-                             unsigned long data, format_flag flags)
+const char *nntp_format_str(char *dest, ssize_t destlen, char op,
+                            const char *src, const char *fmt,
+                            const char *ifstr __attribute__((unused)),
+                            const char *elstr __attribute__((unused)),
+                            anytype data __attribute__((unused)),
+                            format_flag flags __attribute__((unused)))
 {
-  char fn[SHORT_STRING], tmp[SHORT_STRING];
+  char fn[STRING], tmp[STRING];
 
   switch (op) {
   case 's':
@@ -290,7 +265,7 @@ int nntp_parse_url (const char *server, ACCOUNT * act,
 
   if (url.scheme == U_NNTP || url.scheme == U_NNTPS) {
     if (url.scheme == U_NNTPS) {
-      act->flags |= M_ACCT_SSL;
+      act->has_ssl = 1;
       act->port = NNTP_SSL_PORT;
     }
 
@@ -360,9 +335,8 @@ NNTP_SERVER *mutt_select_newsserver (char *server)
   if (!conn)
     return NULL;
 
-  mutt_FormatString (file, sizeof (file), NONULL (NewsRc), nntp_format_str, 0,
-                     0);
-  mutt_expand_path (file, sizeof (file));
+  m_strformat(file, sizeof(file), 0, NewsRc, nntp_format_str, NULL, 0);
+  mutt_expand_path(file, sizeof(file));
 
   serv = (NNTP_SERVER *) conn->data;
   if (serv) {
@@ -393,15 +367,16 @@ NNTP_SERVER *mutt_select_newsserver (char *server)
 
   /* New newsserver */
   serv = p_new(NNTP_SERVER, 1);
+  serv->tail = &serv->list;
   serv->conn = conn;
   serv->newsrc = m_strdup(file);
-  serv->newsgroups = hash_create (1009);
+  serv->newsgroups = hash_new(1009, false);
   slurp_newsrc (serv);          /* load .newsrc */
   nntp_parse_cacheindex (serv); /* load .index */
   if (option (OPTNEWSCACHE) && serv->cache && nntp_get_cache_all (serv) >= 0)
     nntp_check_newgroups (serv, 1);
   else if (nntp_get_active (serv) < 0) {
-    hash_destroy (&serv->newsgroups, nntp_delete_data);
+    hash_delete (&serv->newsgroups, nntp_delete_data);
     for (list = serv->list; list; list = list->next)
       list->data = NULL;
     string_list_wipe(&serv->list);
@@ -458,8 +433,7 @@ void nntp_get_status (CONTEXT * ctx, HEADER * h, char *group, int article)
 
 void mutt_newsgroup_stat (NNTP_DATA * data)
 {
-  int i;
-  unsigned int first, last;
+  int i, first, last;
 
   data->unread = 0;
   if (data->lastMessage == 0 || data->firstMessage > data->lastMessage)
@@ -527,15 +501,6 @@ static void nntp_create_newsrc_line (NNTP_DATA * data, char **buf,
       len--;
     }
 
-#if 0
-    if (data->entries[x].first == data->entries[x].last)
-      snprintf (line, len, "%d%n", data->entries[x].first, &i);
-    else
-      snprintf (line, len, "%d-%d%n",
-                data->entries[x].first, data->entries[x].last, &i);
-    len -= i;
-    line += i;
-#else
     i = puti (line, data->entries[x].first);
     line += i;
     len -= i;
@@ -546,7 +511,6 @@ static void nntp_create_newsrc_line (NNTP_DATA * data, char **buf,
       line += i;
       len -= i;
     }
-#endif
   }
   *line++ = '\n';
   *line = '\0';
@@ -557,7 +521,7 @@ void newsrc_gen_entries (CONTEXT * ctx)
 {
   NNTP_DATA *data = (NNTP_DATA *) ctx->data;
   int series, x;
-  unsigned int last = 0, first = 1;
+  int last = 0, first = 1;
   int save_sort = SORT_ORDER;
 
   if (Sort != SORT_ORDER) {
@@ -627,33 +591,33 @@ static int mutt_update_list_file (char *filename, char *section,
   FILE *ifp;
   FILE *ofp;
   char buf[HUGE_STRING];
-  char tmpfile[_POSIX_PATH_MAX], link[_POSIX_PATH_MAX];
+  char tmpf[_POSIX_PATH_MAX], lnk[_POSIX_PATH_MAX];
   char *c;
   int ext = 0, done = 0, r = 0, l = 0;
 
   /* if file not exist, create it */
   if ((ifp = safe_fopen (filename, "a")))
-    fclose (ifp);
+    m_fclose(&ifp);
   if (!(ifp = safe_fopen (filename, "r"))) {
     mutt_error (_("Unable to open %s for reading"), filename);
     return -1;
   }
   if (mx_lock_file (filename, fileno (ifp), 0, 0, 1)) {
-    fclose (ifp);
+    m_fclose(&ifp);
     mutt_error (_("Unable to lock %s"), filename);
     return -1;
   }
-  /* use mutt_adv_mktemp() to get a tempfile in the same
+
+  /* use m_tempfile() to get a tempfile in the same
    * directory as filename is so that we can follow symlinks
    * via rename(2); as dirname(2) may modify its argument,
    * temporarily use buf as copy of it
    */
   m_strcpy(buf, sizeof(buf), filename);
-  m_strcpy(tmpfile, sizeof(tmpfile), basename(filename));
-  mutt_adv_mktemp ((const char*) dirname (buf), tmpfile, sizeof (tmpfile));
-  if (!(ofp = fopen (tmpfile, "w"))) {
-    fclose (ifp);
-    mutt_error (_("Unable to open %s for writing"), tmpfile);
+  ofp = m_tempfile(tmpf, sizeof(tmpf), dirname(buf), filename);
+  if (!ofp) {
+    m_fclose(&ifp);
+    mutt_error (_("Unable to open %s for writing"), tmpf);
     return -1;
   }
 
@@ -714,19 +678,19 @@ static int mutt_update_list_file (char *filename, char *section,
     r = fputc ('\n', ofp);
   }
   mx_unlock_file (filename, fileno (ifp), 0);
-  fclose (ofp);
-  fclose (ifp);
+  m_fclose(&ofp);
+  m_fclose(&ifp);
   if (r == EOF) {
-    unlink (tmpfile);
-    mutt_error (_("Can't write %s"), tmpfile);
+    unlink (tmpf);
+    mutt_error (_("Can't write %s"), tmpf);
     return -1;
   }
-  link[0] = '\0';
-  if ((l = readlink (filename, link, sizeof (link)-1)) > 0)
-    link[l] = '\0';
-  if (rename (tmpfile, l > 0 ? link : filename) < 0) {
-    unlink (tmpfile);
-    mutt_error (_("Can't rename %s to %s"), tmpfile, l > 0 ? link : filename);
+  lnk[0] = '\0';
+  if ((l = readlink (filename, lnk, sizeof(lnk)-1)) > 0)
+    lnk[l] = '\0';
+  if (rename (tmpf, l > 0 ? lnk : filename) < 0) {
+    unlink (tmpf);
+    mutt_error (_("Can't rename %s to %s"), tmpf, l > 0 ? lnk : filename);
     return -1;
   }
   return 0;
@@ -862,13 +826,13 @@ int nntp_save_cache_index (NNTP_SERVER * news)
         snprintf (buf, sizeof (buf), "%s %d %d %c\n", d->group,
                   d->lastMessage, d->firstMessage, d->allowed ? 'y' : 'n');
       if (fputs (buf, f) == EOF) {
-        fclose (f);
+        m_fclose(&f);
         unlink (file);
         return -1;
       }
     }
   }
-  fclose (f);
+  m_fclose(&f);
 
   if (nntp_update_cacheindex (news, NULL)) {
     unlink (file);
@@ -922,7 +886,7 @@ int nntp_save_cache_group (CONTEXT * ctx)
     if (!ctx->hdrs[i]->deleted && ctx->hdrs[i]->article_num != prev) {
       h = ctx->hdrs[i];
       addr[0] = 0;
-      rfc822_write_address (addr, sizeof (addr), h->env->from, 0);
+      rfc822_addrcat(addr, sizeof(addr), h->env->from, 0);
       tm = gmtime (&h->date_sent);
       snprintf (buf, sizeof (buf),
                 "%d\t%s\t%s\t%d %s %d %02d:%02d:%02d GMT\t%s\t",
@@ -935,7 +899,7 @@ int nntp_save_cache_group (CONTEXT * ctx)
       snprintf (buf, sizeof (buf), "\t%zd\t%d\tXref: %s\n",
                 h->content->length, h->lines, NONULL (h->env->xref));
       if (fputs (buf, f) == EOF) {
-        fclose (f);
+        m_fclose(&f);
         unlink (file);
         return -1;
       }
@@ -947,7 +911,7 @@ int nntp_save_cache_group (CONTEXT * ctx)
     Sort = save;
     mutt_sort_headers (ctx, 0);
   }
-  fclose (f);
+  m_fclose(&f);
 
   if (nntp_update_cacheindex (((NNTP_DATA *) ctx->data)->nserv,
                               (NNTP_DATA *) ctx->data)) {
@@ -988,9 +952,8 @@ NNTP_DATA *mutt_newsgroup_subscribe (NNTP_SERVER * news, char *group)
     data->nserv = news;
     data->deleted = 1;
     if (news->newsgroups->nelem < news->newsgroups->curnelem * 2)
-      news->newsgroups =
         hash_resize (news->newsgroups, news->newsgroups->nelem * 2);
-    hash_insert (news->newsgroups, data->group, data, 0);
+    hash_insert (news->newsgroups, data->group, data);
     nntp_add_to_list (news, data);
   }
   if (!data->subscribed) {
@@ -1094,7 +1057,7 @@ void nntp_buffy (char* dst, ssize_t dstlen) {
       if (data && data->subscribed && data->unread) {
         if (Context && Context->magic == M_NNTP &&
             !m_strcmp(data->group, ((NNTP_DATA *) Context->data)->group)) {
-          unsigned int i, unread = 0;
+          int i, unread = 0;
 
           for (i = 0; i < Context->msgcount; i++)
             if (!Context->hdrs[i]->read && !Context->hdrs[i]->deleted)