X-Git-Url: http://git.madism.org/?a=blobdiff_plain;ds=sidebyside;f=postlicyd%2Fmatch.c;h=41ce3179cb10e69a045697603ee3c60342c949ab;hb=44dfcc42a03fdd403626e534ab279c9c63593e12;hp=5dbf3d4926b38aae5a56885bad93340255e241b3;hpb=b4e5271bb511fafb0a31259188c37df48fb54b2b;p=apps%2Fpfixtools.git diff --git a/postlicyd/match.c b/postlicyd/match.c index 5dbf3d4..41ce317 100644 --- a/postlicyd/match.c +++ b/postlicyd/match.c @@ -115,18 +115,17 @@ static bool match_filter_constructor(filter_t *filter) #define IS_OP_END(N) \ ((N) == '=' || (N) == 'i') match_condition_t condition = CONDITION_INIT; - const char *p = m_strnextsp(param->value); + const char *p = skipspaces(param->value); const char *n = p + 1; PARSE_CHECK(isalnum(*p), "invalid field name"); for (n = p + 1 ; *n && (isalnum(*n) || *n == '_') ; ++n); - PARSE_CHECK(*n && - (isspace(*n) || IS_OP_START(*n)), + PARSE_CHECK(*n && (isspace(*n) || IS_OP_START(*n)), "invalid condition, expected operator after field name"); condition.field = policy_tokenize(p, n - p); PARSE_CHECK(condition.field >= PTK_HELO_NAME && condition.field < PTK_SMTPD_ACCESS_POLICY, "invalid field name %.*s", n - p, p); - p = m_strnextsp(n); + p = skipspaces(n); n = p + 1; PARSE_CHECK(IS_OP_START(*p) && IS_OP_END(*n), "invalid operator %2s", p); @@ -147,7 +146,7 @@ static bool match_filter_constructor(filter_t *filter) PARSE_CHECK(condition.condition != MATCH_UNKNOWN, "invalid operator"); if (condition.condition != MATCH_EMPTY) { - p = m_strnextsp(n + 1); + p = skipspaces(n + 1); PARSE_CHECK(*p, "no value defined to check the condition"); condition.value_len = param->value_len - (p - param->value); condition.value = p_dupstr(p, condition.value_len); @@ -240,7 +239,7 @@ static inline bool match_condition(const match_condition_t *cond, const query_t break; case MATCH_EMPTY: - return !!(!!(field == NULL || *field == '\0')) ^ (!!cond->case_sensitive); + return !!((field == NULL || *field == '\0') ^ (!cond->case_sensitive)); default: assert(false && "invalid condition type"); @@ -254,15 +253,15 @@ static filter_result_t match_filter(const filter_t *filter, const query_t *query foreach (const match_condition_t *condition, config->conditions) { bool r = match_condition(condition, query); if (!r && config->match_all) { - return HTK_FALSE; + return HTK_FAIL; } else if (r && !(config->match_all)) { - return HTK_TRUE; + return HTK_MATCH; } }} if (config->match_all) { - return HTK_TRUE; + return HTK_MATCH; } else { - return HTK_FALSE; + return HTK_FAIL; } } @@ -274,8 +273,8 @@ static int match_init(void) */ (void)filter_hook_register(type, "abort"); (void)filter_hook_register(type, "error"); - (void)filter_hook_register(type, "true"); - (void)filter_hook_register(type, "false"); + (void)filter_hook_register(type, "match"); + (void)filter_hook_register(type, "fail"); /* Parameters. */