X-Git-Url: http://git.madism.org/?a=blobdiff_plain;f=common%2Fcommon.c;h=dc0e194694ff44490570c8dd6983b99351d31d73;hb=0ad0ac6446aa4490800addafd8219f0f2a968c4d;hp=af95efa7378d96b383a3b27951b7eb4a6466aa1b;hpb=520b2f3bb198bfbb88b90b058ef610f0a9b980c6;p=apps%2Fpfixtools.git diff --git a/common/common.c b/common/common.c index af95efa..dc0e194 100644 --- a/common/common.c +++ b/common/common.c @@ -41,33 +41,22 @@ #include "common.h" -sig_atomic_t sigint = false; -sig_atomic_t sighup = false; - bool daemon_process = true; int log_level = LOG_INFO; +bool log_syslog = false; static FILE *pidfile = NULL; void common_sighandler(int sig) { switch (sig) { - case SIGTERM: - case SIGINT: - sigint = true; - return; - - case SIGHUP: - sighup = true; - return; - default: - err("Killed (got signal %d)...", sig); + err("Killed (got signal %d)...", sig); exit(-1); } } -static int setnonblock(int sock) +int setnonblock(int sock) { int res = fcntl(sock, F_GETFL); @@ -199,11 +188,11 @@ int daemon_detach(void) pid = fork(); if (pid < 0) { return -1; - } + } if (pid) { - daemon_process = false; + daemon_process = false; exit(0); - } + } setsid(); return 0; @@ -236,20 +225,11 @@ int drop_privileges(const char *user, const char *group) int pidfile_open(const char *name) { - struct flock lock; - p_clear(&lock, 1); - lock.l_type = F_WRLCK; if (name) { pidfile = fopen(name, "w"); if (!pidfile) return -1; - if (fcntl(fileno(pidfile), F_SETLK, &lock) == -1) { - crit("program already started"); - fclose(pidfile); - pidfile = NULL; - return -1; - } - fprintf(pidfile, "%d\n", getpid()); + fprintf(pidfile, "%d\n", getpid()); return fflush(pidfile); } return 0; @@ -268,14 +248,12 @@ int pidfile_refresh(void) static void pidfile_close(void) { - struct flock lock; - p_clear(&lock, 1); - lock.l_type = F_UNLCK; if (pidfile) { - rewind(pidfile); - ftruncate(fileno(pidfile), 0); - fcntl(fileno(pidfile), F_SETLK, &lock); - fclose(pidfile); + if (daemon_process) { + rewind(pidfile); + ftruncate(fileno(pidfile), 0); + } + fclose(pidfile); pidfile = NULL; } } @@ -283,6 +261,11 @@ static void pidfile_close(void) int common_setup(const char* pidfilename, bool unsafe, const char* runas_user, const char* runas_group, bool daemonize) { + if (pidfile_open(pidfilename) < 0) { + crit("unable to write pidfile %s", pidfilename); + return EXIT_FAILURE; + } + if (!unsafe && drop_privileges(runas_user, runas_group) < 0) { crit("unable to drop privileges"); return EXIT_FAILURE; @@ -293,11 +276,6 @@ int common_setup(const char* pidfilename, bool unsafe, const char* runas_user, return EXIT_FAILURE; } - if (pidfile_open(pidfilename) < 0) { - crit("unable to write pidfile %s", pidfilename); - return EXIT_FAILURE; - } - pidfile_refresh(); return EXIT_SUCCESS; } @@ -307,10 +285,10 @@ extern exitcall_t __madexit[]; static void common_shutdown(void) { - if (daemon_process) { - info("stopping..."); - } - pidfile_close(); + if (daemon_process && log_syslog) { + info("stopping..."); + } + pidfile_close(); for (int i = -1; __madexit[i]; i--) { (*__madexit[i])(); }