Pierre Habouzit [Thu, 14 Dec 2006 00:07:09 +0000 (01:07 +0100)]
oops debug code.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 14 Dec 2006 00:05:54 +0000 (01:05 +0100)]
implement $-vars substitution.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Wed, 13 Dec 2006 19:05:25 +0000 (20:05 +0100)]
fixes bad semantics (an invalid fd is -1 not 0).
fix uninitialized variables.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Wed, 13 Dec 2006 17:36:01 +0000 (18:36 +0100)]
Use m_tempfile instead of mktemp in attach/recvattach
This means we open temporary file before calling mutt_pipe_attach()
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Wed, 13 Dec 2006 17:01:45 +0000 (18:01 +0100)]
Use m_temp instead of mutt_mktemp in compress code
This patch remove the static set_path() function which was used only twice.
in:
- mutt_open_read_compressed()
We just create a temporary file and open it, so this is more secure
against symlink attacks and then just call decompression cmd normaly
- mutt_open_append_compressed()
Instead of creating the file if (cond), unlink() it if (!cond).
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Wed, 13 Dec 2006 13:41:49 +0000 (14:41 +0100)]
some fixes, make mutt_decode_save_attachment coherent (always closes the
fd).
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Wed, 13 Dec 2006 11:42:11 +0000 (12:42 +0100)]
Use file descriptor instead of path for mutt_decode_save_attachment()
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Mon, 11 Dec 2006 09:05:31 +0000 (10:05 +0100)]
Merge branch 'master' of pan:/git/madmutt
Pierre Habouzit [Mon, 11 Dec 2006 09:05:23 +0000 (10:05 +0100)]
rc parser progress over the week-end.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Mon, 11 Dec 2006 09:04:14 +0000 (10:04 +0100)]
fix makefile.am dependencies... got I hate automake.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 10 Dec 2006 22:17:23 +0000 (23:17 +0100)]
various fixes.
add *_list_rev function.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 9 Dec 2006 13:38:22 +0000 (14:38 +0100)]
very temporary work on the new generation of config parser.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 9 Dec 2006 13:34:19 +0000 (14:34 +0100)]
import lemon in the source tree.
Pierre Habouzit [Sat, 9 Dec 2006 00:48:25 +0000 (01:48 +0100)]
preliminary work for the configuration parser.
Pierre Habouzit [Wed, 6 Dec 2006 09:14:35 +0000 (10:14 +0100)]
do not make semicolons special in the config file anymore.
update documentation wrt that.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Mon, 4 Dec 2006 08:34:17 +0000 (09:34 +0100)]
small regressions.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Mon, 4 Dec 2006 00:18:21 +0000 (01:18 +0100)]
more strings simplifications.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Mon, 4 Dec 2006 00:03:58 +0000 (01:03 +0100)]
impressive how mutt upstream don't get how list work.
simplify lots of code, more to come.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 3 Dec 2006 23:33:49 +0000 (00:33 +0100)]
drop some useless crap.
ifdef/ifndef is good but in fact used for wrong reasons. We should always
accept all the settings mutt-ng knows about, even if the features are not
here. full stop.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 3 Dec 2006 23:18:13 +0000 (00:18 +0100)]
yes, we always have colors, screw stupid antiquated ncurses.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 3 Dec 2006 22:45:26 +0000 (23:45 +0100)]
cosmetics
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 3 Dec 2006 21:00:24 +0000 (22:00 +0100)]
oopsie, sometimes grep hurts :P
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 3 Dec 2006 20:56:23 +0000 (21:56 +0100)]
code simplifications.
fix IMAP regression.
use a lot more mime_which_token
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 3 Dec 2006 19:29:09 +0000 (20:29 +0100)]
oops, d can be NULL !
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 3 Dec 2006 15:41:30 +0000 (16:41 +0100)]
oops, I did it again: simplify a lot of code :]
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sun, 3 Dec 2006 14:47:56 +0000 (15:47 +0100)]
Use p_new instead of xmalloc()
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 3 Dec 2006 15:12:53 +0000 (16:12 +0100)]
small rewrite.
fix the 'extra space' bug in headers :]
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 3 Dec 2006 14:52:26 +0000 (15:52 +0100)]
small reorg.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 3 Dec 2006 14:32:47 +0000 (15:32 +0100)]
oops :)
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 3 Dec 2006 14:28:10 +0000 (15:28 +0100)]
move some string functions in lib-lib !
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 3 Dec 2006 12:59:52 +0000 (13:59 +0100)]
rework m_strformat so that it takes the cols number to use in case of
right pad, rather than computing it. that makes the function suitable for
lib-lib inclusion real soon :]
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 3 Dec 2006 12:13:18 +0000 (13:13 +0100)]
let m_strformat accept NULL formats.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 2 Dec 2006 23:32:28 +0000 (00:32 +0100)]
optimizations, remove horrors.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 2 Dec 2006 22:54:35 +0000 (23:54 +0100)]
the ‘kids don't do this at home’ commit.
replace the unsigned long mutt API used to cast anything into ints pointer
and so on. Add 'anytype' that is a kind of dirty union that, thanks to gcc
__attribute__((transparent_union)) allows silent cast from any type into
that type.
eeeeeeek !
but that makes the code way easier to read !
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 2 Dec 2006 22:02:41 +0000 (23:02 +0100)]
fixes in the sidebar format, was completely braindead.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 2 Dec 2006 20:18:33 +0000 (21:18 +0100)]
let the caller deal with M_FORMAT_ARROWCURSOR, not the callee.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 2 Dec 2006 20:04:02 +0000 (21:04 +0100)]
mutt_FormatString -> m_strformat (will soon end up into the str lib \o/)
some tiny reworks, stylish issues.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 2 Dec 2006 19:55:57 +0000 (20:55 +0100)]
fully rework mutt_FormatString, fix a lot of issues, no more stack
squashing.
fix bugs with pads.
this is PASS1. soon, the number of columns to prepare the string for will
be computed by the caller rather than the callee.
enable nonliteral formats warning again, those are also meant to
disappear.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 2 Dec 2006 19:53:47 +0000 (20:53 +0100)]
add m_strpad to the string functions.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 2 Dec 2006 13:34:23 +0000 (14:34 +0100)]
oops, ascii_strncasecmp tried to compare one byte too far
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 1 Dec 2006 22:54:28 +0000 (23:54 +0100)]
more nonnull attributes.
simplify skipspaces as !isspace('\0') holds
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 1 Dec 2006 22:40:30 +0000 (23:40 +0100)]
string documentation.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 1 Dec 2006 15:25:49 +0000 (16:25 +0100)]
oops, small regresion
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Fri, 1 Dec 2006 15:16:53 +0000 (16:16 +0100)]
Fix compilation warnings
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Fri, 1 Dec 2006 15:16:51 +0000 (16:16 +0100)]
Fix compilation error
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 1 Dec 2006 15:00:32 +0000 (16:00 +0100)]
fix the real bug, that was hidden in the .h
I like when I understand what was wrong :)
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 1 Dec 2006 10:41:59 +0000 (11:41 +0100)]
workarounds, I do not understand why it segfault, it should *NOT*
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 1 Dec 2006 09:54:12 +0000 (10:54 +0100)]
should fix compilation.
Pierre Habouzit [Fri, 1 Dec 2006 00:41:02 +0000 (01:41 +0100)]
more documentation.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 23:23:15 +0000 (00:23 +0100)]
no more SHORT_STRING's. begin some doc.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 23:17:09 +0000 (00:17 +0100)]
update docs things.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 22:31:35 +0000 (23:31 +0100)]
prepare documentation of the APIs
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 22:04:23 +0000 (23:04 +0100)]
more cosmetics.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 21:45:11 +0000 (22:45 +0100)]
cosmetics
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 21:35:57 +0000 (22:35 +0100)]
cosmetics
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 21:25:35 +0000 (22:25 +0100)]
cosmetics
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 21:22:54 +0000 (22:22 +0100)]
cosmetics++
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 21:18:33 +0000 (22:18 +0100)]
cosmetics
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 08:03:39 +0000 (09:03 +0100)]
some simplifications.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 00:24:35 +0000 (01:24 +0100)]
simplifications
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Wed, 29 Nov 2006 23:44:50 +0000 (00:44 +0100)]
small detail in m_dirname.
use m_dirname in recvattach.c rather than some cumbersome code.
also fix the 'last used folder' semantics
Pierre Habouzit [Wed, 29 Nov 2006 23:27:54 +0000 (00:27 +0100)]
add m_dirname that implement a non broken libgen-like function.
Pierre Habouzit [Wed, 29 Nov 2006 21:21:16 +0000 (22:21 +0100)]
simplifications around mutt_is_message_type
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Wed, 29 Nov 2006 01:16:30 +0000 (02:16 +0100)]
post ? -post : 0
that was a good one
Pierre Habouzit [Wed, 29 Nov 2006 01:10:17 +0000 (02:10 +0100)]
various code simplifications.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Tue, 28 Nov 2006 23:55:06 +0000 (00:55 +0100)]
make some code yet more simple, using the VERY good semantics of snprintf
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Tue, 28 Nov 2006 22:36:01 +0000 (23:36 +0100)]
remove reallocs, free and fix makedoc compilation
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Tue, 28 Nov 2006 22:28:05 +0000 (23:28 +0100)]
that was in fact a memcpy, nice try
Julien Danjou [Tue, 28 Nov 2006 17:59:29 +0000 (18:59 +0100)]
Use good m_ functions, because it smell like a flower, version 2.
This is a whole bunch of update for using more m_* functions.
Some calculation should be checked, maybe I made some mistakes.
Not good at math.
There is also some _CHECKED__ comments removed because I got
my head checked by a jumbot jet.
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Tue, 28 Nov 2006 18:47:29 +0000 (19:47 +0100)]
"gpg-sign" is not a valid token, this was a typo.
also drop some very old mutt things, just use x-action, the rest will be
re-parsed, too bad.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Mon, 27 Nov 2006 09:49:09 +0000 (10:49 +0100)]
force rfc2047_parameters to be set to yes, and non configureable.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sun, 26 Nov 2006 23:23:52 +0000 (00:23 +0100)]
Use m_functions(), you'll be fresh-faced.
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 23:27:43 +0000 (00:27 +0100)]
remove a mutt-ng thing that makes no sense at all.
rework OPTWEED handling a bit.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 23:02:35 +0000 (00:02 +0100)]
lots of simplifications.
add pattern.h
always set strict_mime off, we want to do a MUA that understands other,
right ? just keep the parse of that option for now, to avoid barfing
hopelessly on old mutt's config files
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 22:16:24 +0000 (23:16 +0100)]
more automake stuff
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 22:13:15 +0000 (23:13 +0100)]
more tweaks and fixes.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 22:03:59 +0000 (23:03 +0100)]
build system tweaks.
update-po.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 21:58:49 +0000 (22:58 +0100)]
always build support for mixmaster.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 21:10:38 +0000 (22:10 +0100)]
some code simplifications.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sun, 26 Nov 2006 19:26:57 +0000 (20:26 +0100)]
Remove unused code
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sun, 26 Nov 2006 19:46:23 +0000 (20:46 +0100)]
Use m_strncmp instead of strncmp
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sun, 26 Nov 2006 17:52:15 +0000 (18:52 +0100)]
m_strisempty is better, isn't it ?
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 17:40:06 +0000 (18:40 +0100)]
simplify mutt_write_references.
wibble
Pierre Habouzit [Sun, 26 Nov 2006 17:09:23 +0000 (18:09 +0100)]
make mutt_match_spam_list a generic rx function: rx_list_match2 that does
the same as rx_list_match + expand a template into the given buffer.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 16:38:21 +0000 (17:38 +0100)]
move more functions in file.c
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 16:31:33 +0000 (17:31 +0100)]
mutt_expand_file_fmt -> m_quotefile_fmt in file.c
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 16:19:39 +0000 (17:19 +0100)]
wibble.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:19:03 +0000 (18:19 +0100)]
Use better error msgs for tempfile
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:19:02 +0000 (18:19 +0100)]
Better error msg in gpgme
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:19:01 +0000 (18:19 +0100)]
Use bette error msg too
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:19:00 +0000 (18:19 +0100)]
Replace mutt_perror with good error msgs
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:57 +0000 (18:10 +0100)]
Tag unused attributes
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:56 +0000 (18:10 +0100)]
Kill shadow declaratin of brk
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:55 +0000 (18:10 +0100)]
Tag unused and kill mktemp
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:54 +0000 (18:10 +0100)]
Fix shadow declaration and tag unused attribute
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:53 +0000 (18:10 +0100)]
Mark unused attributes
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:52 +0000 (18:10 +0100)]
Mark flags as unused
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:51 +0000 (18:10 +0100)]
Kill another mktemp
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:50 +0000 (18:10 +0100)]
mutt_*mktemp--
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:49 +0000 (18:10 +0100)]
Use m_tempfile and better errors msg
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>