From 4b257b64105713fc439d8a00db97a117319e8009 Mon Sep 17 00:00:00 2001
From: ak1 <ak1@e385b8ad-14ed-0310-8656-cc95a2468c6d>
Date: Tue, 1 Mar 2005 22:03:22 +0000
Subject: [PATCH] Andreas Krennmair: 	fixed bug #3490.

git-svn-id: svn://svn.berlios.de/mutt-ng/trunk@128 e385b8ad-14ed-0310-8656-cc95a2468c6d
---
 ChangeLog.mutt-ng |  1 +
 sidebar.c         | 34 ++++++++++++++++++++++++----------
 2 files changed, 25 insertions(+), 10 deletions(-)

diff --git a/ChangeLog.mutt-ng b/ChangeLog.mutt-ng
index 2908a31..c4d4cff 100644
--- a/ChangeLog.mutt-ng
+++ b/ChangeLog.mutt-ng
@@ -4,6 +4,7 @@ Changes specific to mutt-ng:
   * made internal buffy list sorted (-> sorted in sidebar, too)
   * somewhat bigger documentation update; introduce UPGRADING document
   * fixed escape sequence problem in manual.txt
+  * fixed bug #3490
 
 2005-02-27:
   * integrated patch to highlight the next mailbox which includes new mail in sidebar
diff --git a/sidebar.c b/sidebar.c
index e136de6..e914533 100644
--- a/sidebar.c
+++ b/sidebar.c
@@ -120,12 +120,16 @@ static char * shortened_hierarchy(char * box) {
 
 char *make_sidebar_entry(char *box, int size, int new, int flagged)
 {
-  char *c;
-  int i = 0, dlen = mutt_strlen (SidebarDelim), max = SidebarWidth-dlen-1,
-      shortened = 0;
+  int i = 0, dlen, max, shortened = 0;
+  int offset;
 
-  c = realloc(entry, SidebarWidth + 1);
-  if ( c ) entry = c;
+  if (SidebarWidth > COLS)
+    SidebarWidth = COLS;
+
+  dlen = mutt_strlen(SidebarDelim);
+  max = SidebarWidth - dlen - 1;
+
+  safe_realloc(&entry, SidebarWidth + 1);
   entry[SidebarWidth] = 0;
   for (; i < SidebarWidth; entry[i++] = ' ' );
 #if USE_IMAP
@@ -149,20 +153,30 @@ char *make_sidebar_entry(char *box, int size, int new, int flagged)
 
   if ( new ) {
     if (flagged>0) {
-      sprintf(entry + SidebarWidth - 5 - quick_log10(size) - dlen - quick_log10(new) - quick_log10(flagged),
+      offset = SidebarWidth - 5 - quick_log10(size) - dlen - quick_log10(new) - quick_log10(flagged);
+      if (offset<0) offset = 0;
+      snprintf(entry + offset, SidebarWidth - dlen - offset + 1,
               "% d(%d)[%d]", size, new, flagged);
     } else {
-      sprintf(entry + SidebarWidth - 3 - quick_log10(size) - dlen - quick_log10(new),
+      offset = SidebarWidth - 3 - quick_log10(size) - dlen - quick_log10(new);
+      if (offset<0) offset = 0;
+      snprintf(entry + offset, SidebarWidth - dlen - offset + 1,
               "% d(%d)", size, new);
     }
   } else {
     if (flagged>0) {
-      sprintf( entry + SidebarWidth - 3 - quick_log10(size) - dlen - quick_log10(flagged), "% d[%d]", size,flagged);
+      offset = SidebarWidth - 3 - quick_log10(size) - dlen - quick_log10(flagged);
+      if (offset<0) offset = 0;
+      snprintf( entry + offset, SidebarWidth - dlen - offset + 1,
+              "% d[%d]", size,flagged);
     } else {
-      sprintf( entry + SidebarWidth - 1 - quick_log10(size) - dlen, "% d", size);
+      offset = SidebarWidth - 1 - quick_log10(size) - dlen;
+      if (offset<0) offset = 0;
+      snprintf( entry + offset, SidebarWidth - dlen - offset + 1,
+              "% d", size);
     }
-
   }
+
   if (option(OPTSHORTENHIERARCHY) && shortened) {
     free(box);
   }
-- 
2.20.1