continue the include dance

[apps/madmutt.git] / browser.c

diff --git a/browser.c b/browser.c
index d91d0ef..12c41a9 100644 (file)
--- a/browser.c
+++ b/browser.c
@@ -11,26 +11,35 @@
 # include "config.h"
 #endif
 
+#include <stdlib.h>
+#include <dirent.h>
+#include <string.h>
+#include <ctype.h>
+#include <unistd.h>
+#include <sys/stat.h>
+#include <errno.h>
+#include <pwd.h>
+#include <grp.h>
+
 #include <lib-lib/mem.h>
 #include <lib-lib/str.h>
 #include <lib-lib/macros.h>
 #include <lib-lib/file.h>
 #include <lib-lib/mapping.h>
 
+#include <lib-ui/curses.h>
+#include <lib-ui/enter.h>
+#include <lib-ui/menu.h>
+
 #include "mutt.h"
-#include "enter.h"
 #include "mx.h"
-#include "mutt_curses.h"
-#include "mutt_menu.h"
 #include "buffy.h"
 #include "sort.h"
 #include "browser.h"
 #include "attach.h"
 
-#ifdef USE_IMAP
-#include "imap.h"
-#include "imap/mx_imap.h"
-#endif
+#include <imap/imap.h>
+#include <imap/mx_imap.h>
 #ifdef USE_NNTP
 #include "nntp.h"
 #endif
@@ -38,14 +47,6 @@
 
 #include "lib/list.h"
 
-#include <stdlib.h>
-#include <dirent.h>
-#include <string.h>
-#include <ctype.h>
-#include <unistd.h>
-#include <sys/stat.h>
-#include <errno.h>
-
 static struct mapping_t FolderHelp[] = {
   {N_("Exit"), OP_EXIT},
   {N_("Chdir"), OP_CHANGE_DIRECTORY},
@@ -85,9 +86,7 @@ static void destroy_state (struct browser_state *state)
     p_delete(&((state->entry)[c].desc));
     p_delete(&((state->entry)[c].st));
   }
-#ifdef USE_IMAP
   p_delete(&state->folder);
-#endif
   p_delete(&state->entry);
 }
 
@@ -163,7 +162,7 @@ static int link_is_dir (const char *folder, const char *path)
     return 0;
 }
 
-static const char *folder_format_str (char *dest, size_t destlen, char op,
+static const char *folder_format_str (char *dest, ssize_t destlen, char op,
                                       const char *src, const char *fmt,
                                       const char *ifstring,
                                       const char *elsestring,
@@ -201,11 +200,9 @@ static const char *folder_format_str (char *dest, size_t destlen, char op,
     {
       const char *s;
 
-#ifdef USE_IMAP
       if (folder->ff->imap)
         s = NONULL (folder->ff->desc);
       else
-#endif
         s = NONULL (folder->ff->name);
 
       snprintf (fn, sizeof (fn), "%s%s", s,
@@ -240,7 +237,6 @@ static const char *folder_format_str (char *dest, size_t destlen, char op,
                 0 ? 'x' : '-');
       mutt_format_s (dest, destlen, fmt, permission);
     }
-#ifdef USE_IMAP
     else if (folder->ff->imap) {
       /* mark folders with subfolders AND mail */
       snprintf (permission, sizeof (permission), "IMAP %c",
@@ -248,7 +244,6 @@ static const char *folder_format_str (char *dest, size_t destlen, char op,
                  && folder->ff->selectable) ? '+' : ' ');
       mutt_format_s (dest, destlen, fmt, permission);
     }
-#endif
     else
       mutt_format_s (dest, destlen, fmt, "");
     break;
@@ -276,7 +271,6 @@ static const char *folder_format_str (char *dest, size_t destlen, char op,
     break;
 
   case 'N':
-#ifdef USE_IMAP
     if (imap_is_magic (folder->ff->desc, NULL) == M_IMAP) {
       if (!optional) {
         snprintf (tmp, sizeof (tmp), "%%%sd", fmt);
@@ -286,7 +280,6 @@ static const char *folder_format_str (char *dest, size_t destlen, char op,
         optional = 0;
       break;
     }
-#endif
     snprintf (tmp, sizeof (tmp), "%%%sc", fmt);
     snprintf (dest, destlen, tmp, folder->ff->new ? 'N' : ' ');
     break;
@@ -333,7 +326,7 @@ static const char *folder_format_str (char *dest, size_t destlen, char op,
 }
 
 #ifdef USE_NNTP
-static const char *newsgroup_format_str (char *dest, size_t destlen, char op,
+static const char *newsgroup_format_str (char *dest, ssize_t destlen, char op,
                                          const char *src, const char *fmt,
                                          const char *ifstring,
                                          const char *elsestring,
@@ -423,9 +416,15 @@ static const char *newsgroup_format_str (char *dest, size_t destlen, char op,
 }
 #endif /* USE_NNTP */
 
+#ifdef USE_NNTP
 static void add_folder (MUTTMENU * m, struct browser_state *state,
                         const char *name, const struct stat *s,
                         void *data, int new)
+#else
+static void add_folder (MUTTMENU * m, struct browser_state *state,
+                        const char *name, const struct stat *s,
+                        int new)
+#endif
 {
   if (state->entrylen == state->entrymax) {
     /* need to allocate more space */
@@ -445,9 +444,7 @@ static void add_folder (MUTTMENU * m, struct browser_state *state,
   (state->entry)[state->entrylen].new = new;
   (state->entry)[state->entrylen].name = m_strdup(name);
   (state->entry)[state->entrylen].desc = m_strdup(name);
-#ifdef USE_IMAP
   (state->entry)[state->entrylen].imap = 0;
-#endif
 #ifdef USE_NNTP
   if (option (OPTNEWS))
     (state->entry)[state->entrylen].nd = (NNTP_DATA *) data;
@@ -460,9 +457,7 @@ static void init_state (struct browser_state *state, MUTTMENU * menu)
   state->entrylen = 0;
   state->entrymax = 256;
   state->entry = p_new(struct folder_file, state->entrymax);
-#ifdef USE_IMAP
   state->imap_browse = 0;
-#endif
   if (menu)
     menu->data = state->entry;
 }
@@ -473,7 +468,7 @@ static int examine_directory (MUTTMENU * menu, struct browser_state *state,
 {
 #ifdef USE_NNTP
   if (option (OPTNEWS)) {
-    LIST *tmp;
+    string_list_t *tmp;
     NNTP_DATA *data;
     NNTP_SERVER *news = CurrentNewsSrv;
 
@@ -489,7 +484,11 @@ static int examine_directory (MUTTMENU * menu, struct browser_state *state,
         continue;
       if (!((regexec (Mask.rx, data->group, 0, NULL, 0) == 0) ^ Mask.not))
         continue;
+#ifdef USE_NNTP
       add_folder (menu, state, data->group, NULL, data, data->new);
+#else
+      add_folder (menu, state, data->group, NULL, data->new);
+#endif
     }
     sidebar_draw (CurrentMenu);
   }
@@ -549,7 +548,11 @@ static int examine_directory (MUTTMENU * menu, struct browser_state *state,
         continue;
 
       i = buffy_lookup (buffer);
+#ifdef USE_NNTP
       add_folder (menu, state, de->d_name, &s, NULL, i >= 0 ? ((BUFFY*) Incoming->data[i])->new : 0);
+#else
+      add_folder (menu, state, de->d_name, &s, i >= 0 ? ((BUFFY*) Incoming->data[i])->new : 0);
+#endif
     }
     closedir (dp);
   }
@@ -566,7 +569,7 @@ static int examine_mailboxes (MUTTMENU * menu, struct browser_state *state)
 
 #ifdef USE_NNTP
   if (option (OPTNEWS)) {
-    LIST *tmp;
+    string_list_t *tmp;
     NNTP_DATA *data;
     NNTP_SERVER *news = CurrentNewsSrv;
 
@@ -586,7 +589,7 @@ static int examine_mailboxes (MUTTMENU * menu, struct browser_state *state)
   else
 #endif
   {
-    int i = 0;
+    unsigned int i = 0;
     BUFFY* tmp;
 
     if (!Incoming)
@@ -598,18 +601,22 @@ static int examine_mailboxes (MUTTMENU * menu, struct browser_state *state)
     for (i = 0; i < Incoming->length; i++) {
       tmp = (BUFFY*) Incoming->data[i];
       tmp->magic = mx_get_magic (tmp->path);
-#ifdef USE_IMAP
       if (tmp->magic == M_IMAP) {
+#ifdef USE_NNTP
         add_folder (menu, state, tmp->path, NULL, NULL, tmp->new);
+#else
+        add_folder (menu, state, tmp->path, NULL, tmp->new);
+#endif
         continue;
       }
-#endif
-#ifdef USE_POP
       if (tmp->magic == M_POP) {
+#ifdef USE_NNTP
         add_folder (menu, state, tmp->path, NULL, NULL, tmp->new);
+#else
+        add_folder (menu, state, tmp->path, NULL, tmp->new);
+#endif
         continue;
       }
-#endif
 #ifdef USE_NNTP
       if (tmp->magic == M_NNTP) {
         add_folder (menu, state, tmp->path, NULL, NULL, tmp->new);
@@ -626,7 +633,11 @@ static int examine_mailboxes (MUTTMENU * menu, struct browser_state *state)
       m_strcpy(buffer, sizeof(buffer), NONULL(tmp->path));
       mutt_pretty_mailbox (buffer);
 
+#ifdef USE_NNTP
       add_folder (menu, state, buffer, &s, NULL, tmp->new);
+#else
+      add_folder (menu, state, buffer, &s, tmp->new);
+#endif
     }
   }
   browser_sort (state);
@@ -644,7 +655,7 @@ static int select_file_search (MUTTMENU * menu, regex_t * re, int n)
           (re, ((struct folder_file *) menu->data)[n].name, 0, NULL, 0));
 }
 
-static void folder_entry (char *s, size_t slen, MUTTMENU * menu, int num)
+static void folder_entry (char *s, ssize_t slen, MUTTMENU * menu, int num)
 {
   FOLDER folder;
 
@@ -662,7 +673,7 @@ static void folder_entry (char *s, size_t slen, MUTTMENU * menu, int num)
 }
 
 static void init_menu (struct browser_state *state, MUTTMENU * menu,
-                       char *title, size_t titlelen, int buffy)
+                       char *title, ssize_t titlelen, int buffy)
 {
   char path[_POSIX_PATH_MAX];
 
@@ -692,12 +703,10 @@ static void init_menu (struct browser_state *state, MUTTMENU * menu,
   else {
     m_strcpy(path, sizeof(path), LastDir);
     mutt_pretty_mailbox (path);
-#ifdef USE_IMAP
     if (state->imap_browse && option (OPTIMAPLSUB))
       snprintf (title, titlelen, _("Subscribed [%s], File mask: %s"),
                 path, NONULL (Mask.pattern));
     else
-#endif
       snprintf (title, titlelen, _("Directory [%s], File mask: %s"),
                 path, NONULL (Mask.pattern));
   }
@@ -722,7 +731,7 @@ static int file_tag (MUTTMENU * menu, int n, int m)
   return ff->tagged - ot;
 }
 
-void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
+void _mutt_select_file (char *f, ssize_t flen, int flags, char ***files,
                         int *numfiles)
 {
   char buf[_POSIX_PATH_MAX];
@@ -749,7 +758,7 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
     if (*f)
       m_strcpy(prefix, sizeof(prefix), f);
     else {
-      LIST *list;
+      string_list_t *list;
 
       /* default state for news reader mode is browse subscribed newsgroups */
       buffy = 0;
@@ -767,7 +776,6 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
 #endif
   if (*f) {
     mutt_expand_path (f, flen);
-#ifdef USE_IMAP
     if (imap_is_magic (f, NULL) == M_IMAP) {
       init_state (&state, NULL);
       state.imap_browse = 1;
@@ -775,11 +783,10 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
         m_strcpy(LastDir, sizeof(LastDir), state.folder);
     }
     else {
-#endif
       for (i = m_strlen(f) - 1; i > 0 && f[i] != '/'; i--);
       if (i > 0) {
         if (f[0] == '/') {
-          i = MIN(sizeof(LastDir) - 1, i);
+          i = MIN(ssizeof(LastDir) - 1, i);
           m_strcpy(LastDir, sizeof(LastDir), f);
         }
         else {
@@ -800,9 +807,7 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
       else
         m_strcpy(prefix, sizeof(prefix), f + i + 1);
       killPrefix = 1;
-#ifdef USE_IMAP
     }
-#endif
   }
   else {
     if (!folder)
@@ -810,14 +815,12 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
     else if (!LastDir[0])
       m_strcpy(LastDir, sizeof(LastDir), NONULL(Maildir));
 
-#ifdef USE_IMAP
     if (!buffy && imap_is_magic (LastDir, NULL) == M_IMAP) {
       init_state (&state, NULL);
       state.imap_browse = 1;
       imap_browse (LastDir, &state);
       browser_sort (&state);
     }
-#endif
   }
 
   *f = 0;
@@ -827,9 +830,7 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
       goto bail;
   }
   else
-#ifdef USE_IMAP
   if (!state.imap_browse)
-#endif
     if (examine_directory (NULL, &state, LastDir, prefix) == -1)
       goto bail;
 
@@ -863,29 +864,23 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
       if (S_ISDIR (state.entry[menu->current].mode) ||
           (S_ISLNK (state.entry[menu->current].mode) &&
            link_is_dir (LastDir, state.entry[menu->current].name))
-#ifdef USE_IMAP
           || state.entry[menu->current].inferiors
-#endif
         ) {
         /* make sure this isn't a MH or maildir mailbox */
         if (buffy) {
           m_strcpy(buf, sizeof(buf), state.entry[menu->current].name);
           mutt_expand_path (buf, sizeof (buf));
         }
-#ifdef USE_IMAP
         else if (state.imap_browse) {
           m_strcpy(buf, sizeof(buf), state.entry[menu->current].name);
         }
-#endif
         else
           mutt_concat_path(buf, sizeof(buf), LastDir,
                            state.entry[menu->current].name);
 
         if ((mx_get_magic (buf) <= 0)
-#ifdef USE_IMAP
-            || state.entry[menu->current].inferiors
-#endif
-          ) {
+            || state.entry[menu->current].inferiors)
+        {
           char OldLastDir[_POSIX_PATH_MAX];
 
           /* save the old directory */
@@ -912,7 +907,6 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
                      state.entry[menu->current].name);
             mutt_expand_path (LastDir, sizeof (LastDir));
           }
-#ifdef USE_IMAP
           else if (state.imap_browse) {
             int n;
             ciss_url_t url;
@@ -926,12 +920,11 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
             url_parse_ciss (&url, state.entry[menu->current].name);
             if (url.path &&
                 (state.entry[menu->current].delim != '\0') &&
-                (n < sizeof (LastDir))) {
+                (n < ssizeof (LastDir))) {
               LastDir[n] = '\0';
               LastDir[n - 1] = state.entry[menu->current].delim;
             }
           }
-#endif
           else {
             char tmp[_POSIX_PATH_MAX];
 
@@ -946,7 +939,6 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
             killPrefix = 0;
           }
           buffy = 0;
-#ifdef USE_IMAP
           if (state.imap_browse) {
             init_state (&state, NULL);
             state.imap_browse = 1;
@@ -955,7 +947,6 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
             menu->data = state.entry;
           }
           else
-#endif
           if (examine_directory (menu, &state, LastDir, prefix) == -1) {
             /* try to restore the old values */
             m_strcpy(LastDir, sizeof(LastDir), OldLastDir);
@@ -980,10 +971,8 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
         m_strcpy(f, flen, state.entry[menu->current].name);
         mutt_expand_path (f, flen);
       }
-#ifdef USE_IMAP
       else if (state.imap_browse)
         m_strcpy(f, flen, state.entry[menu->current].name);
-#endif
       else
         mutt_concat_path(f, flen, LastDir, state.entry[menu->current].name);
 
@@ -993,12 +982,13 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
 
       if (multiple) {
         char **tfiles;
-        int i, j;
+        int j;
+        int h;
 
         if (menu->tagged) {
           *numfiles = menu->tagged;
           tfiles = p_new(char *, *numfiles);
-          for (i = 0, j = 0; i < state.entrylen; i++) {
+          for (h = 0, j = 0; h < state.entrylen; i++) {
             struct folder_file ff = state.entry[i];
             char full[_POSIX_PATH_MAX];
 
@@ -1028,7 +1018,6 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
         mutt_message ("%s", state.entry[menu->current].name);
       break;
 
-#ifdef USE_IMAP
     case OP_BROWSER_TOGGLE_LSUB:
       if (option (OPTIMAPLSUB)) {
         unset_option (OPTIMAPLSUB);
@@ -1113,7 +1102,6 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
         p_delete(&mx.mbox);
       }
       break;
-#endif
 
     case OP_CHANGE_DIRECTORY:
 
@@ -1123,14 +1111,12 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
 #endif
 
       m_strcpy(buf, sizeof(buf), LastDir);
-#ifdef USE_IMAP
       if (!state.imap_browse)
-#endif
       {
         /* add '/' at the end of the directory name if not already there */
-        int len = m_strlen(LastDir);
+        ssize_t len = m_strlen(LastDir);
 
-        if (len && LastDir[len - 1] != '/' && sizeof (buf) > len)
+        if (len && LastDir[len - 1] != '/' && ssizeof(buf) > len)
           buf[len] = '/';
       }
 
@@ -1138,7 +1124,6 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
           buf[0]) {
         buffy = 0;
         mutt_expand_path (buf, sizeof (buf));
-#ifdef USE_IMAP
         if (imap_is_magic (buf, NULL) == M_IMAP) {
           m_strcpy(LastDir, sizeof(LastDir), buf);
           destroy_state (&state);
@@ -1152,7 +1137,6 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
           init_menu (&state, menu, title, sizeof (title), buffy);
         }
         else
-#endif
         if (stat (buf, &st) == 0) {
           if (S_ISDIR (st.st_mode)) {
             destroy_state (&state);
@@ -1211,7 +1195,6 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
           Mask.not = not;
 
           destroy_state (&state);
-#ifdef USE_IMAP
           if (state.imap_browse) {
             init_state (&state, NULL);
             state.imap_browse = 1;
@@ -1221,7 +1204,6 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
             init_menu (&state, menu, title, sizeof (title), buffy);
           }
           else
-#endif
           if (examine_directory (menu, &state, LastDir, NULL) == 0)
             init_menu (&state, menu, title, sizeof (title), buffy);
           else {
@@ -1296,7 +1278,6 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
         if (examine_mailboxes (menu, &state) == -1)
           goto bail;
       }
-#ifdef USE_IMAP
       else if (imap_is_magic (LastDir, NULL) == M_IMAP) {
         init_state (&state, NULL);
         state.imap_browse = 1;
@@ -1304,7 +1285,6 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
         browser_sort (&state);
         menu->data = state.entry;
       }
-#endif
       else if (examine_directory (menu, &state, LastDir, prefix) == -1)
         goto bail;
       init_menu (&state, menu, title, sizeof (title), buffy);
@@ -1336,7 +1316,6 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
         break;
       }
 
-#ifdef USE_IMAP
       if (state.entry[menu->current].selectable) {
         m_strcpy(f, flen, state.entry[menu->current].name);
         destroy_state (&state);
@@ -1344,7 +1323,6 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
         goto bail;
       }
       else
-#endif
       if (S_ISDIR (state.entry[menu->current].mode) ||
             (S_ISLNK (state.entry[menu->current].mode) &&
                link_is_dir (LastDir, state.entry[menu->current].name))) {
@@ -1354,11 +1332,11 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
       }
       else {
         BODY *b;
-        char buf[_POSIX_PATH_MAX];
+        char nbuf[_POSIX_PATH_MAX];
 
-        mutt_concat_path(buf, sizeof(buf), LastDir,
+        mutt_concat_path(nbuf, sizeof(nbuf), LastDir,
                          state.entry[menu->current].name);
-        b = mutt_make_file_attach (buf);
+        b = mutt_make_file_attach (nbuf);
         if (b != NULL) {
           mutt_view_attachment (NULL, b, M_REGULAR, NULL, NULL, 0);
           mutt_free_body (&b);
@@ -1408,7 +1386,7 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
         break;
 
       {
-        LIST *tmp;
+        string_list_t *tmp;
         NNTP_DATA *data;
 
         for (tmp = CurrentNewsSrv->list; tmp; tmp = tmp->next) {
@@ -1427,10 +1405,8 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
       break;
 #endif /* USE_NNTP */
 
-#if defined USE_IMAP || defined USE_NNTP
     case OP_BROWSER_SUBSCRIBE:
     case OP_BROWSER_UNSUBSCRIBE:
-#endif
 #ifdef USE_NNTP
     case OP_SUBSCRIBE_PATTERN:
     case OP_UNSUBSCRIBE_PATTERN:
@@ -1504,7 +1480,7 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
           }
         }
         if (i == OP_SUBSCRIBE_PATTERN) {
-          LIST *grouplist = NULL;
+          string_list_t *grouplist = NULL;
 
           if (news)
             grouplist = news->list;
@@ -1525,18 +1501,14 @@ void _mutt_select_file (char *f, size_t flen, int flags, char ***files,
           regfree (rx);
         p_delete(&rx);
       }
-#ifdef USE_IMAP
       else
-#endif /* USE_IMAP && USE_NNTP */
 #endif /* USE_NNTP */
-#ifdef USE_IMAP
       {
         if (i == OP_BROWSER_SUBSCRIBE)
           imap_subscribe (state.entry[menu->current].name, 1);
         else
           imap_subscribe (state.entry[menu->current].name, 0);
       }
-#endif /* USE_IMAP */
     }
   }