less and less cruft: always compile socket support in

[apps/madmutt.git] / compose.c

diff --git a/compose.c b/compose.c
index b0b20aa..aed420b 100644 (file)
--- a/compose.c
+++ b/compose.c
@@ -19,6 +19,9 @@
 #include <lib-lib/str.h>
 #include <lib-lib/macros.h>
 #include <lib-lib/file.h>
+#include <lib-lib/mapping.h>
+
+#include <lib-mime/mime.h>
 
 #include "mutt.h"
 #include "enter.h"
@@ -26,10 +29,8 @@
 #include "mutt_idna.h"
 #include "mutt_menu.h"
 #include "rfc1524.h"
-#include "mime.h"
 #include "attach.h"
 #include "recvattach.h"
-#include "mapping.h"
 #include "sort.h"
 #include "charset.h"
 #include "mx.h"
@@ -133,7 +134,8 @@ static struct mapping_t ComposeNewsHelp[] = {
 };
 #endif
 
-static void snd_entry (char *b, size_t blen, MUTTMENU * menu, int num) {
+
+static void snd_entry (char *b, ssize_t blen, MUTTMENU * menu, int num) {
   int w=(COLS-SW)>blen?blen:COLS-SW;
   mutt_FormatString (b, w, NONULL (AttachFormat), mutt_attach_fmt,
                      (unsigned long) (((ATTACHPTR **) menu->data)[num]),
@@ -146,20 +148,12 @@ static void redraw_crypt_lines (HEADER * msg)
 {
   int off = 0;
 
-  if ((WithCrypto & APPLICATION_PGP) && (WithCrypto & APPLICATION_SMIME)) {
-    if (!msg->security)
-      mvaddstr (HDR_CRYPT, SW, "    Security: ");
-    else if (msg->security & APPLICATION_SMIME)
-      mvaddstr (HDR_CRYPT, SW, "      S/MIME: ");
-    else if (msg->security & APPLICATION_PGP)
-      mvaddstr (HDR_CRYPT, SW, "         PGP: ");
-  }
-  else if ((WithCrypto & APPLICATION_SMIME))
+  if (!msg->security)
+    mvaddstr (HDR_CRYPT, SW, "    Security: ");
+  else if (msg->security & APPLICATION_SMIME)
     mvaddstr (HDR_CRYPT, SW, "      S/MIME: ");
-  else if ((WithCrypto & APPLICATION_PGP))
+  else if (msg->security & APPLICATION_PGP)
     mvaddstr (HDR_CRYPT, SW, "         PGP: ");
-  else
-    return;
 
   if ((msg->security & (ENCRYPT | SIGN)) == (ENCRYPT | SIGN))
     addstr (_("Sign, Encrypt"));
@@ -170,31 +164,27 @@ static void redraw_crypt_lines (HEADER * msg)
   else
     addstr (_("Clear"));
 
-  if ((WithCrypto & APPLICATION_PGP))
-    if ((msg->security & APPLICATION_PGP)
-        && (msg->security & (ENCRYPT | SIGN))) {
-      if ((msg->security & INLINE))
-        addstr (_(" (inline)"));
-      else
-        addstr (_(" (PGP/MIME)"));
-    }
+  if ((msg->security & APPLICATION_PGP)
+      && (msg->security & (ENCRYPT | SIGN))) {
+    if ((msg->security & INLINE))
+      addstr (_(" (inline)"));
+    else
+      addstr (_(" (PGP/MIME)"));
+  }
   clrtoeol ();
 
   move (HDR_CRYPTINFO, SW);
   clrtoeol ();
-  if ((WithCrypto & APPLICATION_PGP)
-      && msg->security & APPLICATION_PGP && msg->security & SIGN)
+  if (msg->security & APPLICATION_PGP && msg->security & SIGN)
     printw ("%s%s", _("     sign as: "),
             PgpSignAs ? PgpSignAs : _("<default>"));
 
-  if ((WithCrypto & APPLICATION_SMIME)
-      && msg->security & APPLICATION_SMIME && msg->security & SIGN) {
+  if (msg->security & APPLICATION_SMIME && msg->security & SIGN) {
     printw ("%s%s", _("     sign as: "),
             SmimeDefaultKey ? SmimeDefaultKey : _("<default>"));
   }
 
-  if ((WithCrypto & APPLICATION_SMIME)
-      && (msg->security & APPLICATION_SMIME)
+  if ((msg->security & APPLICATION_SMIME)
       && (msg->security & ENCRYPT)
       && SmimeCryptAlg && *SmimeCryptAlg) {
     mvprintw (HDR_CRYPTINFO, SW + 40, "%s%s", _("Encrypt with: "),
@@ -265,7 +255,7 @@ static int check_attachments (ATTACHPTR ** idx, short idxlen)
   return 0;
 }
 
-static void draw_envelope_addr (int line, ADDRESS * addr)
+static void draw_envelope_addr (int line, address_t * addr)
 {
   char buf[STRING];
 
@@ -303,8 +293,7 @@ static void draw_envelope (HEADER * msg, char *fcc)
   mvprintw (HDR_FCC, SW, TITLE_FMT, Prompts[HDR_FCC - 1]);
   mutt_paddstr (W, fcc);
 
-  if (WithCrypto)
-    redraw_crypt_lines (msg);
+  redraw_crypt_lines (msg);
 
 #ifdef MIXMASTER
   redraw_mix_line (msg->chain);
@@ -319,7 +308,7 @@ static void draw_envelope (HEADER * msg, char *fcc)
   SETCOLOR (MT_COLOR_NORMAL);
 }
 
-static int edit_address_list (int line, ADDRESS ** addr)
+static int edit_address_list (int line, address_t ** addr)
 {
   char buf[HUGE_STRING] = "";   /* needs to be large for alias expansion */
   char *err = NULL;
@@ -327,7 +316,7 @@ static int edit_address_list (int line, ADDRESS ** addr)
   mutt_addrlist_to_local (*addr);
   rfc822_write_address (buf, sizeof (buf), *addr, 0);
   if (mutt_get_field (Prompts[line - 1], buf, sizeof (buf), M_ALIAS) == 0) {
-    rfc822_free_address (addr);
+    address_delete (addr);
     *addr = mutt_parse_adrlist (*addr, buf);
     *addr = mutt_expand_aliases (*addr);
   }
@@ -500,7 +489,7 @@ static const char *compose_format_str (char *buf, size_t buflen, char op,
   return (src);
 }
 
-static void compose_status_line (char *buf, size_t buflen, MUTTMENU * menu,
+static void compose_status_line (char *buf, ssize_t buflen, MUTTMENU * menu,
                                  const char *p)
 {
   int w=(COLS-SW)>buflen?buflen:(COLS-SW);
@@ -526,7 +515,7 @@ int mutt_compose_menu (HEADER * msg,    /* structure for new message */
   ATTACHPTR **idx = NULL;
   short idxlen = 0;
   short idxmax = 0;
-  int i, close = 0;
+  int i, closed = 0;
   int r = -1;                   /* return value */
   int op = 0;
   int loop = 1;
@@ -621,8 +610,8 @@ int mutt_compose_menu (HEADER * msg,    /* structure for new message */
         if (mutt_get_field ("Newsgroups: ", buf, sizeof (buf), 0) == 0
             && buf[0]) {
           p_delete(&msg->env->newsgroups);
-          str_skip_trailws (buf);
-          msg->env->newsgroups = m_strdup(vskipspaces(buf));
+          m_strrtrim(buf);
+          msg->env->newsgroups = m_strdup(skipspaces(buf));
           move (HDR_TO, HDR_XOFFSET);
           clrtoeol ();
           if (msg->env->newsgroups)
@@ -639,8 +628,8 @@ int mutt_compose_menu (HEADER * msg,    /* structure for new message */
         if (mutt_get_field ("Followup-To: ", buf, sizeof (buf), 0) == 0
             && buf[0]) {
           p_delete(&msg->env->followup_to);
-          str_skip_trailws (buf);
-          msg->env->followup_to = m_strdup(vskipspaces(buf));
+          m_strrtrim(buf);
+          msg->env->followup_to = m_strdup(skipspaces(buf));
           move (HDR_CC, HDR_XOFFSET);
           clrtoeol ();
           if (msg->env->followup_to)
@@ -672,7 +661,7 @@ int mutt_compose_menu (HEADER * msg,    /* structure for new message */
       else
         buf[0] = 0;
       if (mutt_get_field ("Subject: ", buf, sizeof (buf), 0) == 0) {
-        str_replace (&msg->env->subject, buf);
+        m_strreplace(&msg->env->subject, buf);
         move (HDR_SUBJECT, HDR_XOFFSET + SW);
         clrtoeol ();
         if (msg->env->subject)
@@ -711,7 +700,7 @@ int mutt_compose_menu (HEADER * msg,    /* structure for new message */
           (op == OP_COMPOSE_EDIT_HEADERS ||
            (op == OP_COMPOSE_EDIT_MESSAGE && option (OPTEDITHDRS)))) {
         const char *tag = NULL;
-        char *err = NULL;
+        const char *err = NULL;
 
         mutt_env_to_local (msg->env);
         mutt_edit_headers (NONULL (Editor), msg->content->filename, msg,
@@ -749,8 +738,6 @@ int mutt_compose_menu (HEADER * msg,    /* structure for new message */
 
 
     case OP_COMPOSE_ATTACH_KEY:
-      if (!(WithCrypto & APPLICATION_PGP))
-        break;
       if (idxlen == idxmax) {
         p_realloc(&idx, idxmax += 5);
         menu->data = idx;
@@ -905,7 +892,7 @@ int mutt_compose_menu (HEADER * msg,    /* structure for new message */
         set_option (OPTATTACHMSG);
         mutt_message _("Tag the messages you want to attach!");
 
-        close = mutt_index_menu ();
+        closed = mutt_index_menu ();
         unset_option (OPTATTACHMSG);
 
         if (!Context) {
@@ -939,7 +926,7 @@ int mutt_compose_menu (HEADER * msg,    /* structure for new message */
         }
         menu->redraw |= REDRAW_FULL;
 
-        if (close == OP_QUIT)
+        if (closed == OP_QUIT)
           mx_close_mailbox (Context, NULL);
         else
           mx_fastclose_mailbox (Context);
@@ -1001,7 +988,7 @@ int mutt_compose_menu (HEADER * msg,    /* structure for new message */
                NONULL(idx[menu->current]->content->description));
       /* header names should not be translated */
       if (mutt_get_field ("Description: ", buf, sizeof (buf), 0) == 0) {
-        str_replace (&idx[menu->current]->content->description, buf);
+        m_strreplace(&idx[menu->current]->content->description, buf);
         menu->redraw = REDRAW_CURRENT;
       }
       mutt_message_hook (NULL, msg, M_SEND2HOOK);
@@ -1149,7 +1136,7 @@ int mutt_compose_menu (HEADER * msg,    /* structure for new message */
         if (mutt_rename_file (idx[menu->current]->content->filename, fname))
           break;
 
-        str_replace (&idx[menu->current]->content->filename, fname);
+        m_strreplace(&idx[menu->current]->content->filename, fname);
         menu->redraw = REDRAW_CURRENT;
 
         if (idx[menu->current]->content->stamp >= st.st_mtime)
@@ -1211,7 +1198,7 @@ int mutt_compose_menu (HEADER * msg,    /* structure for new message */
         update_idx (menu, idx, idxlen++);
 
         idx[menu->current]->content->type = itype;
-        str_replace (&idx[menu->current]->content->subtype, p);
+        m_strreplace(&idx[menu->current]->content->subtype, p);
         idx[menu->current]->content->unlink = 1;
         menu->redraw |= REDRAW_INDEX | REDRAW_STATUS;
 
@@ -1350,10 +1337,7 @@ int mutt_compose_menu (HEADER * msg,    /* structure for new message */
 
 
     case OP_COMPOSE_PGP_MENU:
-      if (!(WithCrypto & APPLICATION_PGP))
-        break;
-      if ((WithCrypto & APPLICATION_SMIME)
-          && msg->security & APPLICATION_SMIME) {
+      if (msg->security & APPLICATION_SMIME) {
         if (mutt_yesorno (_("S/MIME already selected. Clear & continue ? "),
                           M_YES) != M_YES) {
           mutt_clear_error ();
@@ -1373,11 +1357,7 @@ int mutt_compose_menu (HEADER * msg,    /* structure for new message */
 
 
     case OP_COMPOSE_SMIME_MENU:
-      if (!(WithCrypto & APPLICATION_SMIME))
-        break;
-
-      if ((WithCrypto & APPLICATION_PGP)
-          && msg->security & APPLICATION_PGP) {
+      if (msg->security & APPLICATION_PGP) {
         if (mutt_yesorno (_("PGP already selected. Clear & continue ? "),
                           M_YES) != M_YES) {
           mutt_clear_error ();