Use p_new instead of xmalloc()

[apps/madmutt.git] / keymap.c

diff --git a/keymap.c b/keymap.c
index 51a296f..5c9b9a6 100644 (file)
--- a/keymap.c
+++ b/keymap.c
@@ -36,19 +36,12 @@ struct mapping_t Menus[] = {
   {"key_select_smime", MENU_KEY_SELECT_SMIME},
 #endif
 
-
-#ifdef MIXMASTER
   {"mix", MENU_MIX},
-#endif
-
-
   {"query", MENU_QUERY},
   {"generic", MENU_GENERIC},
   {NULL, 0}
 };
 
-#define mutt_check_menu(s) mutt_getvaluebyname(s, Menus)
-
 static struct mapping_t KeyNames[] = {
   {"<PageUp>", KEY_PPAGE},
   {"<PageDown>", KEY_NPAGE},
@@ -94,21 +87,13 @@ static struct keymap_t *allocKeys(int len, keycode_t *keys)
 
 static int parse_fkey (const char *s)
 {
-  const char *t;
   int n = 0;
 
-  if (s[0] != '<' || ascii_tolower (s[1]) != 'f')
+  if (s[0] != '<' || ascii_tolower(s[1]) != 'f')
     return -1;
 
-  for (t = s + 2; *t && isdigit ((unsigned char) *t); t++) {
-    n *= 10;
-    n += *t - '0';
-  }
-
-  if (*t != '>')
-    return -1;
-  else
-    return n;
+  n = strtol(s + 2, (char **)&s, 10);
+  return *s == '>' ? n : -1;
 }
 
 /*
@@ -117,18 +102,18 @@ static int parse_fkey (const char *s)
  */
 static int parse_keycode (const char *s)
 {
-  if (isdigit ((unsigned char) s[1]) &&
-      isdigit ((unsigned char) s[2]) &&
-      isdigit ((unsigned char) s[3]) && s[4] == '>') {
-    return (s[3] - '0') + (s[2] - '0') * 8 + (s[1] - '0') * 64;
-  }
-  return -1;
+    int n;
+
+    if (*s != '<')
+        return -1;
+    n = strtol(s + 1, (char **)&s, 8);
+    return *s == '>' ? n : -1;
 }
 
 static int parsekeys (const char *str, keycode_t * d, int max)
 {
   int n, len = max;
-  char buff[SHORT_STRING];
+  char buff[STRING];
   char c;
   char *s, *t;
 
@@ -514,8 +499,6 @@ void km_init (void)
   create_bindings (OpPost, MENU_POST);
   create_bindings (OpQuery, MENU_QUERY);
   create_bindings (OpAlias, MENU_ALIAS);
-
-
   create_bindings (OpPgp, MENU_PGP);
   create_bindings (OpSmime, MENU_SMIME);
 
@@ -524,13 +507,11 @@ void km_init (void)
   create_bindings (OpSmime, MENU_KEY_SELECT_SMIME);
 #endif
 
-#ifdef MIXMASTER
   create_bindings (OpMix, MENU_MIX);
 
   km_bindkey ("<space>", MENU_MIX, OP_GENERIC_SELECT_ENTRY);
   km_bindkey ("h", MENU_MIX, OP_MIX_CHAIN_PREV);
   km_bindkey ("l", MENU_MIX, OP_MIX_CHAIN_NEXT);
-#endif
 
   /* bindings for the line editor */
   create_bindings (OpEditor, MENU_EDITOR);
@@ -615,7 +596,7 @@ void km_init (void)
 
 void km_error_key (int menu)
 {
-  char buf[SHORT_STRING];
+  char buf[STRING];
   struct keymap_t *key;
 
   if (!(key = km_find_func (menu, OP_HELP)))
@@ -673,7 +654,7 @@ static char *parse_keymap (int *menu, BUFFER * s, int maxmenus, int *nummenus,
       if (q)
         *q = '\0';
 
-      if ((menu[i] = mutt_check_menu (p)) == -1) {
+      if ((menu[i] = mutt_getvaluebyname(p, Menus)) == -1) {
         snprintf (err->data, err->dsize, _("%s: no such menu"), p);
         goto error;
       }
@@ -737,7 +718,6 @@ struct binding_t *km_get_table (int menu)
     return OpEditor;
   case MENU_QUERY:
     return OpQuery;
-
   case MENU_PGP:
     return OpPgp;
 
@@ -748,11 +728,8 @@ struct binding_t *km_get_table (int menu)
     return OpSmime;
 #endif
 
-#ifdef MIXMASTER
   case MENU_MIX:
     return OpMix;
-#endif
-
   }
   return NULL;
 }