simplify hashes.

[apps/madmutt.git] / lib-mx / mh.c

diff --git a/lib-mx/mh.c b/lib-mx/mh.c
index 2d79be8..e1cf230 100644 (file)
--- a/lib-mx/mh.c
+++ b/lib-mx/mh.c
@@ -86,19 +86,6 @@ static short mhs_set (struct mh_sequences *mhs, int i, short f)
   return mhs->flags[i];
 }
 
   return mhs->flags[i];
 }
 

-#if 0
-
-/* unused */
-
-static short mhs_unset (struct mh_sequences *mhs, int i, short f)
-{
-  mhs_alloc (mhs, i);
-  mhs->flags[i] &= ~f;
-  return mhs->flags[i];
-}
-
-#endif
-

 static void mh_read_token (char *t, int *first, int *last)
 {
   char *p;
 static void mh_read_token (char *t, int *first, int *last)
 {
   char *p;


@@ -151,7 +138,7 @@ static void mh_read_sequences (struct mh_sequences *mhs, const char *path)
   }
 
   p_delete(&buff);
   }
 
   p_delete(&buff);

-  safe_fclose (&fp);
+  m_fclose(&fp);

 }
 
 int mh_buffy (const char *path)
 }
 
 int mh_buffy (const char *path)


@@ -292,7 +279,7 @@ static void mh_update_sequences (CONTEXT * ctx)
       fprintf (nfp, "%s\n", buff);
     }
   }
       fprintf (nfp, "%s\n", buff);
     }
   }

-  safe_fclose (&ofp);
+  m_fclose(&ofp);

 
   /* now, update our unseen, flagged, and replied sequences */
   for (l = 0; l < ctx->msgcount; l++) {
 
   /* now, update our unseen, flagged, and replied sequences */
   for (l = 0; l < ctx->msgcount; l++) {


@@ -332,7 +319,7 @@ static void mh_update_sequences (CONTEXT * ctx)
 
 
   /* try to commit the changes - no guarantee here */
 
 
   /* try to commit the changes - no guarantee here */

-  safe_fclose (&nfp);
+  m_fclose(&nfp);

 
   unlink (sequences);
   if (safe_rename (tmpfname, sequences) != 0) {
 
   unlink (sequences);
   if (safe_rename (tmpfname, sequences) != 0) {


@@ -373,17 +360,17 @@ static void mh_sequences_add_one (CONTEXT * ctx, int n, short unseen,
   snprintf (sequences, sizeof (sequences), "%s/.mh_sequences", ctx->path);
   if ((ofp = fopen (sequences, "r"))) {
     while ((buff = mutt_read_line (buff, &sz, ofp, &line))) {
   snprintf (sequences, sizeof (sequences), "%s/.mh_sequences", ctx->path);
   if ((ofp = fopen (sequences, "r"))) {
     while ((buff = mutt_read_line (buff, &sz, ofp, &line))) {

-      if (unseen && !strncmp (buff, seq_unseen, m_strlen(seq_unseen))) {
+      if (unseen && !m_strncmp (buff, seq_unseen, m_strlen(seq_unseen))) {

         fprintf (nfp, "%s %d\n", buff, n);
         unseen_done = 1;
       }
       else if (flagged
         fprintf (nfp, "%s %d\n", buff, n);
         unseen_done = 1;
       }
       else if (flagged

-               && !strncmp (buff, seq_flagged, m_strlen(seq_flagged))) {
+               && !m_strncmp (buff, seq_flagged, m_strlen(seq_flagged))) {

         fprintf (nfp, "%s %d\n", buff, n);
         flagged_done = 1;
       }
       else if (replied
         fprintf (nfp, "%s %d\n", buff, n);
         flagged_done = 1;
       }
       else if (replied

-               && !strncmp (buff, seq_replied, m_strlen(seq_replied))) {
+               && !m_strncmp (buff, seq_replied, m_strlen(seq_replied))) {

         fprintf (nfp, "%s %d\n", buff, n);
         replied_done = 1;
       }
         fprintf (nfp, "%s %d\n", buff, n);
         replied_done = 1;
       }


@@ -391,7 +378,7 @@ static void mh_sequences_add_one (CONTEXT * ctx, int n, short unseen,
         fprintf (nfp, "%s\n", buff);
     }
   }
         fprintf (nfp, "%s\n", buff);
     }
   }

-  safe_fclose (&ofp);
+  m_fclose(&ofp);

   p_delete(&buff);
 
   if (!unseen_done && unseen)
   p_delete(&buff);
 
   if (!unseen_done && unseen)


@@ -401,7 +388,7 @@ static void mh_sequences_add_one (CONTEXT * ctx, int n, short unseen,
   if (!replied_done && replied)
     fprintf (nfp, "%s: %d\n", NONULL (MhReplied), n);
 
   if (!replied_done && replied)
     fprintf (nfp, "%s: %d\n", NONULL (MhReplied), n);
 

-  safe_fclose (&nfp);
+  m_fclose(&nfp);

 
   unlink (sequences);
   if (safe_rename (tmpfname, sequences) != 0)
 
   unlink (sequences);
   if (safe_rename (tmpfname, sequences) != 0)


@@ -548,7 +535,7 @@ static HEADER *maildir_parse_message (int magic, const char *fname,
     h->env = mutt_read_rfc822_header (f, h, 0, 0);
 
     fstat (fileno (f), &st);
     h->env = mutt_read_rfc822_header (f, h, 0, 0);
 
     fstat (fileno (f), &st);

-    fclose (f);
+    m_fclose(&f);

 
     if (!h->received)
       h->received = h->date_sent;
 
     if (!h->received)
       h->received = h->date_sent;


@@ -988,7 +975,7 @@ static int maildir_commit_message (MESSAGE * msg, CONTEXT * ctx, HEADER * hdr)
   char full[_POSIX_PATH_MAX];
   char *s;
 
   char full[_POSIX_PATH_MAX];
   char *s;
 

-  if (safe_fclose (&msg->fp) != 0)
+  if (m_fclose(&msg->fp) != 0)

     return -1;
 
   /* extract the subdir */
     return -1;
 
   /* extract the subdir */


@@ -1056,7 +1043,7 @@ static int _mh_commit_message (MESSAGE * msg, CONTEXT * ctx, HEADER * hdr,
   char path[_POSIX_PATH_MAX];
   char tmp[16];
 
   char path[_POSIX_PATH_MAX];
   char tmp[16];
 

-  if (safe_fclose (&msg->fp) != 0)
+  if (m_fclose(&msg->fp) != 0)

     return -1;
 
   if ((dirp = opendir (ctx->path)) == NULL) {
     return -1;
 
   if ((dirp = opendir (ctx->path)) == NULL) {


@@ -1485,12 +1472,12 @@ static int maildir_check_mailbox (CONTEXT * ctx, int *index_hint, int unused __a
    * of each message we scanned.  This is used in the loop over the
    * existing messages below to do some correlation.
    */
    * of each message we scanned.  This is used in the loop over the
    * existing messages below to do some correlation.
    */

-  fnames = hash_create (1031);
+  fnames = hash_create (1031, 0);

 
   for (p = md; p; p = p->next) {
     maildir_canon_filename (buf, p->h->path, sizeof (buf));
     p->canon_fname = m_strdup(buf);
 
   for (p = md; p; p = p->next) {
     maildir_canon_filename (buf, p->h->path, sizeof (buf));
     p->canon_fname = m_strdup(buf);

-    hash_insert (fnames, p->canon_fname, p, 0);
+    hash_insert (fnames, p->canon_fname, p);

   }
 
   /* check for modifications and adjust flags */
   }
 
   /* check for modifications and adjust flags */


@@ -1525,8 +1512,8 @@ static int maildir_check_mailbox (CONTEXT * ctx, int *index_hint, int unused __a
      * Check to see if we have enough information to know if the
      * message has disappeared out from underneath us.
      */
      * Check to see if we have enough information to know if the
      * message has disappeared out from underneath us.
      */

-    else if (((changed & 1) && (!strncmp (ctx->hdrs[i]->path, "new/", 4))) ||
-             ((changed & 2) && (!strncmp (ctx->hdrs[i]->path, "cur/", 4)))) {
+    else if (((changed & 1) && (!m_strncmp (ctx->hdrs[i]->path, "new/", 4))) ||
+             ((changed & 2) && (!m_strncmp (ctx->hdrs[i]->path, "cur/", 4)))) {

       /* This message disappeared, so we need to simulate a "reopen"
        * event.  We know it disappeared because we just scanned the
        * subdirectory it used to reside in.
       /* This message disappeared, so we need to simulate a "reopen"
        * event.  We know it disappeared because we just scanned the
        * subdirectory it used to reside in.


@@ -1594,7 +1581,7 @@ static int mh_check_mailbox (CONTEXT * ctx, int *index_hint, int unused __attrib
     FILE *fp = NULL;
 
     if (mh_mkstemp (ctx, &fp, &tmp) == 0) {
     FILE *fp = NULL;
 
     if (mh_mkstemp (ctx, &fp, &tmp) == 0) {

-      safe_fclose (&fp);
+      m_fclose(&fp);

       if (safe_rename (tmp, buf) == -1)
         unlink (tmp);
       p_delete(&tmp);
       if (safe_rename (tmp, buf) == -1)
         unlink (tmp);
       p_delete(&tmp);


@@ -1623,10 +1610,10 @@ static int mh_check_mailbox (CONTEXT * ctx, int *index_hint, int unused __attrib
   mhs_free_sequences (&mhs);
 
   /* check for modifications and adjust flags */
   mhs_free_sequences (&mhs);
 
   /* check for modifications and adjust flags */

-  fnames = hash_create (1031);
+  fnames = hash_create (1031, 0);

 
   for (p = md; p; p = p->next)
 
   for (p = md; p; p = p->next)

-    hash_insert (fnames, p->h->path, p, 0);
+    hash_insert (fnames, p->h->path, p);

 
   for (i = 0; i < ctx->msgcount; i++) {
     ctx->hdrs[i]->active = 0;
 
   for (i = 0; i < ctx->msgcount; i++) {
     ctx->hdrs[i]->active = 0;


@@ -1693,7 +1680,7 @@ static FILE *_maildir_open_find_message (const char *folder, const char *unique,
     if (!m_strcmp(tunique, unique)) {
       snprintf (fname, sizeof (fname), "%s/%s/%s", folder, subfolder,
                 de->d_name);
     if (!m_strcmp(tunique, unique)) {
       snprintf (fname, sizeof (fname), "%s/%s/%s", folder, subfolder,
                 de->d_name);

-      fp = fopen (fname, "r");  /* __FOPEN_CHECKED__ */
+      fp = fopen(fname, "r");

       oe = errno;
       break;
     }
       oe = errno;
       break;
     }