Fix compilation warnings

[apps/madmutt.git] / mutt_libesmtp.c

diff --git a/mutt_libesmtp.c b/mutt_libesmtp.c
index fe4f24e..e8786d9 100644 (file)
--- a/mutt_libesmtp.c
+++ b/mutt_libesmtp.c
@@ -10,28 +10,19 @@
  * It's licensed under the GNU General Public License,
  * please see the file GPL in the top level source directory.
  */
-#if HAVE_CONFIG_H
-#include "config.h"
-#endif
-
-#include <stdarg.h>
 
-#include <lib-lib/mem.h>
-#include <lib-lib/str.h>
-#include <lib-lib/ascii.h>
-#include <lib-lib/macros.h>
+#include <lib-lib/lib-lib.h>
 
 #include <lib-ui/enter.h>
+#include <lib-ui/curses.h>
 
 #include "mutt.h"
-
+#include "mutt_libesmtp.h"
 
 #if defined (USE_SSL) || (defined (USE_GNUTLS) && defined (HAVE_GNUTLS_OPENSSL_H))
 #include <openssl/ssl.h>
 #endif
 
-#include <errno.h>
-
 #include <auth-client.h>
 #include <libesmtp.h>
 
@@ -116,7 +107,8 @@ Done:
 
 static int
 _mutt_libesmtp_auth_interact (auth_client_request_t request,
-                              char **result, int fields, void *arg)
+                              char **result, int fields,
+                              void *arg __attribute__ ((unused)))
 {
   int i;
 
@@ -154,7 +146,7 @@ static const char *_mutt_libesmtp_messagefp_cb (void **buf, int *len,
   int octets;
 
   if (*buf == NULL)
-    *buf = malloc (BUFLEN);
+    *buf = xmalloc(BUFLEN);
 
   if (len == NULL) {
     rewind ((FILE *) arg);
@@ -168,7 +160,7 @@ static const char *_mutt_libesmtp_messagefp_cb (void **buf, int *len,
     char *p = strchr (*buf, '\0');
 
     if (p[-1] == '\n' && p[-2] != '\r') {
-      strcpy (p - 1, "\r\n");
+      m_strcpy(p - 1, (char *) *buf + BUFLEN - p + 1, "\r\n");
       p++;
     }
     octets = p - (char *) *buf;
@@ -189,7 +181,8 @@ static int handle_invalid_peer_certificate (long vfy_result) {
   return 1; /* Accept the problem */
 }
 
-static void event_cb (smtp_session_t session, int event_no, void *arg,...)
+static void event_cb (smtp_session_t session __attribute__ ((unused)),
+                      int event_no, void *arg,...)
 { 
   va_list alist;
   int *ok;
@@ -258,7 +251,7 @@ static void do_dsn_notify (smtp_message_t message, const char* from) {
   int flags = Notify_NOTSET;
   smtp_recipient_t self = NULL;
 
-  if (!DsnNotify || !*DsnNotify || !message || !from || !*from || 
+  if (m_strisempty(DsnNotify) || !message || m_strisempty(from) || 
       strstr (DsnNotify, "never") != NULL)
     return;
 
@@ -277,7 +270,7 @@ static void do_dsn_notify (smtp_message_t message, const char* from) {
 }
 
 static void do_dsn_ret (smtp_message_t message) {
-  if (!DsnReturn || !*DsnReturn || !message)
+  if (m_strisempty(DsnReturn) || !message)
     return;
   if (ascii_strncasecmp (DsnReturn, "hdrs", 4) == 0)
     smtp_dsn_set_ret (message, Ret_HDRS);
@@ -289,7 +282,7 @@ static void do_dsn_ret (smtp_message_t message) {
 int mutt_libesmtp_check_usetls (const char* option, unsigned long p,
                                 char* errbuf, size_t errlen) {
   char* val = (char*) p;
-  if (!val || !*val)
+  if (m_strisempty(val))
     return (1);
   if (m_strncmp(val, "enabled", 7) != 0 &&
       m_strncmp(val, "required", 8) != 0) {
@@ -398,8 +391,7 @@ int mutt_libesmtp_invoke (address_t * from,       /* the sender */
   }
 
 Done:
-  if (fp != NULL)
-    fclose (fp);
+  m_fclose(&fp);
   if (hostportstr != NULL)
     p_delete(&hostportstr);
   if (session != NULL)