X-Git-Url: http://git.madism.org/?p=apps%2Fmadmutt.git;a=blobdiff_plain;f=imap%2Fcommand.c;h=af4c2b22e8a960034abe95c00458a56d8274998d;hp=40a1cf316ff86df8b30cb58d31182ab5508eb49f;hb=22601f25ede6703ba7cd06ee84eddd2045308570;hpb=cee79e37906a9ce36e9f92905da773841ec7c194 diff --git a/imap/command.c b/imap/command.c index 40a1cf3..af4c2b2 100644 --- a/imap/command.c +++ b/imap/command.c @@ -2,7 +2,7 @@ * Copyright notice from original mutt: * Copyright (C) 1996-8 Michael R. Elkins * Copyright (C) 1996-9 Brandon Long - * Copyright (C) 1999-2002 Brendan Cully + * Copyright (C) 1999-2005 Brendan Cully * * This file is part of mutt-ng, see http://www.muttng.org/. * It's licensed under the GNU General Public License, @@ -16,14 +16,16 @@ # include "config.h" #endif +#include +#include +#include + +#include "lib/debug.h" + #include "mutt.h" -#include "imap_private.h" #include "message.h" #include "mx.h" - -#include "lib/mem.h" -#include "lib/intl.h" -#include "lib/debug.h" +#include "imap_private.h" #include #include @@ -36,10 +38,12 @@ static int cmd_handle_untagged (IMAP_DATA * idata); static void cmd_make_sequence (IMAP_DATA * idata); static void cmd_parse_capabilities (IMAP_DATA * idata, char *s); static void cmd_parse_expunge (IMAP_DATA * idata, const char *s); +static void cmd_parse_lsub (IMAP_DATA* idata, char* s); static void cmd_parse_fetch (IMAP_DATA * idata, char *s); static void cmd_parse_myrights (IMAP_DATA * idata, char *s); +static void cmd_parse_search (IMAP_DATA* idata, char* s); -static char *Capabilities[] = { +static const char *Capabilities[] = { "IMAP4", "IMAP4rev1", "STATUS", @@ -70,13 +74,13 @@ int imap_cmd_start (IMAP_DATA * idata, const char *cmd) cmd_make_sequence (idata); /* seq, space, cmd, \r\n\0 */ - outlen = mutt_strlen (idata->cmd.seq) + mutt_strlen (cmd) + 4; - out = (char *) safe_malloc (outlen); + outlen = m_strlen(idata->cmd.seq) + m_strlen(cmd) + 4; + out = p_new(char, outlen); snprintf (out, outlen, "%s %s\r\n", idata->cmd.seq, cmd); rc = mutt_socket_write (idata->conn, out); - FREE (&out); + p_delete(&out); return (rc < 0) ? IMAP_CMD_BAD : 0; } @@ -100,11 +104,14 @@ int imap_cmd_step (IMAP_DATA * idata) * line */ do { if (len == cmd->blen) { - safe_realloc (&cmd->buf, cmd->blen + IMAP_CMD_BUFSIZE); + p_realloc(&cmd->buf, cmd->blen + IMAP_CMD_BUFSIZE); cmd->blen = cmd->blen + IMAP_CMD_BUFSIZE; debug_print (3, ("grew buffer to %u bytes\n", cmd->blen)); } + if (len) + len--; + c = mutt_socket_readln (cmd->buf + len, cmd->blen - len, idata->conn); if (c <= 0) { debug_print (1, ("Error reading server response.\n")); @@ -121,7 +128,7 @@ int imap_cmd_step (IMAP_DATA * idata) /* don't let one large string make cmd->buf hog memory forever */ if ((cmd->blen > IMAP_CMD_BUFSIZE) && (len <= IMAP_CMD_BUFSIZE)) { - safe_realloc (&cmd->buf, IMAP_CMD_BUFSIZE); + p_realloc(&cmd->buf, IMAP_CMD_BUFSIZE); cmd->blen = IMAP_CMD_BUFSIZE; debug_print (3, ("shrank buffer to %u bytes\n", cmd->blen)); } @@ -133,9 +140,8 @@ int imap_cmd_step (IMAP_DATA * idata) return IMAP_CMD_BAD; /* server demands a continuation response from us */ - if (!ascii_strncmp (cmd->buf, "+ ", 2)) { + if (cmd->buf[0] == '+') return IMAP_CMD_RESPOND; - } /* tagged completion code */ if (!ascii_strncmp (cmd->buf, cmd->seq, SEQLEN)) { @@ -149,9 +155,8 @@ int imap_cmd_step (IMAP_DATA * idata) /* imap_code: returns 1 if the command result was OK, or 0 if NO or BAD */ int imap_code (const char *s) { - s += SEQLEN; - SKIPWS (s); - return (ascii_strncasecmp ("OK", s, 2) == 0); + s = vskipspaces(s + SEQLEN); + return !ascii_strncasecmp("OK", s, 2); } /* imap_exec: execute a command, and wait for the response from the server. @@ -182,14 +187,14 @@ int imap_exec (IMAP_DATA * idata, const char *cmd, int flags) /* create sequence for command */ cmd_make_sequence (idata); /* seq, space, cmd, \r\n\0 */ - outlen = mutt_strlen (idata->cmd.seq) + mutt_strlen (cmd) + 4; - out = (char *) safe_malloc (outlen); + outlen = m_strlen(idata->cmd.seq) + m_strlen(cmd) + 4; + out = p_new(char, outlen); snprintf (out, outlen, "%s %s\r\n", idata->cmd.seq, cmd); rc = mutt_socket_write_d (idata->conn, out, flags & IMAP_CMD_PASS ? IMAP_LOG_PASS : IMAP_LOG_CMD); - FREE (&out); + p_delete(&out); if (rc < 0) { cmd_handle_fatal (idata); @@ -347,8 +352,12 @@ static int cmd_handle_untagged (IMAP_DATA * idata) } else if (ascii_strncasecmp ("CAPABILITY", s, 10) == 0) cmd_parse_capabilities (idata, s); + else if (ascii_strncasecmp ("LSUB", s, 4) == 0) + cmd_parse_lsub (idata, s); else if (ascii_strncasecmp ("MYRIGHTS", s, 8) == 0) cmd_parse_myrights (idata, s); + else if (ascii_strncasecmp ("SEARCH", s, 6) == 0) + cmd_parse_search (idata, s); else if (ascii_strncasecmp ("BYE", s, 3) == 0) { debug_print (2, ("Handling BYE\n")); @@ -357,8 +366,7 @@ static int cmd_handle_untagged (IMAP_DATA * idata) return 0; /* server shut down our connection */ - s += 3; - SKIPWS (s); + s = vskipspaces(s + 3); mutt_error ("%s", s); mutt_sleep (2); cmd_handle_fatal (idata); @@ -376,6 +384,35 @@ static int cmd_handle_untagged (IMAP_DATA * idata) return 0; } +/* This should be optimised (eg with a tree or hash) */ +static int uid2msgno (IMAP_DATA* idata, unsigned int uid) { + int i; + + for (i = 0; i < idata->ctx->msgcount; i++) { + HEADER* h = idata->ctx->hdrs[i]; + if (HEADER_DATA(h)->uid == uid) + return i; + } + + return -1; +} + +/* cmd_parse_search: store SEARCH response for later use */ +static void cmd_parse_search (IMAP_DATA* idata, char* s) { + unsigned int uid; + int msgno; + + debug_print (2, ("Handling SEARCH\n")); + + while ((s = imap_next_word (s)) && *s != '\0') { + uid = atoi (s); + msgno = uid2msgno (idata, uid); + + if (msgno >= 0) + idata->ctx->hdrs[uid2msgno (idata, uid)]->matched = 1; + } +} + /* cmd_make_sequence: make a tag suitable for starting an IMAP command */ static void cmd_make_sequence (IMAP_DATA * idata) { @@ -394,10 +431,10 @@ static void cmd_parse_capabilities (IMAP_DATA * idata, char *s) debug_print (2, ("Handling CAPABILITY\n")); s = imap_next_word (s); - FREE (&idata->capstr); - idata->capstr = safe_strdup (s); + p_delete(&idata->capstr); + idata->capstr = m_strdup(s); - memset (idata->capabilities, 0, sizeof (idata->capabilities)); + p_clear(idata->capabilities, 1); while (*s) { for (x = 0; x < CAPMAX; x++) @@ -454,6 +491,9 @@ static void cmd_parse_fetch (IMAP_DATA * idata, char *s) for (cur = 0; cur < idata->ctx->msgcount; cur++) { h = idata->ctx->hdrs[cur]; + if (!h) + break; + if (h->active && h->index + 1 == msgno) { debug_print (2, ("Message UID %d updated\n", HEADER_DATA (h)->uid)); break; @@ -491,6 +531,60 @@ static void cmd_parse_fetch (IMAP_DATA * idata, char *s) } } +static void cmd_parse_lsub (IMAP_DATA* idata, char* s) { + char buf[STRING]; + char errstr[STRING]; + BUFFER err, token; + ciss_url_t url; + char *ep; + + if (!option (OPTIMAPCHECKSUBSCRIBED)) + return; + + s = imap_next_word (s); /* flags */ + + if (*s != '(') { + debug_print (1, ("Bad LSUB response\n")); + return; + } + + s++; + ep = s; + for (ep = s; *ep && *ep != ')'; ep++); + do { + if (!ascii_strncasecmp (s, "\\NoSelect", 9)) + return; + while (s < ep && *s != ' ' && *s != ')') + s++; + if (*s == ' ') + s++; + } while (s != ep); + + s = imap_next_word (s); /* delim */ + s = imap_next_word (s); /* name */ + + if (s) { + imap_unmunge_mbox_name (s); + debug_print (2, ("Subscribing to %s\n", s)); + + m_strcpy(buf, sizeof(buf), "mailboxes \""); + mutt_account_tourl (&idata->conn->account, &url); + url.path = s; + if (!m_strcmp(url.user, ImapUser)) + url.user = NULL; + url_ciss_tostring (&url, buf + 11, sizeof (buf) - 10, 0); + m_strcat(buf, sizeof(buf), "\""); + p_clear(&token, 1); + err.data = errstr; + err.dsize = sizeof (errstr); + if (mutt_parse_rc_line (buf, &token, &err)) + debug_print (1, ("Error adding subscribed mailbox: %s\n", errstr)); + p_delete(&token.data); + } + else + debug_print (1, ("Bad LSUB response\n")); +} + /* cmd_parse_myrights: set rights bits according to MYRIGHTS response */ static void cmd_parse_myrights (IMAP_DATA * idata, char *s) { @@ -500,7 +594,7 @@ static void cmd_parse_myrights (IMAP_DATA * idata, char *s) s = imap_next_word (s); /* zero out current rights set */ - memset (idata->rights, 0, sizeof (idata->rights)); + p_clear(idata->rights, 1); while (*s && !isspace ((unsigned char) *s)) { switch (*s) {