X-Git-Url: http://git.madism.org/?p=apps%2Fmadmutt.git;a=blobdiff_plain;f=lib-mx%2Fmx.c;fp=lib-mx%2Fmx.c;h=98bd9fa229f985720ca725f35e0769fb39750f51;hp=72f1349f92459fbd4a4ea47f99bbb0ebbbad147a;hb=8cb10a4102d1271eeb6d7892a3979ec9ed0beb36;hpb=671b6a2f5c5190e6399cc000906491668eef90f1;ds=sidebyside diff --git a/lib-mx/mx.c b/lib-mx/mx.c index 72f1349..98bd9fa 100644 --- a/lib-mx/mx.c +++ b/lib-mx/mx.c @@ -10,6 +10,8 @@ #include +#include + #include #include #include @@ -27,7 +29,6 @@ #include "keymap.h" #include "compress.h" #include "score.h" -#include "dotlock.h" #include #include "pop.h" @@ -50,66 +51,23 @@ static mx_t const *mxfmts[] = { #define MX_IDX(idx) (idx >= 0 && idx < countof(mxfmts)) #define mutt_is_spool(s) (m_strcmp(Spoolfile, s) == 0) -/* parameters: - * path - file to lock - * retry - should retry if unable to lock? - */ -static int invoke_dotlock (const char *path, int flags, int retry) +static int dotlock_file(const char *path, int retry) { - char cmd[LONG_STRING + _POSIX_PATH_MAX]; - char f[STRING + _POSIX_PATH_MAX]; - char r[STRING]; - - if (flags & DL_FL_RETRY) - snprintf (r, sizeof (r), "-r %d ", retry ? MAXLOCKATTEMPT : 0); - - mutt_quote_filename (f, sizeof (f), path); - - snprintf(cmd, sizeof(cmd), "%s %s%s%s%s%s%s%s", - mod_core.dotlock, - flags & DL_FL_TRY ? "-t " : "", - flags & DL_FL_UNLOCK ? "-u " : "", - flags & DL_FL_USEPRIV ? "-p " : "", - flags & DL_FL_FORCE ? "-f " : "", - flags & DL_FL_UNLINK ? "-d " : "", - flags & DL_FL_RETRY ? r : "", f); - - return mutt_system (cmd); -} + char lockfile[PATH_MAX]; + snprintf(lockfile, sizeof(lockfile), "%s.lock", path); -static int dotlock_file (const char *path, int retry) -{ - int r; - int flags = DL_FL_USEPRIV | DL_FL_RETRY; - - if (retry) - retry = 1; - -retry_lock: - if ((r = invoke_dotlock (path, flags, retry)) == DL_EX_EXIST) { - if (!option (OPTNOCURSES)) { - char msg[LONG_STRING]; - - snprintf (msg, sizeof (msg), - _("Lock count exceeded, remove lock for %s?"), path); - if (retry && mutt_yesorno (msg, M_YES) == M_YES) { - flags |= DL_FL_FORCE; - retry--; - mutt_clear_error (); - goto retry_lock; - } - } - else { - mutt_error (_("Can't dotlock %s.\n"), path); + if (lockfile_create(lockfile, retry ? 1 : 0, 0)) { + if (retry) + mutt_error (_("Can't dotlock %s.\n"), lockfile); } - } - return (r == DL_EX_OK ? 0 : -1); + return 0; } static int undotlock_file (const char *path) { - return (invoke_dotlock (path, DL_FL_USEPRIV | DL_FL_UNLOCK, 0) == - DL_EX_OK ? 0 : -1); + char lockfile[PATH_MAX]; + snprintf(lockfile, sizeof(lockfile), "%s.lock", path); + lockfile_remove(lockfile); } /* looks up index of type for path in mxfmts */ @@ -154,7 +112,6 @@ int mx_lock_file (const char *path, int fd, int excl, int dot, int time_out) #ifdef USE_FCNTL struct flock lck; - p_clear(&lck, 1); lck.l_type = excl ? F_WRLCK : F_RDLCK; lck.l_whence = SEEK_SET; @@ -228,7 +185,7 @@ int mx_lock_file (const char *path, int fd, int excl, int dot, int time_out) #endif /* USE_FLOCK */ if (r == 0 && dot) - r = dotlock_file (path, time_out); + r = dotlock_file(path, time_out); if (r == -1) { /* release any other locks obtained in this routine */