X-Git-Url: http://git.madism.org/?p=apps%2Fmadmutt.git;a=blobdiff_plain;f=lib-mx%2Fmx.c;h=1a7db32fb06bdb32ecb387522b18ecd21d3e046c;hp=b6fcfc12ca67654a4b7850f5234b0395bce517c5;hb=5a4ed6a80a95c870a3603350d2a1e99b99d99b5b;hpb=558b0bd9de90a9dc28f409d8f46679bf48c72ded

diff --git a/lib-mx/mx.c b/lib-mx/mx.c
index b6fcfc1..1a7db32 100644
--- a/lib-mx/mx.c
+++ b/lib-mx/mx.c
@@ -10,17 +10,16 @@
 
 #include <lib-lib/lib-lib.h>
 
-#include <utime.h>
+#include <lockfile.h>
 
 #include <lib-lua/lib-lua.h>
 #include <lib-sys/unix.h>
 #include <lib-mime/mime.h>
-#include <lib-ui/sidebar.h>
-#include <lib-crypt/crypt.h>
+#include <lib-ui/lib-ui.h>
 
 #include "mutt.h"
+#include "crypt.h"
 #include "pattern.h"
-#include "buffy.h"
 #include "mx.h"
 #include "mbox.h"
 #include "mh.h"
@@ -29,91 +28,42 @@
 #include "copy.h"
 #include "keymap.h"
 #include "compress.h"
-#include "dotlock.h"
+#include "score.h"
 
 #include <imap/imap.h>
-#include <pop/pop.h>
+#include "pop.h"
 
-#ifdef USE_NNTP
-#include <nntp/nntp.h>
-#endif
+#define MAXLOCKATTEMPT 5
 
 static mx_t const *mxfmts[] = {
     &mbox_mx,
-    &mmdf_mx,
     &mh_mx,
     &maildir_mx,
     &imap_mx,
     &pop_mx,
-#ifdef USE_NNTP
-    &nntp_mx,
-#endif
     &compress_mx,
 };
 
 #define MX_IDX(idx)          (idx >= 0 && idx < countof(mxfmts))
 #define mutt_is_spool(s)     (m_strcmp(Spoolfile, s) == 0)
 
-/* parameters: 
- * path - file to lock
- * retry - should retry if unable to lock?
- */
-static int invoke_dotlock (const char *path, int flags, int retry)
+static int dotlock_file(const char *path, int retry)
 {
-  char cmd[LONG_STRING + _POSIX_PATH_MAX];
-  char f[STRING + _POSIX_PATH_MAX];
-  char r[STRING];
-
-  if (flags & DL_FL_RETRY)
-    snprintf (r, sizeof (r), "-r %d ", retry ? MAXLOCKATTEMPT : 0);
-
-  mutt_quote_filename (f, sizeof (f), path);
-
-  snprintf(cmd, sizeof(cmd), "%s %s%s%s%s%s%s%s",
-           MCore.dotlock,
-           flags & DL_FL_TRY ? "-t " : "",
-           flags & DL_FL_UNLOCK ? "-u " : "",
-           flags & DL_FL_USEPRIV ? "-p " : "",
-           flags & DL_FL_FORCE ? "-f " : "",
-           flags & DL_FL_UNLINK ? "-d " : "",
-           flags & DL_FL_RETRY ? r : "", f);
-
-  return mutt_system (cmd);
-}
+    char lockfile[_POSIX_PATH_MAX];
+    snprintf(lockfile, sizeof(lockfile), "%s.lock", path);
 
-static int dotlock_file (const char *path, int retry)
-{
-  int r;
-  int flags = DL_FL_USEPRIV | DL_FL_RETRY;
-
-  if (retry)
-    retry = 1;
-
-retry_lock:
-  if ((r = invoke_dotlock (path, flags, retry)) == DL_EX_EXIST) {
-    if (!option (OPTNOCURSES)) {
-      char msg[LONG_STRING];
-
-      snprintf (msg, sizeof (msg),
-                _("Lock count exceeded, remove lock for %s?"), path);
-      if (retry && mutt_yesorno (msg, M_YES) == M_YES) {
-        flags |= DL_FL_FORCE;
-        retry--;
-        mutt_clear_error ();
-        goto retry_lock;
-      }
-    }
-    else {
-      mutt_error (_("Can't dotlock %s.\n"), path);
+    if (lockfile_create(lockfile, retry ? 1 : 0, 0)) {
+        if (retry)
+            mutt_error (_("Can't dotlock %s.\n"), lockfile);
     }
-  }
-  return (r == DL_EX_OK ? 0 : -1);
+    return 0;
 }
 
 static int undotlock_file (const char *path)
 {
-  return (invoke_dotlock (path,  DL_FL_USEPRIV | DL_FL_UNLOCK, 0) ==
-          DL_EX_OK ? 0 : -1);
+    char lockfile[_POSIX_PATH_MAX];
+    snprintf(lockfile, sizeof(lockfile), "%s.lock", path);
+    return lockfile_remove(lockfile);
 }
 
 /* looks up index of type for path in mxfmts */
@@ -126,7 +76,7 @@ static int mx_get_idx (const char* path) {
         if (!mxfmts[i]->local)
             t = mxfmts[i]->mx_is_magic(path, NULL);
         if (t >= 1)
-            return (t-1);
+            return t-1;
     }
     if (stat (path, &st) == 0) {
         /* if stat() succeeded, keep testing until success and
@@ -135,160 +85,58 @@ static int mx_get_idx (const char* path) {
             if (mxfmts[i]->local)
                 t = mxfmts[i]->mx_is_magic(path, &st);
             if (t >= 1)
-                return (t-1);
+                return t-1;
         }
     }
-    return (-1);
+    return -1;
 }
 
 /* Args:
  *	excl		if excl != 0, request an exclusive lock
- *	dot		if dot != 0, try to dotlock the file
  *	time_out 	should retry locking?
  */
-int mx_lock_file (const char *path, int fd, int excl, int dot, int time_out)
+int mx_lock_file(const char *path, int fd, int excl, int time_out)
 {
-#if defined (USE_FCNTL) || defined (USE_FLOCK)
-  int count;
-  int attempt;
-  struct stat prev_sb;
-#endif
-  int r = 0;
-
-#ifdef USE_FCNTL
-  struct flock lck;
-
-
-  p_clear(&lck, 1);
-  lck.l_type = excl ? F_WRLCK : F_RDLCK;
-  lck.l_whence = SEEK_SET;
-
-  count = 0;
-  attempt = 0;
-  prev_sb.st_size = 0;
-  while (fcntl (fd, F_SETLK, &lck) == -1) {
-    struct stat sb;
-
-    if (errno != EAGAIN && errno != EACCES) {
-      mutt_perror ("fcntl");
-      return (-1);
-    }
+    int count = 0, attempt = 0;
+    struct flock lck = {
+        .l_type   = excl ? F_WRLCK : F_RDLCK,
+        .l_whence = SEEK_SET,
+    };
 
-    if (fstat (fd, &sb) != 0)
-      sb.st_size = 0;
-
-    if (count == 0)
-      prev_sb = sb;
-
-    /* only unlock file if it is unchanged */
-    if (prev_sb.st_size == sb.st_size
-        && ++count >= (time_out ? MAXLOCKATTEMPT : 0)) {
-      if (time_out)
-        mutt_error _("Timeout exceeded while attempting fcntl lock!");
-
-      return (-1);
-    }
-
-    prev_sb = sb;
-
-    mutt_message (_("Waiting for fcntl lock... %d"), ++attempt);
-    sleep (1);
-  }
-#endif /* USE_FCNTL */
-
-#ifdef USE_FLOCK
-  count = 0;
-  attempt = 0;
-  while (flock (fd, (excl ? LOCK_EX : LOCK_SH) | LOCK_NB) == -1) {
-    struct stat sb;
-
-    if (errno != EWOULDBLOCK) {
-      mutt_perror ("flock");
-      r = -1;
-      break;
-    }
-
-    if (fstat (fd, &sb) != 0)
-      sb.st_size = 0;
-
-    if (count == 0)
-      prev_sb = sb;
+    if (dotlock_file(path, time_out) < 0)
+        return -1;
 
-    /* only unlock file if it is unchanged */
-    if (prev_sb.st_size == sb.st_size
-        && ++count >= (time_out ? MAXLOCKATTEMPT : 0)) {
-      if (time_out)
-        mutt_error _("Timeout exceeded while attempting flock lock!");
+    while (fcntl(fd, F_SETLK, &lck) == -1) {
+        if (errno != EAGAIN && errno != EACCES) {
+            mutt_perror("fcntl");
+            goto error;
+        }
 
-      r = -1;
-      break;
+        if (++count >= (time_out ? MAXLOCKATTEMPT : 0)) {
+            if (time_out)
+                mutt_error _("Timeout exceeded while attempting fcntl lock!");
+            goto error;
+        }
+        mutt_message(_("Waiting for fcntl lock... %d"), ++attempt);
+        mutt_sleep(1);
     }
+    return 0;
 
-    prev_sb = sb;
-
-    mutt_message (_("Waiting for flock attempt... %d"), ++attempt);
-    sleep (1);
-  }
-#endif /* USE_FLOCK */
-
-  if (r == 0 && dot)
-    r = dotlock_file (path, time_out);
-
-  if (r == -1) {
-    /* release any other locks obtained in this routine */
-
-#ifdef USE_FCNTL
-    lck.l_type = F_UNLCK;
-    fcntl (fd, F_SETLK, &lck);
-#endif /* USE_FCNTL */
-
-#ifdef USE_FLOCK
-    flock (fd, LOCK_UN);
-#endif /* USE_FLOCK */
-
-    return (-1);
-  }
-
-  return 0;
-}
-
-int mx_unlock_file (const char *path, int fd, int dot)
-{
-#ifdef USE_FCNTL
-  struct flock unlockit;
-
-  p_clear(&unlockit, 1);
-  unlockit.l_type = F_UNLCK;
-  unlockit.l_whence = SEEK_SET;
-  fcntl (fd, F_SETLK, &unlockit);
-#endif
-
-#ifdef USE_FLOCK
-  flock (fd, LOCK_UN);
-#endif
-
-  if (dot)
-    undotlock_file (path);
-
-  return 0;
+  error:
+    undotlock_file(path);
+    return -1;
 }
 
-static void mx_unlink_empty (const char *path)
+int mx_unlock_file(const char *path, int fd)
 {
-  int fd;
-
-  if ((fd = open (path, O_RDWR)) == -1)
-    return;
+    struct flock unlockit;
 
-  if (mx_lock_file (path, fd, 1, 0, 1) == -1) {
-    close (fd);
-    return;
-  }
-
-  invoke_dotlock(path, DL_FL_UNLINK, 1);
-
-  mx_unlock_file (path, fd, 0);
-  close (fd);
+    p_clear(&unlockit, 1);
+    unlockit.l_type = F_UNLCK;
+    unlockit.l_whence = SEEK_SET;
+    fcntl(fd, F_SETLK, &unlockit);
+    undotlock_file(path);
+    return 0;
 }
 
 /* try to figure out what type of mailbox ``path'' is */
@@ -296,35 +144,16 @@ int mx_get_magic (const char *path) {
   int i = 0;
 
   if (m_strlen(path) == 0)
-    return (-1);
+    return -1;
   if ((i = mx_get_idx (path)) >= 0)
-    return (mxfmts[i]->type);
-  return (-1);
+    return mxfmts[i]->type;
+  return -1;
 }
 
 int mx_is_local (int m) {
   if (!MX_IDX(m))
-    return (0);
-  return (mxfmts[m]->local);
-}
-
-/*
- * set DefaultMagic to the given value
- */
-int mx_set_magic (const char *s)
-{
-  if (ascii_strcasecmp (s, "mbox") == 0)
-    DefaultMagic = M_MBOX;
-  else if (ascii_strcasecmp (s, "mmdf") == 0)
-    DefaultMagic = M_MMDF;
-  else if (ascii_strcasecmp (s, "mh") == 0)
-    DefaultMagic = M_MH;
-  else if (ascii_strcasecmp (s, "maildir") == 0)
-    DefaultMagic = M_MAILDIR;
-  else
-    return (-1);
-
-  return 0;
+    return 0;
+  return mxfmts[m]->local;
 }
 
 /* mx_access: Wrapper for access, checks permissions on a given mailbox.
@@ -335,8 +164,8 @@ int mx_access (const char *path, int flags)
   int i = 0;
 
   if ((i = mx_get_idx (path)) >= 0 && mxfmts[i]->mx_access)
-    return (mxfmts[i]->mx_access(path,flags));
-  return (0);
+    return mxfmts[i]->mx_access(path,flags);
+  return 0;
 }
 
 static int mx_open_mailbox_append (CONTEXT * ctx, int flags)
@@ -361,91 +190,64 @@ static int mx_open_mailbox_append (CONTEXT * ctx, int flags)
       mutt_error (_("%s is not a mailbox."), ctx->path);
       /* fall through */
     case -1:
-      return (-1);
+      return -1;
     }
-  }
-  else if (errno == ENOENT) {
-    ctx->magic = DefaultMagic;
-
-    if (ctx->magic == M_MH || ctx->magic == M_MAILDIR) {
+  } else if (errno == ENOENT) {
+    int len = m_strlen(ctx->path);
+    if (len > 0 && ctx->path[len - 1] == '/') {
       char tmp[_POSIX_PATH_MAX];
 
       if (mkdir (ctx->path, S_IRWXU)) {
         mutt_perror (ctx->path);
-        return (-1);
+        return -1;
       }
 
-      if (ctx->magic == M_MAILDIR) {
-        snprintf (tmp, sizeof (tmp), "%s/cur", ctx->path);
-        if (mkdir (tmp, S_IRWXU)) {
-          mutt_perror (tmp);
-          rmdir (ctx->path);
-          return (-1);
-        }
+      snprintf (tmp, sizeof (tmp), "%s/cur", ctx->path);
+      if (mkdir (tmp, S_IRWXU)) {
+        mutt_perror (tmp);
+        rmdir (ctx->path);
+        return -1;
+      }
 
-        snprintf (tmp, sizeof (tmp), "%s/new", ctx->path);
-        if (mkdir (tmp, S_IRWXU)) {
-          mutt_perror (tmp);
-          snprintf (tmp, sizeof (tmp), "%s/cur", ctx->path);
-          rmdir (tmp);
-          rmdir (ctx->path);
-          return (-1);
-        }
-        snprintf (tmp, sizeof (tmp), "%s/tmp", ctx->path);
-        if (mkdir (tmp, S_IRWXU)) {
-          mutt_perror (tmp);
-          snprintf (tmp, sizeof (tmp), "%s/cur", ctx->path);
-          rmdir (tmp);
-          snprintf (tmp, sizeof (tmp), "%s/new", ctx->path);
-          rmdir (tmp);
-          rmdir (ctx->path);
-          return (-1);
-        }
+      snprintf (tmp, sizeof (tmp), "%s/new", ctx->path);
+      if (mkdir (tmp, S_IRWXU)) {
+        mutt_perror (tmp);
+        snprintf (tmp, sizeof (tmp), "%s/cur", ctx->path);
+        rmdir (tmp);
+        rmdir (ctx->path);
+        return -1;
       }
-      else {
-        int i;
-
-        snprintf (tmp, sizeof (tmp), "%s/.mh_sequences", ctx->path);
-        if ((i = creat (tmp, S_IRWXU)) == -1) {
-          mutt_perror (tmp);
-          rmdir (ctx->path);
-          return (-1);
-        }
-        close (i);
+      snprintf (tmp, sizeof (tmp), "%s/tmp", ctx->path);
+      if (mkdir (tmp, S_IRWXU)) {
+        mutt_perror (tmp);
+        snprintf (tmp, sizeof (tmp), "%s/cur", ctx->path);
+        rmdir (tmp);
+        snprintf (tmp, sizeof (tmp), "%s/new", ctx->path);
+        rmdir (tmp);
+        rmdir (ctx->path);
+        return -1;
       }
+      ctx->magic = M_MAILDIR;
+    } else {
+      ctx->magic = M_MBOX;
     }
-  }
-  else {
+  } else {
     mutt_perror (ctx->path);
-    return (-1);
+    return -1;
   }
 
-  switch (ctx->magic) {
-  case M_MBOX:
-  case M_MMDF:
-    if ((ctx->fp =
-         safe_fopen (ctx->path, flags & M_NEWFOLDER ? "w" : "a")) == NULL
-        || mbox_lock_mailbox (ctx, 1, 1) != 0) {
-      if (!ctx->fp)
-        mutt_perror (ctx->path);
-      else {
-        mutt_error (_("Couldn't lock %s\n"), ctx->path);
-        m_fclose(&ctx->fp);
-      }
-      return (-1);
+  if (ctx->magic == M_MBOX) {
+    if (!(ctx->fp = safe_fopen(ctx->path, flags & M_NEWFOLDER ? "w" : "a"))) {
+      mutt_perror(ctx->path);
+      return -1;
     }
-    fseeko (ctx->fp, 0, 2);
-    break;
-
-  case M_MH:
-  case M_MAILDIR:
-    /* nothing to do */
-    break;
-
-  default:
-    return (-1);
+    if (mbox_lock_mailbox(ctx, 1, 1) != 0) {
+      mutt_error(_("Couldn't lock %s\n"), ctx->path);
+      m_fclose(&ctx->fp);
+      return -1;
+    }
+    fseeko(ctx->fp, 0, 2);
   }
-
   return 0;
 }
 
@@ -505,7 +307,7 @@ CONTEXT *mx_open_mailbox (const char *path, int flags, CONTEXT * pctx)
     mx_fastclose_mailbox (ctx);
     if (!pctx)
       p_delete(&ctx);
-    return (NULL);
+    return NULL;
   }
 
   /* if the user has a `push' command in their .muttrc, or in a folder-hook,
@@ -538,7 +340,7 @@ CONTEXT *mx_open_mailbox (const char *path, int flags, CONTEXT * pctx)
   }
 
   unset_option (OPTFORCEREFRESH);
-  return (ctx);
+  return ctx;
 }
 
 /* free up memory associated with the mailbox context */
@@ -650,15 +452,6 @@ static int _mx_close_mailbox (CONTEXT * ctx, int *index_hint)
 
   ctx->closing = 1;
 
-#ifdef USE_NNTP
-  if (ctx->magic == M_NNTP) {
-    int ret;
-
-    ret = nntp_close_mailbox (ctx);
-    mx_fastclose_mailbox (ctx);
-    return ret;
-  }
-#endif
   if (ctx->readonly || ctx->dontwrite) {
     /* mailbox is readonly or we don't want to write */
     mx_fastclose_mailbox (ctx);
@@ -667,7 +460,7 @@ static int _mx_close_mailbox (CONTEXT * ctx, int *index_hint)
 
   if (ctx->append) {
     /* mailbox was opened in write-mode */
-    if (ctx->magic == M_MBOX || ctx->magic == M_MMDF)
+    if (ctx->magic == M_MBOX)
       mbox_close_mailbox (ctx);
     else
       mx_fastclose_mailbox (ctx);
@@ -681,23 +474,15 @@ static int _mx_close_mailbox (CONTEXT * ctx, int *index_hint)
   }
 
   if (read_msgs && quadoption (OPT_MOVE) != M_NO) {
-    char *p;
-
-    if ((p = mutt_find_hook (M_MBOXHOOK, ctx->path))) {
-      isSpool = 1;
-      m_strcpy(mbox, sizeof(mbox), p);
-    }
-    else {
-      m_strcpy(mbox, sizeof(mbox), NONULL(Inbox));
-      isSpool = mutt_is_spool (ctx->path) && !mutt_is_spool (mbox);
-    }
+    m_strcpy(mbox, sizeof(mbox), NONULL(Inbox));
+    isSpool = mutt_is_spool (ctx->path) && !mutt_is_spool (mbox);
     mutt_expand_path (mbox, sizeof (mbox));
 
     if (isSpool) {
       snprintf (buf, sizeof (buf), _("Move read messages to %s?"), mbox);
       if ((move_messages = query_quadoption (OPT_MOVE, buf)) == -1) {
         ctx->closing = 0;
-        return (-1);
+        return -1;
       }
     }
   }
@@ -712,7 +497,7 @@ static int _mx_close_mailbox (CONTEXT * ctx, int *index_hint)
               _("Purge %d deleted messages?"), ctx->deleted);
     if ((purge = query_quadoption (OPT_DELETE, buf)) < 0) {
       ctx->closing = 0;
-      return (-1);
+      return -1;
     }
   }
 
@@ -731,7 +516,7 @@ static int _mx_close_mailbox (CONTEXT * ctx, int *index_hint)
     /* try to use server-side copy first */
     i = 1;
 
-    if (ctx->magic == M_IMAP && imap_is_magic (mbox, NULL) == M_IMAP) {
+    if (ctx->magic == M_IMAP && imap_mx.mx_is_magic (mbox, NULL) == M_IMAP) {
       /* tag messages for moving, and clear old tags, if any */
       for (i = 0; i < ctx->msgcount; i++)
         if (ctx->hdrs[i]->read && !ctx->hdrs[i]->deleted
@@ -820,13 +605,8 @@ static int _mx_close_mailbox (CONTEXT * ctx, int *index_hint)
     mutt_message (_("%d kept, %d deleted."),
                   ctx->msgcount - ctx->deleted, ctx->deleted);
 
-  if (ctx->msgcount == ctx->deleted &&
-      (ctx->magic == M_MMDF || ctx->magic == M_MBOX) &&
-      !mutt_is_spool (ctx->path) && !option (OPTSAVEEMPTY))
-    mx_unlink_empty (ctx->path);
-
   if (ctx->cinfo && mutt_slow_close_compressed (ctx))
-    return (-1);
+    return -1;
 
   mx_fastclose_mailbox (ctx);
 
@@ -836,10 +616,10 @@ static int _mx_close_mailbox (CONTEXT * ctx, int *index_hint)
 int mx_close_mailbox (CONTEXT * ctx, int *index_hint) {
   int ret = 0;
   if (!ctx)
-    return (0);
+    return 0;
   ret = _mx_close_mailbox (ctx, index_hint);
   sidebar_set_buffystats (ctx);
-  return (ret);
+  return ret;
 }
 
 /* update a Context structure's internal tables. */
@@ -955,7 +735,7 @@ static int _mx_sync_mailbox (CONTEXT * ctx, int *index_hint)
   if (!ctx->changed && !ctx->deleted) {
     mutt_message _("Mailbox is unchanged.");
 
-    return (0);
+    return 0;
   }
 
   if (ctx->deleted) {
@@ -965,7 +745,7 @@ static int _mx_sync_mailbox (CONTEXT * ctx, int *index_hint)
               ? _("Purge %d deleted message?") :
               _("Purge %d deleted messages?"), ctx->deleted);
     if ((purge = query_quadoption (OPT_DELETE, buf)) < 0)
-      return (-1);
+      return -1;
     else if (purge == M_NO) {
       if (!ctx->changed)
         return 0;               /* nothing to do! */
@@ -998,20 +778,11 @@ static int _mx_sync_mailbox (CONTEXT * ctx, int *index_hint)
   if (rc == 0) {
     if (ctx->magic == M_IMAP && !purge)
       mutt_message (_("Mailbox checkpointed."));
-
     else
       mutt_message (_("%d kept, %d deleted."), msgcount - deleted, deleted);
 
     mutt_sleep (0);
 
-    if (ctx->msgcount == ctx->deleted &&
-        (ctx->magic == M_MBOX || ctx->magic == M_MMDF) &&
-        !mutt_is_spool (ctx->path) && !option (OPTSAVEEMPTY)) {
-      unlink (ctx->path);
-      mx_fastclose_mailbox (ctx);
-      return 0;
-    }
-
     /* if we haven't deleted any messages, we don't need to resort */
     /* ... except for certain folder formats which need "unsorted" 
      * sort order in order to synchronize folders.
@@ -1029,13 +800,13 @@ static int _mx_sync_mailbox (CONTEXT * ctx, int *index_hint)
     }
   }
 
-  return (rc);
+  return rc;
 }
 
 int mx_sync_mailbox (CONTEXT* ctx, int* index_hint) {
   int ret = _mx_sync_mailbox (ctx, index_hint);
   sidebar_set_buffystats (ctx);
-  return (ret);
+  return ret;
 }
 
 /* args:
@@ -1045,11 +816,12 @@ int mx_sync_mailbox (CONTEXT* ctx, int* index_hint) {
  */
 MESSAGE *mx_open_new_message (CONTEXT * dest, HEADER * hdr, int flags)
 {
+
   MESSAGE *msg;
   address_t *p = NULL;
 
   if (!MX_IDX(dest->magic-1)) {
-    return (NULL);
+    return NULL;
   }
 
   msg = p_new(MESSAGE, 1);
@@ -1067,10 +839,7 @@ MESSAGE *mx_open_new_message (CONTEXT * dest, HEADER * hdr, int flags)
     time (&msg->received);
 
   if (mxfmts[dest->magic-1]->mx_open_new_message(msg, dest, hdr) == 0) {
-    if (dest->magic == M_MMDF)
-      fputs (MMDF_SEP, msg->fp);
-
-    if ((msg->magic == M_MBOX || msg->magic == M_MMDF) && flags & M_ADD_FROM) {
+    if (msg->magic == M_MBOX && flags & M_ADD_FROM) {
       if (hdr) {
         if (hdr->env->return_path)
           p = hdr->env->return_path;
@@ -1080,7 +849,7 @@ MESSAGE *mx_open_new_message (CONTEXT * dest, HEADER * hdr, int flags)
           p = hdr->env->from;
       }
 
-      fprintf (msg->fp, "From %s %s", p ? p->mailbox : NONULL(MCore.username),
+      fprintf (msg->fp, "From %s %s", p ? p->mailbox : NONULL(mod_core.username),
                ctime (&msg->received));
     }
   }
@@ -1099,71 +868,25 @@ int mx_check_mailbox (CONTEXT * ctx, int *index_hint, int lock) {
     if (ctx->locked)
       lock = 0;
     if (MX_IDX(ctx->magic-1) && mxfmts[ctx->magic-1]->mx_check_mailbox)
-      return (mxfmts[ctx->magic-1]->mx_check_mailbox(ctx, index_hint, lock));
+      return mxfmts[ctx->magic-1]->mx_check_mailbox(ctx, index_hint, lock);
   }
 
-  return (-1);
+  return -1;
 }
 
 /* return a stream pointer for a message */
 MESSAGE *mx_open_message (CONTEXT * ctx, int msgno)
 {
-  MESSAGE *msg;
-
-  msg = p_new(MESSAGE, 1);
-  switch (msg->magic = ctx->magic) {
-  case M_MBOX:
-  case M_MMDF:
-    msg->fp = ctx->fp;
-    break;
-
-  case M_MH:
-  case M_MAILDIR:
-    {
-      HEADER *cur = ctx->hdrs[msgno];
-      char path[_POSIX_PATH_MAX];
-
-      snprintf (path, sizeof (path), "%s/%s", ctx->path, cur->path);
-
-      if ((msg->fp = fopen (path, "r")) == NULL && errno == ENOENT &&
-          ctx->magic == M_MAILDIR)
-        msg->fp = maildir_open_find_message (ctx->path, cur->path);
-
-      if (msg->fp == NULL) {
-        mutt_perror (path);
-        p_delete(&msg);
-      }
-    }
-    break;
+    MESSAGE *msg;
 
-  case M_IMAP:
-    {
-      if (imap_fetch_message (msg, ctx, msgno) != 0)
-        p_delete(&msg);
-      break;
-    }
-
-  case M_POP:
-    {
-      if (pop_fetch_message (msg, ctx, msgno) != 0)
-        p_delete(&msg);
-      break;
-    }
+    if (!MX_IDX(ctx->magic) || !mxfmts[ctx->magic - 1]->mx_open_message)
+        return NULL;
 
-#ifdef USE_NNTP
-  case M_NNTP:
-    {
-      if (nntp_fetch_message (msg, ctx, msgno) != 0)
+    msg = p_new(MESSAGE, 1);
+    msg->magic = ctx->magic;
+    if (mxfmts[ctx->magic - 1]->mx_open_message(msg, ctx, msgno))
         p_delete(&msg);
-      break;
-    }
-#endif /* USE_NNTP */
-
-  default:
-    p_delete(&msg);
-    break;
-  }
-  return (msg);
+    return msg;
 }
 
 /* commit a message to a folder */
@@ -1173,8 +896,8 @@ int mx_commit_message (MESSAGE * msg, CONTEXT * ctx) {
     return -1;
   }
   if (!ctx || !MX_IDX(ctx->magic-1) || !mxfmts[ctx->magic-1]->mx_commit_message)
-    return (-1);
-  return (mxfmts[ctx->magic-1]->mx_commit_message (msg, ctx));
+    return -1;
+  return mxfmts[ctx->magic-1]->mx_commit_message (msg, ctx);
 }
 
 /* close a pointer to a message */
@@ -1183,12 +906,8 @@ int mx_close_message (MESSAGE ** msg)
   int r = 0;
 
   if ((*msg)->magic == M_MH || (*msg)->magic == M_MAILDIR
-      || (*msg)->magic == M_IMAP
-      || (*msg)->magic == M_POP
-#ifdef USE_NNTP
-      || (*msg)->magic == M_NNTP
-#endif
-    ) {
+  ||  (*msg)->magic == M_IMAP || (*msg)->magic == M_POP)
+  {
     r = m_fclose(&(*msg)->fp);
   }
   else
@@ -1200,33 +919,17 @@ int mx_close_message (MESSAGE ** msg)
   }
 
   p_delete(msg);
-  return (r);
+  return r;
 }
 
 void mx_alloc_memory (CONTEXT * ctx)
 {
-  int i;
-  size_t s = MAX (sizeof (HEADER *), sizeof (int));
+    ctx->hdrmax += 32;
 
-  if ((ctx->hdrmax + 25) * s < ctx->hdrmax * s) {
-    mutt_error _("Integer overflow -- can't allocate memory.");
-
-    sleep (1);
-    mutt_exit (1);
-  }
-
-  if (ctx->hdrs) {
-    p_realloc(&ctx->hdrs, ctx->hdrmax += 25);
+    p_realloc(&ctx->hdrs, ctx->hdrmax);
     p_realloc(&ctx->v2r, ctx->hdrmax);
-  }
-  else {
-    ctx->hdrs = p_new(HEADER *, (ctx->hdrmax += 25));
-    ctx->v2r = p_new(int, ctx->hdrmax);
-  }
-  for (i = ctx->msgcount; i < ctx->hdrmax; i++) {
-    ctx->hdrs[i] = NULL;
-    ctx->v2r[i] = -1;
-  }
+    p_clear(ctx->hdrs + ctx->msgcount, ctx->hdrmax - ctx->msgcount);
+    p_clear(ctx->v2r + ctx->msgcount, ctx->hdrmax - ctx->msgcount);
 }
 
 /* this routine is called to update the counts in the context structure for
@@ -1262,7 +965,7 @@ void mx_update_context (CONTEXT * ctx, int new_messages)
       /* p_delete(&h->env->supersedes); should I ? */
       if (h2) {
         h2->superseded = 1;
-        if (!ctx->counting && option (OPTSCORE))
+        if (!ctx->counting && mod_score.enable)
           mutt_score_message (ctx, h2, 1);
       }
     }
@@ -1274,7 +977,7 @@ void mx_update_context (CONTEXT * ctx, int new_messages)
       if (ctx->subj_hash && h->env->real_subj)
         hash_insert (ctx->subj_hash, h->env->real_subj, h);
 
-      if (option (OPTSCORE))
+      if (mod_score.enable)
         mutt_score_message (ctx, h, 0);
     }
 
@@ -1304,54 +1007,16 @@ int mx_check_empty (const char *path)
 {
   int i = 0;
   if ((i = mx_get_idx (path)) >= 0 && mxfmts[i]->mx_check_empty)
-    return (mxfmts[i]->mx_check_empty(path));
+    return mxfmts[i]->mx_check_empty(path);
   errno = EINVAL;
-  return (-1);
+  return -1;
 }
 
-int mx_acl_check (CONTEXT* ctx, int flag) {
-  if (!ctx || !MX_IDX(ctx->magic-1))
-    return (0);
-  /* if no acl_check defined for module, assume permission is granted */
-  if (!mxfmts[ctx->magic-1]->mx_acl_check)
-    return (1);
-  return (mxfmts[ctx->magic-1]->mx_acl_check(ctx,flag));
-}
-
-int mx_rebuild_cache (void) {
-#ifndef USE_HCACHE
-  mutt_error (_("Support for header caching was not build in."));
-  return (1);
-#else
-  int i = 0, magic = 0;
-  CONTEXT* ctx = NULL;
-  BUFFY* b = NULL;
-
-  if (!Incoming.len) {
-    mutt_error (_("No mailboxes defined."));
-    return (1);
-  }
-
-  for (i = 0; i < Incoming.len; i++) {
-    b = Incoming.arr[i];
-    magic = mx_get_magic (b->path);
-    if (magic != M_MAILDIR && magic != M_MH && magic != M_IMAP)
-      continue;
-    sidebar_set_current (b->path);
-    sidebar_draw ();
-    if ((ctx = mx_open_mailbox (b->path,
-                                M_READONLY | M_NOSORT | M_COUNT,
-                                NULL)) != NULL)
-      mx_close_mailbox (ctx, 0);
-  }
-  mutt_clear_error ();
-
-  if (Context && Context->path)
-    sidebar_set_current (Context->path);
-  sidebar_draw ();
-
-  return (0);
-#endif
+int mx_acl_check(CONTEXT *ctx, int flag)
+{
+    if (!mxfmts[ctx->magic-1]->mx_acl_check)
+        return 1;
+    return mxfmts[ctx->magic-1]->mx_acl_check(ctx,flag);
 }
 
 void mutt_parse_mime_message (CONTEXT * ctx, HEADER * cur)