X-Git-Url: http://git.madism.org/?p=apps%2Fmadmutt.git;a=blobdiff_plain;f=mbox.c;h=442a4064d53f0c3d05eb579d86e21cb712d2f983;hp=c3dc0fd185cb1c93a5e6684d7b43e392f7564052;hb=676b896e26b7aeef16d95aba7a5ea9322d2dc6e1;hpb=6771688a116512f5fc5ce0844dc5987a22c2e0f6 diff --git a/mbox.c b/mbox.c index c3dc0fd..442a406 100644 --- a/mbox.c +++ b/mbox.c @@ -9,14 +9,10 @@ /* This file contains code to parse ``mbox'' and ``mmdf'' style mailboxes */ -#if HAVE_CONFIG_H -# include "config.h" -#endif +#include -#include -#include -#include -#include +#include +#include #include "mutt.h" #include "mx.h" @@ -27,17 +23,6 @@ #include "copy.h" #include "compress.h" -#include "lib/debug.h" - -#include -#include -#include -#include -#include -#include -#include -#include - /* struct used by mutt_sync_mailbox() to store new offsets */ struct m_update_t { short valid; @@ -48,7 +33,7 @@ struct m_update_t { }; -static int mbox_open_new_message (MESSAGE * msg, CONTEXT * dest, HEADER * hdr) +static int mbox_open_new_message (MESSAGE * msg, CONTEXT * dest, HEADER * hdr __attribute__ ((unused))) { msg->fp = dest->fp; return 0; @@ -76,7 +61,7 @@ int mbox_lock_mailbox (CONTEXT * ctx, int excl, int retry) return (r); } -void mbox_unlock_mailbox (CONTEXT * ctx) +static void mbox_unlock_mailbox (CONTEXT * ctx) { if (ctx->locked) { fflush (ctx->fp); @@ -125,13 +110,12 @@ static int mmdf_parse_mailbox (CONTEXT * ctx) if (ctx->msgcount == ctx->hdrmax) mx_alloc_memory (ctx); - ctx->hdrs[ctx->msgcount] = hdr = mutt_new_header (); + ctx->hdrs[ctx->msgcount] = hdr = header_new(); hdr->offset = loc; hdr->index = ctx->msgcount; if (fgets (buf, sizeof (buf) - 1, ctx->fp) == NULL) { /* TODO: memory leak??? */ - debug_print (1, ("unexpected EOF\n")); break; } @@ -139,7 +123,6 @@ static int mmdf_parse_mailbox (CONTEXT * ctx) if (!is_from (buf, return_path, sizeof (return_path), &t)) { if (fseeko (ctx->fp, loc, SEEK_SET) != 0) { - debug_print (1, ("fseeko() failed\n")); mutt_error _("Mailbox is corrupt!"); return (-1); @@ -159,8 +142,7 @@ static int mmdf_parse_mailbox (CONTEXT * ctx) if (fseeko (ctx->fp, tmploc, SEEK_SET) != 0 || fgets (buf, sizeof (buf) - 1, ctx->fp) == NULL || m_strcmp(MMDF_SEP, buf) != 0) { - if (fseeko (ctx->fp, loc, SEEK_SET) != 0) - debug_print (1, ("fseeko() failed\n")); + fseeko (ctx->fp, loc, SEEK_SET); hdr->content->length = -1; } } @@ -193,7 +175,6 @@ static int mmdf_parse_mailbox (CONTEXT * ctx) ctx->msgcount++; } else { - debug_print (1, ("corrupt mailbox!\n")); mutt_error _("Mailbox is corrupt!"); return (-1); @@ -262,7 +243,7 @@ static int mbox_parse_mailbox (CONTEXT * ctx) if (ctx->msgcount == ctx->hdrmax) mx_alloc_memory (ctx); - curhdr = ctx->hdrs[ctx->msgcount] = mutt_new_header (); + curhdr = ctx->hdrs[ctx->msgcount] = header_new(); curhdr->received = t - tz; curhdr->offset = loc; curhdr->index = ctx->msgcount; @@ -287,12 +268,7 @@ static int mbox_parse_mailbox (CONTEXT * ctx) if (fseeko (ctx->fp, tmploc, SEEK_SET) != 0 || fgets (buf, sizeof (buf), ctx->fp) == NULL || m_strncmp("From ", buf, 5) != 0) { - debug_print (1, ("bad content-length in message %d (cl=%zd)\n", - curhdr->index, curhdr->content->length)); - debug_print (1, ("LINE: %s\n", buf)); - if (fseeko (ctx->fp, loc, SEEK_SET) != 0) { /* nope, return the previous position */ - debug_print (1, ("fseeko() failed\n")); - } + fseeko (ctx->fp, loc, SEEK_SET); /* nope, return the previous position */ curhdr->content->length = -1; } } @@ -311,8 +287,7 @@ static int mbox_parse_mailbox (CONTEXT * ctx) int cl = curhdr->content->length; /* count the number of lines in this message */ - if (fseeko (ctx->fp, loc, SEEK_SET) != 0) - debug_print (1, ("fseeko() failed\n")); + fseeko (ctx->fp, loc, SEEK_SET); while (cl-- > 0) { if (fgetc (ctx->fp) == '\n') curhdr->lines++; @@ -320,8 +295,7 @@ static int mbox_parse_mailbox (CONTEXT * ctx) } /* return to the offset of the next message separator */ - if (fseeko (ctx->fp, tmploc, SEEK_SET) != 0) - debug_print (1, ("fseeko() failed\n")); + fseeko(ctx->fp, tmploc, SEEK_SET); } } @@ -440,13 +414,11 @@ static int _mbox_check_mailbox (CONTEXT * ctx, int *index_hint) * see the message separator at *exactly* what used to be the end of the * folder. */ - if (fseeko (ctx->fp, ctx->size, SEEK_SET) != 0) - debug_print (1, ("fseeko() failed\n")); + fseeko (ctx->fp, ctx->size, SEEK_SET); if (fgets (buffer, sizeof (buffer), ctx->fp) != NULL) { if ((ctx->magic == M_MBOX && m_strncmp("From ", buffer, 5) == 0) || (ctx->magic == M_MMDF && m_strcmp(MMDF_SEP, buffer) == 0)) { - if (fseeko (ctx->fp, ctx->size, SEEK_SET) != 0) - debug_print (1, ("fseeko() failed\n")); + fseeko (ctx->fp, ctx->size, SEEK_SET); if (ctx->magic == M_MBOX) mbox_parse_mailbox (ctx); else @@ -466,14 +438,12 @@ static int _mbox_check_mailbox (CONTEXT * ctx, int *index_hint) } else modified = 1; - } - else { - debug_print (1, ("fgets returned NULL.\n")); + } else { modified = 1; } - } - else + } else { modified = 1; + } } if (modified) { @@ -520,7 +490,7 @@ static int mbox_check_mailbox (CONTEXT* ctx, int* index_hint, int lock) { * 0 success * -1 failure */ -static int _mbox_sync_mailbox (CONTEXT * ctx, int unused, int *index_hint) +static int _mbox_sync_mailbox (CONTEXT * ctx, int unused __attribute__ ((unused)), int *index_hint) { char tempfile[_POSIX_PATH_MAX]; char buf[32]; @@ -602,7 +572,6 @@ static int _mbox_sync_mailbox (CONTEXT * ctx, int unused, int *index_hint) mutt_error _("sync: mbox modified, but no modified messages! (report this bug)"); mutt_sleep (5); /* the mutt_error /will/ get cleared! */ - debug_print (1, ("no modified messages.\n")); unlink (tempfile); goto bail; } @@ -673,7 +642,7 @@ static int _mbox_sync_mailbox (CONTEXT * ctx, int unused, int *index_hint) */ newOffset[i - first].body = ftello (fp) - ctx->hdrs[i]->content->length + offset; - mutt_free_body (&ctx->hdrs[i]->content->parts); + body_list_wipe(&ctx->hdrs[i]->content->parts); switch (ctx->magic) { case M_MMDF: @@ -697,7 +666,6 @@ static int _mbox_sync_mailbox (CONTEXT * ctx, int unused, int *index_hint) if (fclose (fp) != 0) { fp = NULL; - debug_print (1, ("fclose() returned non-zero.\n")); unlink (tempfile); mutt_perror (tempfile); mutt_sleep (5); @@ -716,7 +684,6 @@ static int _mbox_sync_mailbox (CONTEXT * ctx, int unused, int *index_hint) if ((fp = fopen (tempfile, "r")) == NULL) { mutt_unblock_signals (); mx_fastclose_mailbox (ctx); - debug_print (1, ("unable to reopen temp copy of mailbox!\n")); mutt_perror (tempfile); mutt_sleep (5); return (-1); @@ -727,16 +694,12 @@ static int _mbox_sync_mailbox (CONTEXT * ctx, int unused, int *index_hint) fgets (buf, sizeof (buf), ctx->fp) == NULL || (ctx->magic == M_MBOX && m_strncmp("From ", buf, 5) != 0) || (ctx->magic == M_MMDF && m_strcmp(MMDF_SEP, buf) != 0)) { - debug_print (1, ("message not in expected position.\n")); - debug_print (1, ("LINE: %s\n", buf)); i = -1; } else { if (fseeko (ctx->fp, offset, SEEK_SET) != 0) { /* return to proper offset */ i = -1; - debug_print (1, ("fseeko() failed\n")); - } - else { + } else { /* copy the temp mailbox back into place starting at the first * change/deleted message */ @@ -906,7 +869,7 @@ static int mbox_reopen_mailbox (CONTEXT * ctx, int *index_hint) p_delete(&ctx->v2r); if (ctx->readonly) { for (i = 0; i < ctx->msgcount; i++) - mutt_free_header (&(ctx->hdrs[i])); /* nothing to do! */ + header_delete(&(ctx->hdrs[i])); /* nothing to do! */ p_delete(&ctx->hdrs); } else { @@ -932,7 +895,6 @@ static int mbox_reopen_mailbox (CONTEXT * ctx, int *index_hint) case M_MBOX: case M_MMDF: if (fseeko (ctx->fp, 0, SEEK_SET) != 0) { - debug_print (1, ("fseeko() failed\n")); rc = -1; } else { @@ -952,7 +914,7 @@ static int mbox_reopen_mailbox (CONTEXT * ctx, int *index_hint) if (rc == -1) { /* free the old headers */ for (j = 0; j < old_msgcount; j++) - mutt_free_header (&(old_hdrs[j])); + header_delete(&(old_hdrs[j])); p_delete(&old_hdrs); ctx->quiet = 0; @@ -1010,14 +972,14 @@ static int mbox_reopen_mailbox (CONTEXT * ctx, int *index_hint) mutt_set_flag (ctx, ctx->hdrs[i], M_TAG, old_hdrs[j]->tagged); /* we don't need this header any more */ - mutt_free_header (&(old_hdrs[j])); + header_delete(&(old_hdrs[j])); } } /* free the remaining old headers */ for (j = 0; j < old_msgcount; j++) { if (old_hdrs[j]) { - mutt_free_header (&(old_hdrs[j])); + header_delete(&(old_hdrs[j])); msg_mod = 1; } } @@ -1089,7 +1051,7 @@ int mbox_is_magic (const char* path, struct stat* st) { return (magic); } -static int commit_message (MESSAGE* msg, CONTEXT* ctx, int mbox) { +static int commit_message (MESSAGE* msg, CONTEXT* ctx __attribute__ ((unused)), int mbox) { if ((mbox && fputc ('\n', msg->fp) == EOF) || (!mbox && fputs (MMDF_SEP, msg->fp) == EOF)) return (-1);