X-Git-Url: http://git.madism.org/?p=apps%2Fmadmutt.git;a=blobdiff_plain;f=nntp.c;h=4e79ffc2a0f8449261270391b08834d5ffc9a47e;hp=9319c38ce48e8876f68113de5b9683ed0452bffa;hb=b8e3053577ab5d351882096830421cd55639cc97;hpb=7768c028980b5fb468decf4fbfbd640082c321b2

diff --git a/nntp.c b/nntp.c
index 9319c38..4e79ffc 100644
--- a/nntp.c
+++ b/nntp.c
@@ -27,27 +27,50 @@
 #define NNTP_PORT      119
 #define NNTP_SSL_PORT  563
 
-static unsigned int _checked = 0;
+static struct {
+    unsigned use_cache : 1;
+
+    int  checked;
+} nntp = { true, 0 };
 
 static int nntp_check_newgroups (nntp_server_t *, int);
 
+static void nntp_free_acache(nntp_data_t * data)
+{
+    for (int i = 0; i < countof(data->acache); i++) {
+        if (data->acache[i].path) {
+            unlink(data->acache[i].path);
+            p_delete(&data->acache[i].path);
+        }
+    }
+}
+
+void nntp_data_wipe(nntp_data_t *data)
+{
+    p_delete(&data->entries);
+    p_delete(&data->desc);
+    p_delete(&data->cache);
+    p_delete(&data->group);
+    nntp_free_acache(data);
+}
+
 /* newsrc {{{ */
 
 static void mutt_newsgroup_stat(nntp_data_t *data)
 {
     data->unread = 0;
-    if (data->lastMessage == 0 || data->firstMessage > data->lastMessage)
+    if (data->last == 0 || data->first > data->last)
         return;
 
-    data->unread = data->lastMessage - data->firstMessage + 1;
+    data->unread = data->last - data->first + 1;
     for (int i = 0; i < data->num; i++) {
-        int first = MAX(data->entries[i].first, data->firstMessage);
-        int last  = MIN(data->entries[i].last,  data->lastMessage);
+        int first = MAX(data->entries[i].first, data->first);
+        int last  = MIN(data->entries[i].last,  data->last);
         data->unread -= MAX(0, last - first + 1);
     }
 }
 
-static int nntp_parse_newsrc_line(nntp_server_t * news, const char *line)
+static int nntp_parse_newsrc_line(nntp_server_t *news, const char *line)
 {
     nntp_data_t *data;
     char group[LONG_STRING];
@@ -69,10 +92,8 @@ static int nntp_parse_newsrc_line(nntp_server_t * news, const char *line)
         data->group = p_dupstr(line, p - line);
         data->nserv = news;
         data->deleted = 1;
-        if (news->newsgroups->nelem < news->newsgroups->curnelem * 2)
-            hash_resize (news->newsgroups, news->newsgroups->nelem * 2);
         hash_insert(news->newsgroups, data->group, data);
-        nntp_data_list_append(&news->list, data);
+        news->tail = nntp_data_list_append(news->tail, data);
     } else {
         p_delete(&data->entries);
     }
@@ -81,23 +102,24 @@ static int nntp_parse_newsrc_line(nntp_server_t * news, const char *line)
     data->entries = p_new(NEWSRC_ENTRY, x * 2);
     data->max = x * 2;
     data->subscribed = (*p++ == ':');
+    p = skipspaces(p);
 
     for (x = 0; *p; p++) {
-        p = skipspaces(p);
         data->entries[x].first = strtol(p, (char **)&p, 10);
-        p = skipspaces(p);
+        p += strcspn(p, "-,");
         if (*p == '-') {
+            if (!*p)
+                break;
             data->entries[x].last = strtol(p + 1, (char **)&p, 10);
         } else {
             data->entries[x].last = data->entries[x].first;
+            p = strchrnul(p, ',');
         }
-
-        p  = strchrnul(p, ',');
         x += data->entries[x].last != 0;
     }
 
-    if (x && !data->lastMessage)
-        data->lastMessage = data->entries[x - 1].last;
+    if (x && !data->last)
+        data->last = data->entries[x - 1].last;
     data->num = x;
     mutt_newsgroup_stat(data);
     return 0;
@@ -105,266 +127,212 @@ static int nntp_parse_newsrc_line(nntp_server_t * news, const char *line)
 
 static int slurp_newsrc (nntp_server_t * news)
 {
-  FILE *fp;
-  char *buf;
-  struct stat sb;
+    FILE *fp;
+    char *buf = NULL;
+    size_t n  = 0;
+    struct stat sb;
 
-  news->stat = stat (news->newsrc, &sb);
-  news->size = sb.st_size;
-  news->mtime = sb.st_mtime;
+    news->stat  = stat(news->newsrc, &sb);
+    news->size  = sb.st_size;
+    news->mtime = sb.st_mtime;
 
-  if ((fp = safe_fopen (news->newsrc, "r")) == NULL)
-    return -1;
-  /* hmm, should we use dotlock? */
-  if (mx_lock_file (news->newsrc, fileno (fp), 0, 0, 1)) {
-    m_fclose(&fp);
-    return -1;
-  }
+    if ((fp = safe_fopen(news->newsrc, "r")) == NULL)
+        return -1;
 
-  buf = p_new(char, sb.st_size + 1);
-  while (fgets(buf, sb.st_size + 1, fp))
-    nntp_parse_newsrc_line(news, buf);
-  p_delete(&buf);
+    /* hmm, should we use dotlock? */
+    if (mx_lock_file(news->newsrc, fileno (fp), 0, 0, 1)) {
+        m_fclose(&fp);
+        return -1;
+    }
 
-  mx_unlock_file (news->newsrc, fileno (fp), 0);
-  m_fclose(&fp);
-  return 0;
-}
+    while (getline(&buf, &n, fp) >= 0) {
+        nntp_parse_newsrc_line(news, buf);
+    }
+    p_delete(&buf);
 
-static void nntp_cache_expand (char *dst, const char *src)
-{
-  snprintf (dst, _POSIX_PATH_MAX, "%s/%s", NewsCacheDir, src);
-  mutt_expand_path (dst, _POSIX_PATH_MAX);
+    mx_unlock_file (news->newsrc, fileno (fp), 0);
+    m_fclose(&fp);
+    return 0;
 }
 
+#define nntp_cache_expand(dst, dlen, fmt, ...)     \
+    do {                                                                     \
+        snprintf((dst), (dlen), "%s/" fmt, mod_core.cachedir, ##__VA_ARGS__);\
+        mutt_expand_path((dst), (dlen));                                     \
+    } while (0)
+
 /* Loads $news_cache_dir/.index into memory, loads newsserver data
  * and newsgroup cache names */
-static int nntp_parse_cacheindex (nntp_server_t * news)
+static int nntp_parse_cacheindex(nntp_server_t *news)
 {
-  struct stat st;
-  char buf[HUGE_STRING], *cp;
-  char dir[_POSIX_PATH_MAX], file[_POSIX_PATH_MAX];
-  FILE *idx;
-  nntp_data_t *data;
-  int l, m, t;
-
-  /* check is server name defined or not */
-  if (!news || !news->conn || !news->conn->account.host)
-    return -1;
-  unset_option (OPTNEWSCACHE);
-  if (m_strisempty(NewsCacheDir))
-    return 0;
+    char buf[HUGE_STRING];
+    FILE *idx;
+
+    p_delete(&news->cache);
+    if (m_strisempty(mod_core.cachedir))
+        return 0;
+
+    nntp_cache_expand(buf, sizeof(buf), "%s.index", news->conn->account.host);
+    if (!(idx = safe_fopen(buf, "a+")))
+        return 0;
+    rewind(idx);
+
+    while (fgets(buf, sizeof(buf), idx)) {
+        buf[m_strlen(buf) - 1] = 0;  /* strip ending '\n' */
+        if (!m_strncmp(buf, "#: ", 3)
+        &&  !m_strcasecmp(buf + 3, news->conn->account.host)) {
+            break;
+        }
+    }
 
-  m_strcpy(dir, sizeof(dir), NewsCacheDir);
-  mutt_expand_path (dir, sizeof (dir));
+    while (fgets(buf, sizeof(buf), idx)) {
+        char *p, *q;
+        int l, m, t;
 
-  if (lstat (dir, &st) || (st.st_mode & S_IFDIR) == 0) {
-    snprintf (buf, sizeof (buf), _("Directory %s not exist. Create it?"),
-              dir);
-    if (mutt_yesorno (buf, M_YES) != M_YES
-        || mkdir (dir, (S_IRWXU + S_IRWXG + S_IRWXO))) {
-      mutt_error _("Cache directory not created!");
+        if (m_strstart(buf, "#:", NULL))
+            break;
 
-      return -1;
-    }
-    mutt_clear_error ();
-  }
+        p = strchrnul(buf, ' ');
+        if (!*p)
+            continue;
+        *p++ = '\0';
+        p = vskipspaces(p);
+        q = strchrnul(p, ' ');
+        if (!*q)
+            continue;
+        *q++ = '\0';
+        l = strtol(q, &q, 10);
+        m = strtol(q, &q, 10);
 
-  set_option (OPTNEWSCACHE);
+        if (!m_strcmp(buf, "ALL")) {
+            m_strreplace(&news->cache, m_strdup(p));
+            news->newgroups_time = m;
+            continue;
+        }
 
-  p_delete(&news->cache);
-  snprintf (buf, sizeof (buf), "%s/.index", dir);
-  if (!(idx = safe_fopen (buf, "a+")))
-    return 0;
-  rewind (idx);
-  while (fgets (buf, sizeof (buf), idx)) {
-    buf[m_strlen(buf) - 1] = 0;  /* strip ending '\n' */
-    if (!m_strncmp(buf, "#: ", 3) &&
-        !m_strcasecmp(buf + 3, news->conn->account.host))
-      break;
-  }
-  while (fgets (buf, sizeof (buf), idx)) {
-    cp = buf;
-    while (*cp && *cp != ' ')
-      cp++;
-    if (!*cp)
-      continue;
-    cp[0] = 0;
-    if (!m_strcmp(buf, "#:"))
-      break;
-    sscanf (cp + 1, "%s %d %d", file, &l, &m);
-    if (!m_strcmp(buf, "ALL")) {
-      news->cache = m_strdup(file);
-      news->newgroups_time = m;
-    }
-    else if (news->newsgroups) {
-      if ((data = hash_find (news->newsgroups, buf)) == NULL) {
-        data = nntp_data_new();
-        data->group = m_strdup(buf);
-        data->nserv = news;
-        data->deleted = 1;
-        if (news->newsgroups->nelem < news->newsgroups->curnelem * 2)
-            hash_resize (news->newsgroups, news->newsgroups->nelem * 2);
-        hash_insert (news->newsgroups, data->group, data);
-        nntp_data_list_append(&news->list, data);
-      }
-      data->cache = m_strdup(file);
-      t = 0;
-      if (!data->firstMessage || data->lastMessage < m)
-        t = 1;
-      if (!data->firstMessage)
-        data->firstMessage = l;
-      if (data->lastMessage < m)
-        data->lastMessage = m;
-      data->lastCached = m;
-      if (t || !data->unread)
-        mutt_newsgroup_stat (data);
+        if (news->newsgroups) {
+            nntp_data_t *data = hash_find(news->newsgroups, buf);
+
+            if (!data) {
+                data = nntp_data_new();
+                data->group = m_strdup(buf);
+                data->nserv = news;
+                data->deleted = 1;
+                hash_insert (news->newsgroups, data->group, data);
+                news->tail = nntp_data_list_append(news->tail, data);
+            }
+            m_strreplace(&data->cache, p);
+
+            t = !data->first || data->last < m;
+            if (!data->first)
+                data->first = l;
+            if (data->last < m)
+                data->last = m;
+            data->lastCached = m;
+            if (t || !data->unread)
+                mutt_newsgroup_stat(data);
+        }
     }
-  }
-  m_fclose(&idx);
-  return 0;
-}
 
-const char *nntp_format_str(char *dest, ssize_t destlen, char op,
-                            const char *src, const char *fmt,
-                            const char *ifstr __attribute__((unused)),
-                            const char *elstr __attribute__((unused)),
-                            anytype data __attribute__((unused)),
-                            format_flag flags __attribute__((unused)))
-{
-  char fn[STRING], tmp[STRING];
-
-  switch (op) {
-  case 's':
-    m_strcpy(fn, sizeof (fn), NewsServer);
-    m_strtolower(fn);
-    snprintf (tmp, sizeof (tmp), "%%%ss", fmt);
-    snprintf (dest, destlen, tmp, fn);
-    break;
-  }
-  return (src);
+    m_fclose(&idx);
+    return 0;
 }
 
 /* nntp_parse_url: given an NNPT URL, return host, port,
  * username, password and newsgroup will recognise. */
-static int nntp_parse_url(const char *server, ACCOUNT * act, char *group,
+static int nntp_parse_url(const char *server, ACCOUNT *act, char *group,
                           ssize_t group_len)
 {
-  ciss_url_t url;
-  char *c;
-  int ret = -1;
+    ciss_url_t url;
+    char s[STRING];
 
-  /* Defaults */
-  act->flags = 0;
-  act->port = NNTP_PORT;
-  act->type = M_ACCT_TYPE_NNTP;
+    act->flags = 0;
+    act->port  = 0;
+    act->type  = M_ACCT_TYPE_NNTP;
 
-  c = m_strdup(server);
-  url_parse_ciss (&url, c);
+    m_strcpy(s, sizeof(s), server);
+    url_parse_ciss(&url, s);
 
-  if (url.scheme == U_NNTP || url.scheme == U_NNTPS) {
-    if (url.scheme == U_NNTPS) {
-      act->has_ssl = 1;
-      act->port = NNTP_SSL_PORT;
-    }
-
-    *group = '\0';
-    if (url.path)
-      m_strcpy(group, group_len, url.path);
+    if (url.scheme != U_NNTP && url.scheme != U_NNTPS)
+        return -1;
 
-    ret = mutt_account_fromurl (act, &url);
-  }
+    act->has_ssl = (url.scheme == U_NNTPS);
+    if (!act->port) {
+        act->port = act->has_ssl ? NNTP_SSL_PORT : NNTP_PORT;
+    }
+    m_strcpy(group, group_len, url.path);
 
-  p_delete(&c);
-  return ret;
+    return mutt_account_fromurl(act, &url);
 }
 
-void nntp_expand_path (char *line, ssize_t len, ACCOUNT * act)
+void nntp_expand_path(char *line, ssize_t len, ACCOUNT *act)
 {
-  ciss_url_t url;
+    ciss_url_t url = { .path = alloca(len) };
 
-  url.path = m_strdup(line);
-  mutt_account_tourl (act, &url);
-  url_ciss_tostring (&url, line, len, 0);
-  p_delete(&url.path);
+    m_strcpy(url.path, len, line);
+    mutt_account_tourl (act, &url);
+    url_ciss_tostring(&url, line, len, 0);
 }
 
-static int add_group (char *buf, void *serv)
+static int add_group(char *buf, void *serv)
 {
-  nntp_server_t *s = serv;
-  char group[LONG_STRING], mod, desc[HUGE_STRING];
-  int first, last;
-  nntp_data_t *nntp_data;
-  static int n = 0;
+    char mod, group[HUGE_STRING], desc[HUGE_STRING];
+    nntp_server_t *srv = serv;
+    nntp_data_t *data;
+    static int n = 0;
+    int first, last;
 
-  _checked = n;                 /* _checked have N, where N = number of groups */
-  if (!buf)                     /* at EOF must be zerouth */
-    n = 0;
+    nntp.checked = n;       /* nntp.checked have N, where N = number of groups */
+    if (!buf)               /* at EOF must be zerouth */
+        n = 0;
 
-  if (!s || !buf)
-    return 0;
+    if (!srv || !buf)
+        return 0;
 
-  *desc = 0;
-  sscanf (buf, "%s %d %d %c %[^\n]", group, &last, &first, &mod, desc);
-  if (!group)
-    return 0;
-  if ((nntp_data = hash_find(s->newsgroups, group)) == NULL) {
-    n++;
-    nntp_data = nntp_data_new();
-    nntp_data->group = m_strdup(group);
-    nntp_data->nserv = s;
-    if (s->newsgroups->nelem < s->newsgroups->curnelem * 2)
-      hash_resize (s->newsgroups, s->newsgroups->nelem * 2);
-    hash_insert(s->newsgroups, nntp_data->group, nntp_data);
-    nntp_data_list_append(&s->list, nntp_data);
-  }
-  nntp_data->deleted = 0;
-  nntp_data->firstMessage = first;
-  nntp_data->lastMessage = last;
-  if (mod == 'y')
-    nntp_data->allowed = 1;
-  else
-    nntp_data->allowed = 0;
-  if (nntp_data->desc)
-    p_delete(&nntp_data->desc);
-  if (*desc)
-    nntp_data->desc = m_strdup(desc);
-  if (nntp_data->rc || nntp_data->lastCached)
-    mutt_newsgroup_stat (nntp_data);
-  else if (nntp_data->lastMessage &&
-           nntp_data->firstMessage <= nntp_data->lastMessage)
-    nntp_data->unread = nntp_data->lastMessage - nntp_data->firstMessage + 1;
-  else
-    nntp_data->unread = 0;
+    *desc = '\0';
+    sscanf(buf, "%s %d %d %c %[^\n]", group, &last, &first, &mod, desc);
 
-  return 0;
+    if (!(data = hash_find(srv->newsgroups, group))) {
+        n++;
+        data = nntp_data_new();
+        data->group = m_strdup(group);
+        data->nserv = srv;
+        hash_insert(srv->newsgroups, data->group, data);
+        srv->tail = nntp_data_list_append(srv->tail, data);
+    }
+
+    data->deleted = 0;
+    data->first = first;
+    data->last  = last;
+    data->allowed = mod == 'y';
+    m_strreplace(&data->desc, desc);
+    mutt_newsgroup_stat(data);
+    return 0;
 }
 
-/* Load list of all newsgroups from cache ALL */
-static int nntp_get_cache_all (nntp_server_t * serv)
+static int nntp_get_cache_all(nntp_server_t * serv)
 {
-  char buf[HUGE_STRING];
-  FILE *f;
-
-  nntp_cache_expand (buf, serv->cache);
-  if ((f = safe_fopen (buf, "r"))) {
-    int i = 0;
-
-    while (fgets (buf, sizeof (buf), f) != NULL) {
-      if (ReadInc && (i % ReadInc == 0))
-        mutt_message (_("Loading list from cache... %d"), i);
-      add_group (buf, serv);
-      i++;
+    char buf[HUGE_STRING];
+    FILE *f;
+
+    nntp_cache_expand(buf, ssizeof(buf), "%s", serv->cache);
+    if ((f = fopen(buf, "r"))) {
+        int i = 0;
+
+        while (fgets(buf, sizeof(buf), f)) {
+            if (ReadInc && (i % ReadInc == 0))
+                mutt_message (_("Loading list from cache... %d"), i);
+            add_group(buf, serv);
+            i++;
+        }
+        add_group (NULL, NULL);
+        m_fclose(&f);
+        mutt_clear_error();
+        return 0;
     }
-    add_group (NULL, NULL);
-    m_fclose(&f);
-    mutt_clear_error ();
-    return 0;
-  }
-  else {
+
     p_delete(&serv->cache);
     return -1;
-  }
 }
 
 /*
@@ -388,9 +356,8 @@ nntp_server_t *mutt_select_newsserver (char *server)
 
   p_clear(&act, 1);
 
-  if (!server || !*server) {
+  if (m_strisempty(server)) {
     mutt_error _("No newsserver defined!");
-
     return NULL;
   }
 
@@ -401,7 +368,7 @@ nntp_server_t *mutt_select_newsserver (char *server)
   }
   strcpy (p, server);
 
-  if ((nntp_parse_url (buf, &act, file, sizeof (file))) < 0 || *file) {
+  if ((nntp_parse_url(buf, &act, file, sizeof(file))) < 0 || *file) {
     p_delete(&buf);
     mutt_error (_("%s is an invalid newsserver specification!"), server);
     return NULL;
@@ -412,41 +379,39 @@ nntp_server_t *mutt_select_newsserver (char *server)
   if (!conn)
     return NULL;
 
-  m_strformat(file, sizeof(file), 0, NewsRc, nntp_format_str, NULL, 0);
-  mutt_expand_path(file, sizeof(file));
-
+  nntp_cache_expand(file, sizeof(file), "%s.newsrc", conn->account.host);
   serv = (nntp_server_t *) conn->data;
   if (serv) {
     struct stat sb;
 
     /* externally modified? */
-    if (serv->stat != stat(file, &sb) || (!serv->stat &&
-                                           (serv->size != sb.st_size
-                                            || serv->mtime != sb.st_mtime)))
+    if (serv->stat != stat(file, &sb)
+    || (!serv->stat && (serv->size != sb.st_size
+                        || serv->mtime != sb.st_mtime)))
     {
       for (list = serv->list; list; list = list->next) {
         list->subscribed = list->rc = list->num = 0;
       }
-      slurp_newsrc (serv);
-      nntp_clear_cacheindex (serv);
+      slurp_newsrc(serv);
     }
 
     if (serv->status == NNTP_BYE)
       serv->status = NNTP_NONE;
-    nntp_check_newgroups (serv, 0);
+    nntp_check_newgroups(serv, 0);
     return serv;
   }
 
   /* New newsserver */
   serv = p_new(nntp_server_t, 1);
+  serv->tail = &serv->list;
   serv->conn = conn;
   serv->newsrc = m_strdup(file);
-  serv->newsgroups = hash_new(1009, false);
-  slurp_newsrc (serv);          /* load .newsrc */
-  nntp_parse_cacheindex (serv); /* load .index */
-  if (option (OPTNEWSCACHE) && serv->cache && nntp_get_cache_all (serv) >= 0)
+  serv->newsgroups = hash_new(SHRT_MAX, false);
+  slurp_newsrc(serv);          /* load .newsrc */
+  nntp_parse_cacheindex(serv); /* load .index */
+  if (nntp.use_cache && serv->cache && nntp_get_cache_all(serv) >= 0) {
     nntp_check_newgroups (serv, 1);
-  else if (nntp_get_active (serv) < 0) {
+  } else if (nntp_get_active(serv) < 0) {
     hash_delete(&serv->newsgroups, NULL);
     nntp_data_list_wipe(&serv->list);
     p_delete(&serv->newsrc);
@@ -454,9 +419,8 @@ nntp_server_t *mutt_select_newsserver (char *server)
     p_delete(&serv);
     return NULL;
   }
-  nntp_clear_cacheindex (serv);
-  conn->data = (void *) serv;
 
+  conn->data = serv;
   return serv;
 }
 
@@ -501,23 +465,6 @@ nntp_get_status(CONTEXT *ctx, HEADER *h, const char *group, int article)
         h->old = 1;
 }
 
-static void nntp_create_newsrc_line(nntp_data_t *data, buffer_t *buf)
-{
-    buffer_addstr(buf, data->group);
-    buffer_addch(buf, data->subscribed ? ':' : '!');
-    buffer_addch(buf, ' ');
-
-    for (int x = 0; x < data->num; x++) {
-        if (x) {
-            buffer_addch(buf, ',');
-        }
-
-        buffer_addf(buf, "%d-%d", data->entries[x].first,
-                    data->entries[x].last);
-    }
-    buffer_addch(buf, '\n');
-}
-
 static void newsrc_gen_entries (CONTEXT * ctx)
 {
   nntp_data_t *data = (nntp_data_t *) ctx->data;
@@ -550,7 +497,7 @@ static void newsrc_gen_entries (CONTEXT * ctx)
        * "missing" entries as read/deleted
        */
       last = ctx->hdrs[x]->article_num;
-      if (last >= data->firstMessage && !ctx->hdrs[x]->deleted &&
+      if (last >= data->first && !ctx->hdrs[x]->deleted &&
           !ctx->hdrs[x]->read) {
         if (data->num >= data->max) {
           data->max = data->max * 2;
@@ -713,8 +660,18 @@ int mutt_newsrc_update (nntp_server_t * news)
     for (data = news->list; data; data = data->next) {
         if (!data || !data->rc)
             continue;
-        nntp_create_newsrc_line(data, &buf);
+
+        buffer_addstr(&buf, data->group);
+        buffer_addch(&buf, data->subscribed ? ':' : '!');
+
+        for (int x = 0; x < data->num; x++) {
+            buffer_addch(&buf, x ? ',' : ' ');
+            buffer_addf(&buf, "%d-%d", data->entries[x].first,
+                        data->entries[x].last);
+        }
+        buffer_addch(&buf, '\n');
     }
+
     /* newrc being fully rewritten */
     if (news->newsrc
     &&  (r = mutt_update_list_file(news->newsrc, NULL, "", buf.data)) == 0)
@@ -736,11 +693,11 @@ static FILE *mutt_mkname (char *s)
   int fd;
   FILE *fp;
 
-  nntp_cache_expand (buf, s);
+  nntp_cache_expand(buf, ssizeof(buf), "%s", s);
   if ((fp = safe_fopen (buf, "w")))
     return fp;
 
-  nntp_cache_expand (buf, "cache-XXXXXX");
+  nntp_cache_expand(buf, ssizeof(buf), "cache-XXXXXX");
   pc = buf + m_strlen(buf) - 12; /* positioning to "cache-XXXXXX" */
   if ((fd = mkstemp (buf)) == -1)
     return NULL;
@@ -760,48 +717,32 @@ static int nntp_update_cacheindex (nntp_server_t * serv, nntp_data_t * data)
 
   if (data && data->group) {
     key = data->group;
-    snprintf (buf, sizeof (buf), "%s %s %d %d", key, data->cache,
-              data->firstMessage, data->lastLoaded);
-  }
-  else {
+    snprintf(buf, sizeof(buf), "%s %s %d %d", key, data->cache,
+             data->first, data->lastLoaded);
+  } else {
     m_strcpy(file, sizeof(file), serv->cache);
-    snprintf (buf, sizeof (buf), "ALL %s 0 %d", file,
-              (int) serv->newgroups_time);
+    snprintf(buf, sizeof (buf), "ALL %s 0 %d", file,
+             (int)serv->newgroups_time);
   }
-  nntp_cache_expand (file, ".index");
-  return mutt_update_list_file (file, serv->conn->account.host, key, buf);
+  nntp_cache_expand(file, ssizeof(file), "%s.index", serv->conn->account.host);
+  return mutt_update_list_file(file, serv->conn->account.host, key, buf);
 }
 
 static void nntp_delete_cache (nntp_data_t * data)
 {
   char buf[_POSIX_PATH_MAX];
 
-  if (!option (OPTNEWSCACHE) || !data || !data->cache || !data->nserv)
+  if (!nntp.use_cache || !data || !data->cache || !data->nserv)
     return;
 
-  nntp_cache_expand (buf, data->cache);
+  nntp_cache_expand(buf, ssizeof(buf), "%s", data->cache);
   unlink (buf);
   p_delete(&data->cache);
   data->lastCached = 0;
-  nntp_cache_expand (buf, ".index");
-  mutt_update_list_file (buf, data->nserv->conn->account.host, data->group,
-                         NULL);
-}
-
-/* Remove cache files of unsubscribed newsgroups */
-void nntp_clear_cacheindex (nntp_server_t * news)
-{
-  nntp_data_t *data;
-
-  if (option (OPTSAVEUNSUB) || !news)
-    return;
-
-  for (data = news->list; data; data = data->next) {
-    if (!data || data->subscribed || !data->cache)
-      continue;
-    nntp_delete_cache (data);
-  }
-  return;
+  nntp_cache_expand(buf, ssizeof(buf), "%s.index",
+                    data->nserv->conn->account.host);
+  mutt_update_list_file(buf, data->nserv->conn->account.host, data->group,
+                        NULL);
 }
 
 static int nntp_save_cache_index (nntp_server_t * news)
@@ -813,19 +754,18 @@ static int nntp_save_cache_index (nntp_server_t * news)
 
   if (!news || !news->newsgroups)
     return -1;
-  if (!option (OPTNEWSCACHE))
+  if (!nntp.use_cache)
     return 0;
 
   if (news->cache) {
-    nntp_cache_expand (file, news->cache);
-    unlink (file);
-    f = safe_fopen (file, "w");
-  }
-  else {
-    m_strcpy(buf, sizeof(buf), news->conn->account.host);
-    f = mutt_mkname (buf);
+    nntp_cache_expand(file, ssizeof(file), "%s", news->cache);
+    unlink(file);
+    f = safe_fopen(file, "w");
+  } else {
+    m_strcpy(buf, ssizeof(buf), news->conn->account.host);
+    f = mutt_mkname(buf);
     news->cache = m_strdup(buf);
-    nntp_cache_expand (file, buf);
+    nntp_cache_expand(file, ssizeof(file), "%s", buf);
   }
   if (!f)
     return -1;
@@ -834,11 +774,11 @@ static int nntp_save_cache_index (nntp_server_t * news)
     if (!d->deleted) {
       if (d->desc)
         snprintf (buf, sizeof (buf), "%s %d %d %c %s\n", d->group,
-                  d->lastMessage, d->firstMessage, d->allowed ? 'y' : 'n',
+                  d->last, d->first, d->allowed ? 'y' : 'n',
                   d->desc);
       else
         snprintf (buf, sizeof (buf), "%s %d %d %c\n", d->group,
-                  d->lastMessage, d->firstMessage, d->allowed ? 'y' : 'n');
+                  d->last, d->first, d->allowed ? 'y' : 'n');
       if (fputs (buf, f) == EOF) {
         m_fclose(&f);
         unlink (file);
@@ -865,23 +805,24 @@ static int nntp_save_cache_group (CONTEXT * ctx)
   int i = 0, save = SORT_ORDER;
   int prev = 0;
 
-  if (!option (OPTNEWSCACHE))
+  if (!nntp.use_cache)
     return 0;
   if (!ctx || !ctx->data || ctx->magic != M_NNTP)
     return -1;
 
   if (((nntp_data_t *) ctx->data)->cache) {
-    nntp_cache_expand (file, ((nntp_data_t *) ctx->data)->cache);
+    nntp_cache_expand(file, ssizeof(file), "%s",
+                      ((nntp_data_t *)ctx->data)->cache);
     unlink (file);
     f = safe_fopen (file, "w");
   }
   else {
-    snprintf (buf, sizeof (buf), "%s-%s",
-              ((nntp_data_t *) ctx->data)->nserv->conn->account.host,
-              ((nntp_data_t *) ctx->data)->group);
+    snprintf(buf, ssizeof(buf), "%s-%s",
+             ((nntp_data_t *)ctx->data)->nserv->conn->account.host,
+             ((nntp_data_t *)ctx->data)->group);
     f = mutt_mkname (buf);
-    ((nntp_data_t *) ctx->data)->cache = m_strdup(buf);
-    nntp_cache_expand (file, buf);
+    ((nntp_data_t *)ctx->data)->cache = m_strdup(buf);
+    nntp_cache_expand(file, ssizeof(file), "%s", buf);
   }
   if (!f)
     return -1;
@@ -948,10 +889,8 @@ nntp_data_t *mutt_newsgroup_subscribe (nntp_server_t * news, char *group)
     data->group = m_strdup(group);
     data->nserv = news;
     data->deleted = 1;
-    if (news->newsgroups->nelem < news->newsgroups->curnelem * 2)
-        hash_resize (news->newsgroups, news->newsgroups->nelem * 2);
     hash_insert (news->newsgroups, data->group, data);
-    nntp_data_list_append(&news->list, data);
+    news->tail = nntp_data_list_append(news->tail, data);
   }
   if (!data->subscribed) {
     data->subscribed = 1;
@@ -969,8 +908,6 @@ nntp_data_t *mutt_newsgroup_unsubscribe (nntp_server_t * news, char *group)
     return NULL;
   if (data->subscribed) {
     data->subscribed = 0;
-    if (!option (OPTSAVEUNSUB))
-      data->rc = 0;
   }
   return data;
 }
@@ -989,7 +926,7 @@ nntp_data_t *mutt_newsgroup_catchup (nntp_server_t * news, char *group)
   data->num = 1;
   data->entries[0].first = 1;
   data->unread = 0;
-  data->entries[0].last = data->lastMessage;
+  data->entries[0].last = data->last;
   if (Context && Context->data == data) {
     int x;
 
@@ -1012,7 +949,7 @@ nntp_data_t *mutt_newsgroup_uncatchup (nntp_server_t * news, char *group)
   }
   data->num = 1;
   data->entries[0].first = 1;
-  data->entries[0].last = data->firstMessage - 1;
+  data->entries[0].last = data->first - 1;
   if (Context && Context->data == data) {
     int x;
 
@@ -1021,7 +958,7 @@ nntp_data_t *mutt_newsgroup_uncatchup (nntp_server_t * news, char *group)
       mutt_set_flag (Context, Context->hdrs[x], M_READ, 0);
   }
   else
-    data->unread = data->lastMessage - data->entries[0].last;
+    data->unread = data->last - data->entries[0].last;
   return data;
 }
 
@@ -1098,21 +1035,21 @@ void nntp_sync_sidebar (nntp_data_t* data) {
   tmp = Incoming.arr[i];
   /* copied from browser.c */
   if (option (OPTMARKOLD) &&
-      data->lastCached >= data->firstMessage &&
-      data->lastCached <= data->lastMessage)
-    tmp->msg_unread = data->lastMessage - data->lastCached;
+      data->lastCached >= data->first &&
+      data->lastCached <= data->last)
+    tmp->msg_unread = data->last - data->lastCached;
   else
     tmp->msg_unread = data->unread;
   tmp->new = data->unread > 0;
   /* this is closest to a "total" count we can get */
-  tmp->msgcount = data->lastMessage - data->firstMessage;
+  tmp->msgcount = data->last - data->first;
 }
 
 static int nntp_auth (nntp_server_t * serv)
 {
   CONNECTION *conn = serv->conn;
   char buf[STRING];
-  unsigned char flags = conn->account.flags;
+  int flags = conn->account.flags;
 
   if (mutt_account_getuser(&conn->account) || !conn->account.user[0] ||
       mutt_account_getpass(&conn->account) || !conn->account.pass[0]) {
@@ -1546,9 +1483,7 @@ static void nntp_get_desc (nntp_data_t * data, const char *mask, char *msg, prog
     snprintf (buf, sizeof (buf), "XGTITLE %s\r\n", mask);
   else
     snprintf (buf, sizeof (buf), "LIST NEWSGROUPS %s\r\n", mask);
-  if (mutt_nntp_fetch (data, buf, msg, bar, parse_description, data->nserv, 0) !=
-      0) {
-  }
+  mutt_nntp_fetch (data, buf, msg, bar, parse_description, data->nserv, 0);
 }
 
 /*
@@ -1716,8 +1651,8 @@ static int nntp_fetch_headers(CONTEXT * ctx, int first, int last)
 
   /* CACHE: must be loaded xover cache here */
   num = nntp_data->lastCached - first + 1;
-  if (option (OPTNEWSCACHE) && nntp_data->cache && num > 0) {
-  nntp_cache_expand (buf, nntp_data->cache);
+  if (nntp.use_cache && nntp_data->cache && num > 0) {
+  nntp_cache_expand(buf, ssizeof(buf), "%s", nntp_data->cache);
   mutt_message (msg2);
 
   if ((f = safe_fopen (buf, "r"))) {
@@ -1858,7 +1793,7 @@ static int nntp_open_mailbox (CONTEXT * ctx)
     nntp_data = nntp_data_new();
     nntp_data->group = m_strdup(buf);
     hash_insert(serv->newsgroups, nntp_data->group, nntp_data);
-    nntp_data_list_append(&serv->list, nntp_data);
+    serv->tail = nntp_data_list_append(serv->tail, nntp_data);
   }
   ctx->data = nntp_data;
   nntp_data->nserv = serv;
@@ -1891,6 +1826,8 @@ static int nntp_open_mailbox (CONTEXT * ctx)
           if ((*l) == nntp_data) {
               nntp_data_list_pop(l);
               nntp_data_delete(&nntp_data);
+              if (!*l)
+                  serv->tail = l;
               break;
           }
       }
@@ -1901,8 +1838,8 @@ static int nntp_open_mailbox (CONTEXT * ctx)
     return -1;
   }
 
-  sscanf (buf + 4, "%d %u %u %s", &count, &nntp_data->firstMessage,
-          &nntp_data->lastMessage, buf);
+  sscanf (buf + 4, "%d %u %u %s", &count, &nntp_data->first,
+          &nntp_data->last, buf);
 
   nntp_data->deleted = 0;
 
@@ -1912,12 +1849,12 @@ static int nntp_open_mailbox (CONTEXT * ctx)
    * Check for max adding context. If it is greater than $nntp_context,
    * strip off extra articles
    */
-  first = nntp_data->firstMessage;
-  if (NntpContext && nntp_data->lastMessage - first + 1 > NntpContext)
-    first = nntp_data->lastMessage - NntpContext + 1;
+  first = nntp_data->first;
+  if (NntpContext && nntp_data->last - first + 1 > NntpContext)
+    first = nntp_data->last - NntpContext + 1;
   if (first)
     nntp_data->lastLoaded = first - 1;
-  return nntp_fetch_headers (ctx, first, nntp_data->lastMessage);
+  return nntp_fetch_headers (ctx, first, nntp_data->last);
 }
 
 int nntp_fetch_message (MESSAGE * msg, CONTEXT * ctx, int msgno)
@@ -2091,35 +2028,12 @@ void nntp_logout_all (void)
   }
 }
 
-static void nntp_free_acache (nntp_data_t * data)
-{
-  int i;
-
-  for (i = 0; i < NNTP_CACHE_LEN; i++) {
-    if (data->acache[i].path) {
-      unlink (data->acache[i].path);
-      p_delete(&data->acache[i].path);
-    }
-  }
-}
-
-void nntp_data_wipe(nntp_data_t *data)
-{
-    p_delete(&data->entries);
-    p_delete(&data->desc);
-    p_delete(&data->cache);
-    p_delete(&data->group);
-    nntp_free_acache(data);
-}
-
 static int nntp_sync_mailbox (CONTEXT * ctx, int unused1, int* unused2)
 {
   nntp_data_t *data = ctx->data;
 
-  /* CACHE: update cache and .index files */
-  if ((option (OPTSAVEUNSUB) || data->subscribed))
-    nntp_save_cache_group (ctx);
-  nntp_free_acache (data);
+  nntp_save_cache_group(ctx);
+  nntp_free_acache(data);
 
   data->nserv->check_time = 0;  /* next nntp_check_mailbox() will really check */
   return 0;
@@ -2198,8 +2112,8 @@ static int _nntp_check_mailbox (CONTEXT * ctx, nntp_data_t * nntp_data)
     int last;
 
     sscanf (buf + 4, "%d %d %d", &count, &first, &last);
-    nntp_data->firstMessage = first;
-    nntp_data->lastMessage = last;
+    nntp_data->first = first;
+    nntp_data->last  = last;
     if (ctx && last > nntp_data->lastLoaded) {
       nntp_fetch_headers (ctx, nntp_data->lastLoaded + 1, last);
       time (&nntp_data->nserv->check_time);
@@ -2289,7 +2203,7 @@ static int nntp_check_newgroups (nntp_server_t * serv, int force)
   if (*emp)
     nntp_save_cache_index(serv);
   mutt_clear_error();
-  return _checked;
+  return nntp.checked;
 }
 
 /* Load list of all newsgroups from active */
@@ -2327,10 +2241,11 @@ int nntp_get_active (nntp_server_t * serv)
       tmp = &(*tmp)->next;
     }
   }
-  nntp_save_cache_index (serv);
+  serv->tail = tmp;
+  nntp_save_cache_index(serv);
 
   mutt_clear_error ();
-  return _checked;
+  return nntp.checked;
 }
 
 /*
@@ -2397,7 +2312,7 @@ int nntp_check_children (CONTEXT * ctx, const char *msgid)
   if (!nntp_data || !nntp_data->nserv || !nntp_data->nserv->conn ||
       !nntp_data->nserv->conn->account.host)
     return -1;
-  if (nntp_data->firstMessage > nntp_data->lastLoaded)
+  if (nntp_data->first > nntp_data->lastLoaded)
     return 0;
   if (!nntp_data->nserv->hasXPAT) {
     mutt_error (_("Server %s does not support this operation!"),
@@ -2406,7 +2321,7 @@ int nntp_check_children (CONTEXT * ctx, const char *msgid)
   }
 
   snprintf (buf, sizeof (buf), "XPAT References %d-%d *%s*\r\n",
-            nntp_data->firstMessage, nntp_data->lastLoaded, msgid);
+            nntp_data->first, nntp_data->lastLoaded, msgid);
 
   if (mutt_nntp_fetch (nntp_data, buf, NULL, NULL, check_children, &cc, 0)) {
     p_delete(&cc.child);
@@ -2417,9 +2332,9 @@ int nntp_check_children (CONTEXT * ctx, const char *msgid)
    * made sure that we dont have the article, so we need to visit
    * the server. Reading the cache at this point is also bad
    * because it would duplicate messages */
-  if (option (OPTNEWSCACHE)) {
+  if (nntp.use_cache) {
     tmp++;
-    unset_option (OPTNEWSCACHE);
+    nntp.use_cache = false;
   }
   for (i = 0; i < cc.num; i++) {
     if ((ret = nntp_fetch_headers (ctx, cc.child[i], cc.child[i])))
@@ -2429,7 +2344,7 @@ int nntp_check_children (CONTEXT * ctx, const char *msgid)
       ctx->hdrs[ctx->msgcount - 1]->read = 0;
   }
   if (tmp)
-    set_option (OPTNEWSCACHE);
+    nntp.use_cache = true;
   p_delete(&cc.child);
   return ret;
 }