X-Git-Url: http://git.madism.org/?p=apps%2Fmadmutt.git;a=blobdiff_plain;f=nntp%2Fnntp.c;h=2b9ead7da3a05f1840fa40c333ebd02d196dac02;hp=aebf3c4167f7cec5ddf65abb4a6c1fab565037b7;hb=7f7a0be369840b290248e5b0302beb447fa1b3cd;hpb=364bf52ada05bf7d7158dba9d2391f63b71258f6 diff --git a/nntp/nntp.c b/nntp/nntp.c index aebf3c4..2b9ead7 100644 --- a/nntp/nntp.c +++ b/nntp/nntp.c @@ -13,6 +13,10 @@ #include #endif +#include +#include +#include + #include "mutt.h" #include "mutt_curses.h" #include "sort.h" @@ -27,9 +31,6 @@ #include "mutt_crypt.h" -#include "lib/mem.h" -#include "lib/str.h" -#include "lib/intl.h" #include "lib/debug.h" #include @@ -37,6 +38,8 @@ #include #include +#define WANT_LISTGROUP_COMMAND 0 + static unsigned int _checked = 0; void nntp_sync_sidebar (NNTP_DATA* data) { @@ -60,7 +63,6 @@ void nntp_sync_sidebar (NNTP_DATA* data) { *data->nserv->conn->account.pass ? data->nserv->conn->account.pass : "", data->nserv->conn->account.host, data->group); - debug_print (4, ("group == '%s'\n", buf)); /* bail out if group not found via mailboxes */ if ((i = buffy_lookup (buf)) < 0) @@ -216,11 +218,13 @@ static int nntp_attempt_features (NNTP_SERVER * serv) if (str_ncmp ("500", buf, 3)) serv->hasXPAT = 1; +#if WANT_LISTGROUP_COMMAND mutt_socket_write (conn, "LISTGROUP\r\n"); if (mutt_socket_readln (buf, sizeof (buf), conn) < 0) return (nntp_connect_error (serv)); if (str_ncmp ("500", buf, 3)) serv->hasLISTGROUP = 1; +#endif mutt_socket_write (conn, "XGTITLE +\r\n"); if (mutt_socket_readln (buf, sizeof (buf), conn) < 0) @@ -320,14 +324,15 @@ static int mutt_nntp_query (NNTP_DATA * data, char *line, size_t linelen) * -2 - invalid command or execution error, * -3 - error in funct(*line, *data). */ -static int mutt_nntp_fetch (NNTP_DATA * nntp_data, char *query, char *msg, - int (*funct) (char *, void *), void *data, - int tagged) +static int mutt_nntp_fetch (NNTP_DATA * nntp_data, const char *query, char *msg, + progress_t* bar, int (*funct) (char *, void *), + void *data, int tagged) { char buf[LONG_STRING]; char *inbuf, *p; int done = FALSE; int chunk, line; + long pos = 0; size_t lenbuf = 0; int ret; @@ -342,7 +347,7 @@ static int mutt_nntp_fetch (NNTP_DATA * nntp_data, char *query, char *msg, ret = 0; line = 0; - inbuf = mem_malloc (sizeof (buf)); + inbuf = p_new(char, sizeof(buf)); FOREVER { chunk = mutt_socket_readln_d (buf, sizeof (buf), nntp_data->nserv->conn, @@ -361,17 +366,22 @@ static int mutt_nntp_fetch (NNTP_DATA * nntp_data, char *query, char *msg, } strfcpy (inbuf + lenbuf, p, sizeof (buf)); + pos += chunk; if (chunk >= sizeof (buf)) { - lenbuf += str_len (p); + lenbuf += m_strlen(p); } else { - line++; - if (msg && ReadInc && (line % ReadInc == 0)) { - if (tagged) - mutt_message (_("%s (tagged: %d) %d"), msg, tagged, line); - else - mutt_message ("%s %d", msg, line); + if (bar) { + mutt_progress_bar (bar, pos); + } else if (msg) { + line++; + if (ReadInc && (line % ReadInc == 0)) { + if (tagged) + mutt_message (_("%s (tagged: %d) %d"), msg, tagged, line); + else + mutt_message ("%s %d", msg, line); + } } if (ret == 0 && funct (inbuf, data) < 0) @@ -379,9 +389,9 @@ static int mutt_nntp_fetch (NNTP_DATA * nntp_data, char *query, char *msg, lenbuf = 0; } - mem_realloc (&inbuf, lenbuf + sizeof (buf)); + p_realloc(&inbuf, lenbuf + sizeof (buf)); } - mem_free (&inbuf); + p_delete(&inbuf); funct (NULL, data); } while (!done); @@ -461,7 +471,7 @@ static int nntp_read_header (CONTEXT * ctx, const char *msgid, else snprintf (buf, sizeof (buf), "HEAD %s\r\n", msgid); - ret = mutt_nntp_fetch (nntp_data, buf, NULL, nntp_read_tempfile, f, 0); + ret = mutt_nntp_fetch (nntp_data, buf, NULL, NULL, nntp_read_tempfile, f, 0); if (ret) { if (ret != -1) debug_print (1, ("%s\n", buf)); @@ -503,14 +513,14 @@ static int parse_description (char *line, void *n) debug_print (2, ("group: %s, desc: %s\n", line, d)); if ((data = (NNTP_DATA *) hash_find (news->newsgroups, line)) != NULL && str_cmp (d, data->desc)) { - mem_free (&data->desc); - data->desc = str_dup (d); + p_delete(&data->desc); + data->desc = m_strdup(d); } return 0; #undef news } -static void nntp_get_desc (NNTP_DATA * data, char *mask, char *msg) +static void nntp_get_desc (NNTP_DATA * data, const char *mask, char *msg, progress_t* bar) { char buf[STRING]; @@ -522,7 +532,7 @@ static void nntp_get_desc (NNTP_DATA * data, char *mask, char *msg) snprintf (buf, sizeof (buf), "XGTITLE %s\r\n", mask); else snprintf (buf, sizeof (buf), "LIST NEWSGROUPS %s\r\n", mask); - if (mutt_nntp_fetch (data, buf, msg, parse_description, data->nserv, 0) != + if (mutt_nntp_fetch (data, buf, msg, bar, parse_description, data->nserv, 0) != 0) { #ifdef DEBUG nntp_error ("nntp_get_desc()", buf); @@ -545,10 +555,10 @@ static int nntp_parse_xover (CONTEXT * ctx, char *buf, HEADER * hdr) int x, done = 0; hdr->env = mutt_new_envelope (); - hdr->env->newsgroups = str_dup (nntp_data->group); + hdr->env->newsgroups = m_strdup(nntp_data->group); hdr->content = mutt_new_body (); hdr->content->type = TYPETEXT; - hdr->content->subtype = str_dup ("plain"); + hdr->content->subtype = m_strdup("plain"); hdr->content->encoding = ENC7BIT; hdr->content->disposition = DISPINLINE; hdr->content->length = -1; @@ -569,24 +579,11 @@ static int nntp_parse_xover (CONTEXT * ctx, char *buf, HEADER * hdr) nntp_get_status (ctx, hdr, NULL, hdr->article_num); break; case 1: - hdr->env->subject = str_dup (b); - /* Now we need to do the things which would normally be done in - * mutt_read_rfc822_header() */ - if (hdr->env->subject) { - regmatch_t pmatch[1]; - - rfc2047_decode (&hdr->env->subject); - - if (regexec (ReplyRegexp.rx, hdr->env->subject, 1, pmatch, 0) == 0) - hdr->env->real_subj = hdr->env->subject + pmatch[0].rm_eo; - else - hdr->env->real_subj = hdr->env->subject; - } + hdr->env->subject = m_strdup(b); break; case 2: rfc822_free_address (&hdr->env->from); hdr->env->from = rfc822_parse_adrlist (hdr->env->from, b); - rfc2047_decode_adrlist (hdr->env->from); /* same as for mutt_parse_rfc822_line(): * don't leave from info NULL if there's an invalid address (or * whatever) in From: field; mutt would just display it as empty @@ -594,7 +591,7 @@ static int nntp_parse_xover (CONTEXT * ctx, char *buf, HEADER * hdr) * bothered me for _years_ */ if (!hdr->env->from) { hdr->env->from = rfc822_new_address (); - hdr->env->from->personal = str_dup (b); + hdr->env->from->personal = m_strdup(b); } break; case 3: @@ -602,8 +599,8 @@ static int nntp_parse_xover (CONTEXT * ctx, char *buf, HEADER * hdr) hdr->received = hdr->date_sent; break; case 4: - mem_free (&hdr->env->message_id); - hdr->env->message_id = str_dup (b); + p_delete(&hdr->env->message_id); + hdr->env->message_id = m_strdup(b); break; case 5: mutt_free_list (&hdr->env->references); @@ -617,11 +614,12 @@ static int nntp_parse_xover (CONTEXT * ctx, char *buf, HEADER * hdr) break; case 8: if (!hdr->read) - mem_free (&hdr->env->xref); + p_delete(&hdr->env->xref); b = b + 6; /* skips the "Xref: " */ - hdr->env->xref = str_dup (b); + hdr->env->xref = m_strdup(b); nntp_parse_xref (ctx, nntp_data->group, b, hdr); } + rfc2047_decode_envelope (hdr->env); if (!*p) return -1; b = p; @@ -639,6 +637,8 @@ typedef struct { } FETCH_CONTEXT; #define fc ((FETCH_CONTEXT *) c) + +#if WANT_LISTGROUP_COMMAND static int _nntp_fetch_numbers (unsigned int num, void *c) { if (num < fc->base || num > fc->last) @@ -652,6 +652,7 @@ static int nntp_fetch_numbers (char *line, void *c) return 0; return (_nntp_fetch_numbers ((unsigned int) atoi (line), c)); } +#endif static int add_xover_line (char *line, void *c) { @@ -711,24 +712,28 @@ static int nntp_fetch_headers (CONTEXT * ctx, unsigned int first, fc.ctx = ctx; fc.base = first; fc.last = last; - fc.messages = mem_calloc (last - first + 1, sizeof (unsigned short)); + fc.messages = p_new(unsigned short, last - first + 1); +#if WANT_LISTGROUP_COMMAND if (nntp_data->nserv->hasLISTGROUP) { snprintf (buf, sizeof (buf), "LISTGROUP %s\r\n", nntp_data->group); - if (mutt_nntp_fetch (nntp_data, buf, NULL, nntp_fetch_numbers, &fc, 0) != + if (mutt_nntp_fetch (nntp_data, buf, NULL, NULL, nntp_fetch_numbers, &fc, 0) != 0) { mutt_error (_("LISTGROUP command failed: %s"), buf); sleep (2); #ifdef DEBUG nntp_error ("nntp_fetch_headers()", buf); #endif - mem_free (&fc.messages); + p_delete(&fc.messages); return -1; } } else { +#endif for (num = 0; num < last - first + 1; num++) fc.messages[num] = 1; +#if WANT_LISTGROUP_COMMAND } +#endif /* CACHE: must be loaded xover cache here */ num = nntp_data->lastCached - first + 1; @@ -765,7 +770,7 @@ static int nntp_fetch_headers (CONTEXT * ctx, unsigned int first, } num = last - first + 1; if (num <= 0) { - mem_free (&fc.messages); + p_delete(&fc.messages); return 0; } @@ -780,7 +785,7 @@ static int nntp_fetch_headers (CONTEXT * ctx, unsigned int first, fc.last = last; fc.msg = msg; snprintf (buf, sizeof (buf), "XOVER %d-%d\r\n", first, last); - ret = mutt_nntp_fetch (nntp_data, buf, NULL, add_xover_line, &fc, 0); + ret = mutt_nntp_fetch (nntp_data, buf, NULL, NULL, add_xover_line, &fc, 0); if (ctx->msgcount > oldmsgcount) mx_update_context (ctx, ctx->msgcount - oldmsgcount); if (ret != 0) { @@ -788,7 +793,7 @@ static int nntp_fetch_headers (CONTEXT * ctx, unsigned int first, #ifdef DEBUG nntp_error ("nntp_fetch_headers()", buf); #endif - mem_free (&fc.messages); + p_delete(&fc.messages); return -1; } /* fetched OK */ @@ -817,14 +822,14 @@ static int nntp_fetch_headers (CONTEXT * ctx, unsigned int first, else mutt_free_header (&h); /* skip it */ if (ret == -1) { - mem_free (&fc.messages); + p_delete(&fc.messages); return -1; } if (current > nntp_data->lastLoaded) nntp_data->lastLoaded = current; } - mem_free (&fc.messages); + p_delete(&fc.messages); nntp_data->lastLoaded = last; mutt_clear_error (); return 0; @@ -860,7 +865,7 @@ int nntp_open_mailbox (CONTEXT * ctx) /* create NNTP-specific state struct if nof found in list */ if ((nntp_data = (NNTP_DATA *) hash_find (serv->newsgroups, buf)) == NULL) { - nntp_data = mem_calloc (1, sizeof (NNTP_DATA) + str_len (buf) + 1); + nntp_data = xmalloc(sizeof(NNTP_DATA) + m_strlen(buf) + 1); nntp_data->group = (char *) nntp_data + sizeof (NNTP_DATA); strcpy (nntp_data->group, buf); hash_insert (serv->newsgroups, nntp_data->group, nntp_data, 0); @@ -872,7 +877,7 @@ int nntp_open_mailbox (CONTEXT * ctx) mutt_message (_("Selecting %s..."), nntp_data->group); if (!nntp_data->desc) { - nntp_get_desc (nntp_data, nntp_data->group, NULL); + nntp_get_desc (nntp_data, nntp_data->group, NULL, NULL); if (nntp_data->desc) nntp_save_cache_index (serv); } @@ -932,8 +937,8 @@ int nntp_fetch_message (MESSAGE * msg, CONTEXT * ctx, int msgno) char buf[LONG_STRING]; char path[_POSIX_PATH_MAX]; NNTP_CACHE *cache; - char *m = _("Fetching message..."); int ret; + progress_t bar; /* see if we already have the message in our cache */ cache = @@ -947,15 +952,13 @@ int nntp_fetch_message (MESSAGE * msg, CONTEXT * ctx, int msgno) /* clear the previous entry */ unlink (cache->path); - free (cache->path); - - mutt_message (m); + p_delete(&cache->path); cache->index = ctx->hdrs[msgno]->index; mutt_mktemp (path); - cache->path = str_dup (path); + cache->path = m_strdup(path); if (!(msg->fp = safe_fopen (path, "w+"))) { - mem_free (&cache->path); + p_delete(&cache->path); return -1; } @@ -966,7 +969,11 @@ int nntp_fetch_message (MESSAGE * msg, CONTEXT * ctx, int msgno) snprintf (buf, sizeof (buf), "ARTICLE %d\r\n", ctx->hdrs[msgno]->article_num); - ret = mutt_nntp_fetch ((NNTP_DATA *) ctx->data, buf, m, nntp_read_tempfile, + bar.msg = _("Fetching message..."); + bar.size = 0; + mutt_progress_bar (&bar, 0); + + ret = mutt_nntp_fetch ((NNTP_DATA *) ctx->data, buf, NULL, &bar, nntp_read_tempfile, msg->fp, ctx->tagged); if (ret == 1) { mutt_error (_("Article %d not found on server"), @@ -977,7 +984,7 @@ int nntp_fetch_message (MESSAGE * msg, CONTEXT * ctx, int msgno) if (ret) { fclose (msg->fp); unlink (path); - mem_free (&cache->path); + p_delete(&cache->path); return -1; } @@ -985,8 +992,8 @@ int nntp_fetch_message (MESSAGE * msg, CONTEXT * ctx, int msgno) ctx->hdrs[msgno]->env = mutt_read_rfc822_header (msg->fp, ctx->hdrs[msgno], 0, 0); /* fix content length */ - fseek (msg->fp, 0, SEEK_END); - ctx->hdrs[msgno]->content->length = ftell (msg->fp) - + fseeko (msg->fp, 0, SEEK_END); + ctx->hdrs[msgno]->content->length = ftello (msg->fp) - ctx->hdrs[msgno]->content->offset; /* this is called in mutt before the open which fetches the message, @@ -1045,7 +1052,7 @@ int nntp_post (const char *msg) buf[0] = '.'; buf[1] = '\0'; while (fgets (buf + 1, sizeof (buf) - 2, f) != NULL) { - len = str_len (buf); + len = m_strlen(buf); if (buf[len - 1] == '\n') { buf[len - 1] = '\r'; buf[len] = '\n'; @@ -1059,7 +1066,7 @@ int nntp_post (const char *msg) } fclose (f); - if (buf[str_len (buf) - 1] != '\n') + if (buf[m_strlen(buf) - 1] != '\n') mutt_socket_write_d (nntp_data->nserv->conn, "\r\n", M_SOCK_LOG_HDR); mutt_socket_write_d (nntp_data->nserv->conn, ".\r\n", M_SOCK_LOG_HDR); if (mutt_socket_readln (buf, sizeof (buf), nntp_data->nserv->conn) < 0) { @@ -1104,22 +1111,22 @@ static void nntp_free_acache (NNTP_DATA * data) for (i = 0; i < NNTP_CACHE_LEN; i++) { if (data->acache[i].path) { unlink (data->acache[i].path); - mem_free (&data->acache[i].path); + p_delete(&data->acache[i].path); } } } void nntp_delete_data (void *p) { - NNTP_DATA *data = (NNTP_DATA *) p; + NNTP_DATA *data = (NNTP_DATA *)p; if (!p) return; - mem_free (&data->entries); - mem_free (&data->desc); - mem_free (&data->cache); + p_delete(&data->entries); + p_delete(&data->desc); + p_delete(&data->cache); nntp_free_acache (data); - mem_free (p); + p_delete(&data); } int nntp_sync_mailbox (CONTEXT * ctx, int unused1, int* unused2) @@ -1228,7 +1235,7 @@ static int _nntp_check_mailbox (CONTEXT * ctx, NNTP_DATA * nntp_data) /* active was renumbered? */ if (last < nntp_data->lastLoaded) { if (!nntp_data->max) { - nntp_data->entries = mem_calloc (5, sizeof (NEWSRC_ENTRY)); + nntp_data->entries = p_new(NEWSRC_ENTRY, 5); nntp_data->max = 5; } nntp_data->lastCached = 0; @@ -1269,7 +1276,7 @@ static int add_group (char *buf, void *serv) return 0; if ((nntp_data = (NNTP_DATA *) hash_find (s->newsgroups, group)) == NULL) { n++; - nntp_data = mem_calloc (1, sizeof (NNTP_DATA) + str_len (group) + 1); + nntp_data = xmalloc(sizeof(NNTP_DATA) + m_strlen(group) + 1); nntp_data->group = (char *) nntp_data + sizeof (NNTP_DATA); strcpy (nntp_data->group, group); nntp_data->nserv = s; @@ -1286,9 +1293,9 @@ static int add_group (char *buf, void *serv) else nntp_data->allowed = 0; if (nntp_data->desc) - mem_free (&nntp_data->desc); + p_delete(&nntp_data->desc); if (*desc) - nntp_data->desc = str_dup (desc); + nntp_data->desc = m_strdup(desc); if (nntp_data->rc || nntp_data->lastCached) mutt_newsgroup_stat (nntp_data); else if (nntp_data->lastMessage && @@ -1344,7 +1351,7 @@ int nntp_check_newgroups (NNTP_SERVER * serv, int force) else nntp_data.group = NULL; l = serv->tail; - if (mutt_nntp_fetch (&nntp_data, buf, _("Adding new newsgroups..."), + if (mutt_nntp_fetch (&nntp_data, buf, _("Adding new newsgroups..."), NULL, add_group, serv, 0) != 0) { #ifdef DEBUG nntp_error ("nntp_check_newgroups()", buf); @@ -1363,7 +1370,7 @@ int nntp_check_newgroups (NNTP_SERVER * serv, int force) l = l->next; ((NNTP_DATA *) l->data)->new = 1; nntp_get_desc ((NNTP_DATA *) l->data, ((NNTP_DATA *) l->data)->group, - NULL); + NULL, NULL); } if (emp.next) nntp_save_cache_index (serv); @@ -1393,7 +1400,7 @@ int nntp_get_cache_all (NNTP_SERVER * serv) return 0; } else { - mem_free (&serv->cache); + p_delete(&serv->cache); return -1; } } @@ -1416,7 +1423,7 @@ int nntp_get_active (NNTP_SERVER * serv) nntp_data.nserv = serv; nntp_data.group = NULL; - if (mutt_nntp_fetch (&nntp_data, "LIST\r\n", msg, add_group, serv, 0) < 0) { + if (mutt_nntp_fetch (&nntp_data, "LIST\r\n", msg, NULL, add_group, serv, 0) < 0) { #ifdef DEBUG nntp_error ("nntp_get_active()", "LIST\r\n"); #endif @@ -1425,7 +1432,7 @@ int nntp_get_active (NNTP_SERVER * serv) strfcpy (msg, _("Loading descriptions..."), sizeof (msg)); mutt_message (msg); - nntp_get_desc (&nntp_data, "*", msg); + nntp_get_desc (&nntp_data, "*", msg, NULL); for (tmp = serv->list; tmp; tmp = tmp->next) { NNTP_DATA *data = (NNTP_DATA *) tmp->data; @@ -1490,7 +1497,7 @@ static int check_children (char *s, void *c) if (cc->ctx->hdrs[i]->article_num == n) return 0; if (cc->num >= cc->max) - mem_realloc (&cc->child, sizeof (unsigned int) * (cc->max += 25)); + p_realloc(&cc->child, cc->max += 25); cc->child[cc->num++] = n; return 0; @@ -1521,9 +1528,9 @@ int nntp_check_children (CONTEXT * ctx, const char *msgid) cc.ctx = ctx; cc.num = 0; cc.max = 25; - cc.child = mem_malloc (sizeof (unsigned int) * 25); - if (mutt_nntp_fetch (nntp_data, buf, NULL, check_children, &cc, 0)) { - mem_free (&cc.child); + cc.child = p_new(unsigned int, 25); + if (mutt_nntp_fetch (nntp_data, buf, NULL, NULL, check_children, &cc, 0)) { + p_delete(&cc.child); return -1; } /* dont try to read the xover cache. check_children() already @@ -1543,6 +1550,6 @@ int nntp_check_children (CONTEXT * ctx, const char *msgid) } if (tmp) set_option (OPTNEWSCACHE); - mem_free (&cc.child); + p_delete(&cc.child); return ret; }