X-Git-Url: http://git.madism.org/?p=apps%2Fmadmutt.git;a=blobdiff_plain;f=pop%2Fpop.c;h=34d1cc779e126ca2eec31738df223b81952256f3;hp=87912b7be291fa61e4d7e5b83a1e2c3f2bc2a078;hb=c8ceef3ed6424dcb5a6ec835e7d8d9cc00595372;hpb=a8477ebaa09990b3688164cbe5cf661c4189541d diff --git a/pop/pop.c b/pop/pop.c index 87912b7..34d1cc7 100644 --- a/pop/pop.c +++ b/pop/pop.c @@ -15,6 +15,7 @@ #include "mx.h" #include "pop.h" #include "mutt_crypt.h" +#include "mutt_curses.h" #include "lib/mem.h" #include "lib/str.h" @@ -106,6 +107,11 @@ static pop_query_status pop_read_header (POP_DATA * pop_data, HEADER * h) { mutt_error _("Can't write header to temporary file!"); + break; + } + case PQ_NOT_CONNECTED: + { + mutt_error _("Can't fetch header: Not connected!"); break; } } @@ -240,10 +246,10 @@ int pop_open_mailbox (CONTEXT * ctx) if (!conn) return -1; - FREE (&ctx->path); + mem_free (&ctx->path); ctx->path = str_dup (buf); - pop_data = safe_calloc (1, sizeof (POP_DATA)); + pop_data = mem_calloc (1, sizeof (POP_DATA)); pop_data->conn = conn; ctx->data = pop_data; @@ -285,7 +291,7 @@ static void pop_clear_cache (POP_DATA * pop_data) for (i = 0; i < POP_CACHE_LEN; i++) { if (pop_data->cache[i].path) { unlink (pop_data->cache[i].path); - FREE (&pop_data->cache[i].path); + mem_free (&pop_data->cache[i].path); } } } @@ -321,7 +327,7 @@ int pop_fetch_message (MESSAGE * msg, CONTEXT * ctx, int msgno) void *uidl; char buf[LONG_STRING]; char path[_POSIX_PATH_MAX]; - char *m = _("Fetching message..."); + progress_t bar; POP_DATA *pop_data = (POP_DATA *) ctx->data; POP_CACHE *cache; HEADER *h = ctx->hdrs[msgno]; @@ -343,7 +349,7 @@ int pop_fetch_message (MESSAGE * msg, CONTEXT * ctx, int msgno) else { /* clear the previous entry */ unlink (cache->path); - FREE (&cache->path); + mem_free (&cache->path); } } @@ -359,7 +365,9 @@ int pop_fetch_message (MESSAGE * msg, CONTEXT * ctx, int msgno) return -1; } - mutt_message (m); + bar.size = h->content->length + h->content->offset - 1; + bar.msg = _("Fetching message..."); + mutt_progress_bar (&bar, 0); mutt_mktemp (path); msg->fp = safe_fopen (path, "w+"); @@ -371,7 +379,7 @@ int pop_fetch_message (MESSAGE * msg, CONTEXT * ctx, int msgno) snprintf (buf, sizeof (buf), "RETR %d\r\n", h->refno); - ret = pop_fetch_data (pop_data, buf, m, fetch_message, msg->fp); + ret = pop_fetch_data (pop_data, buf, &bar, fetch_message, msg->fp); if (ret == PQ_OK) break; @@ -409,7 +417,7 @@ int pop_fetch_message (MESSAGE * msg, CONTEXT * ctx, int msgno) fgets (buf, sizeof (buf), msg->fp); } - h->content->length = ftell (msg->fp) - h->content->offset; + h->content->length = ftello (msg->fp) - h->content->offset; /* This needs to be done in case this is a multipart message */ if (!WithCrypto) @@ -516,7 +524,7 @@ void pop_fetch_mail (void) return; } - url = p = safe_calloc (strlen (PopHost) + 7, sizeof (char)); + url = p = mem_calloc (strlen (PopHost) + 7, sizeof (char)); if (url_check_scheme (PopHost) == U_UNKNOWN) { strcpy (url, "pop://"); /* __STRCPY_CHECKED__ */ p = strchr (url, '\0'); @@ -524,7 +532,7 @@ void pop_fetch_mail (void) strcpy (p, PopHost); /* __STRCPY_CHECKED__ */ ret = pop_parse_path (url, &acct); - FREE (&url); + mem_free (&url); if (ret) { mutt_error (_("%s is an invalid POP path"), PopHost); return; @@ -534,12 +542,12 @@ void pop_fetch_mail (void) if (!conn) return; - pop_data = safe_calloc (1, sizeof (POP_DATA)); + pop_data = mem_calloc (1, sizeof (POP_DATA)); pop_data->conn = conn; if (pop_open_connection (pop_data) < 0) { mutt_socket_free (pop_data->conn); - FREE (&pop_data); + mem_free (&pop_data); return; } @@ -641,11 +649,11 @@ finish: if (pop_query (pop_data, buffer, sizeof (buffer)) == PQ_NOT_CONNECTED) goto fail; mutt_socket_close (conn); - FREE (&pop_data); + mem_free (&pop_data); return; fail: mutt_error _("Server closed connection!"); mutt_socket_close (conn); - FREE (&pop_data); + mem_free (&pop_data); }