X-Git-Url: http://git.madism.org/?p=apps%2Fmadmutt.git;a=blobdiff_plain;f=sidebar.c;h=92a0d2a06c4c9e046b11c0d4d890599e3a651732;hp=40a0fee3343e2007d75fc99c1e2f094b2f7cae9a;hb=23265c6d12ecb744cb38689e9d78a448089ac351;hpb=0f44dc85fc1280372ffab911d701e703d803fb4b

diff --git a/sidebar.c b/sidebar.c
index 40a0fee..92a0d2a 100644
--- a/sidebar.c
+++ b/sidebar.c
@@ -30,19 +30,8 @@ static int TopBuffy = 0;
 static int CurBuffy = 0;
 static int known_lines = 0;
 static short initialized = 0;
-static int prev_show_value;
+static short prev_show_value;
 static short saveSidebarWidth;
-static char *entry = 0;
-
-/* computes how many digets a number has;
- * FIXME move out to library?
- */
-static int quick_log10 (int n) {
-  int len = 0;
-
-  for (; n > 9; len++, n /= 10);
-  return (++len);
-}
 
 /* computes first entry to be shown */
 void calc_boundaries (int menu)
@@ -51,42 +40,59 @@ void calc_boundaries (int menu)
 
   if (list_empty(Incoming))
     return;
+  if (CurBuffy < 0 || CurBuffy >= Incoming->length)
+    CurBuffy = 0;
+  if (TopBuffy < 0 || TopBuffy >= Incoming->length)
+    TopBuffy = 0;
   /* correct known_lines if it has changed because of a window resize */
-  if (known_lines != LINES)
-    known_lines = LINES;
+  /*  if (known_lines != LINES)
+    known_lines = LINES; */
+
   lines = LINES - 2 - (menu != MENU_PAGER || option (OPTSTATUSONTOP));
-  TopBuffy = CurBuffy - (CurBuffy % lines);
+  known_lines = lines;
+  if (option (OPTSIDEBARNEWMAILONLY)) {
+    int i = CurBuffy;
+    TopBuffy = CurBuffy - 1;
+    while (i >= 0) {
+      if (((BUFFY*) Incoming->data[i])->new > 0)
+        TopBuffy = i;
+      i--;
+    }
+  } else
+    TopBuffy = CurBuffy - (CurBuffy % lines);
   if (TopBuffy < 0)
     TopBuffy = 0;
 }
 
-static char *shortened_hierarchy (char *box)
+static char *shortened_hierarchy (char *box, int maxlen)
 {
   int dots = 0;
-  char *last_dot;
-  int i, j;
+  char *last_dot = NULL;
+  int i, j, len = str_len (box);
   char *new_box;
 
-  for (i = 0; i < safe_strlen (box); ++i) {
-    if (box[i] == '.')
+  if (!SidebarBoundary || !*SidebarBoundary)
+    return (str_dup (box));
+
+  for (i = 0; i < len; ++i) {
+    if (strchr (SidebarBoundary, box[i])) {
       ++dots;
-    else if (isupper (box[i]))
-      return (safe_strdup (box));
+      last_dot = &box[i];
+    }
   }
-  last_dot = strrchr (box, '.');
+
   if (last_dot) {
     ++last_dot;
-    new_box = safe_malloc (safe_strlen (last_dot) + 2 * dots + 1);
+    new_box = mem_malloc (maxlen + 1);
     new_box[0] = box[0];
-    for (i = 1, j = 1; i < safe_strlen (box); ++i) {
-      if (box[i] == '.') {
-        new_box[j++] = '.';
+    for (i = 1, j = 1; j < maxlen && i < len; ++i) {
+      if (strchr (SidebarBoundary, box[i])) {
+        new_box[j++] = box[i];
         new_box[j] = 0;
-        if (&box[i + 1] != last_dot) {
+        if (&box[i + 1] != last_dot || j + str_len (last_dot) > maxlen) {
           new_box[j++] = box[i + 1];
           new_box[j] = 0;
-        }
-        else {
+        } else {
           strcat (&new_box[j], last_dot);
           break;
         }
@@ -94,87 +100,154 @@ static char *shortened_hierarchy (char *box)
     }
     return new_box;
   }
-  return safe_strdup (box);
+  return str_dup (box);
+}
+
+static const char* sidebar_number_format (char* dest, size_t destlen, char op,
+                                          const char* src, const char* fmt,
+                                          const char* ifstr, const char* elstr,
+                                          unsigned long data, format_flag flags) {
+  char tmp[SHORT_STRING];
+  BUFFY* b = (BUFFY*) Incoming->data[data];
+  int opt = flags & M_FORMAT_OPTIONAL;
+  int c = Context && str_eq (Context->path, b->path);
+
+  switch (op) {
+    /* deleted */
+    case 'd':
+      if (!opt) {
+        snprintf (tmp, sizeof (tmp), "%%%sd", fmt);
+        snprintf (dest, destlen, tmp, c ? Context->deleted : 0);
+      } else if ((c && Context->deleted == 0) || !c)
+        opt = 0;
+      break;
+    /* flagged */
+    case 'F':
+    case 'f':                   /* for compatibility */
+      if (!opt) {
+        snprintf (tmp, sizeof (tmp), "%%%sd", fmt);
+        snprintf (dest, destlen, tmp, c ? Context->flagged : b->msg_flagged);
+      } else if ((c && Context->flagged == 0) || (!c && b->msg_flagged == 0))
+        opt = 0;
+      break;
+    /* total */
+    case 'c':                   /* for compatibility */
+    case 'm':
+      if (!opt) {
+        snprintf (tmp, sizeof (tmp), "%%%sd", fmt);
+        snprintf (dest, destlen, tmp, c ? Context->msgcount : b->msgcount);
+      } else if ((c && Context->msgcount == 0) || (!c && b->msgcount == 0))
+        opt = 0;
+      break;
+    /* total shown, i.e. not hidden by limit */
+    case 'M':
+      if (!opt) {
+        snprintf (tmp, sizeof (tmp), "%%%sd", fmt);
+        snprintf (dest, destlen, tmp, c ? Context->vcount : 0);
+      } else if ((c && Context->vcount == 0) || !c)
+        opt = 0;
+      break;
+    /* new */
+    case 'n':
+      if (!opt) {
+        snprintf (tmp, sizeof (tmp), "%%%sd", fmt);
+        snprintf (dest, destlen, tmp, c ? Context->new : b->new);
+      } else if ((c && Context->new == 0) || (!c && b->new == 0))
+        opt = 0;
+      break;
+    /* unread */
+    case 'u':
+      if (!opt) {
+        snprintf (tmp, sizeof (tmp), "%%%sd", fmt);
+        snprintf (dest, destlen, tmp, c ? Context->unread : b->msg_unread);
+      } else if ((c && Context->unread == 0) || (!c && b->msg_unread == 0))
+        opt = 0;
+      break;
+    /* tagged */
+    case 't':
+      if (!opt) {
+        snprintf (tmp, sizeof (tmp), "%%%sd", fmt);
+        snprintf (dest, destlen, tmp, c ? Context->tagged : 0);
+      } else if ((c && Context->tagged == 0) || !c)
+        opt = 0;
+      break;
+  }
+
+  if (opt)
+    mutt_FormatString (dest, destlen, ifstr, sidebar_number_format,
+                       data, M_FORMAT_OPTIONAL);
+  else if (flags & M_FORMAT_OPTIONAL)
+    mutt_FormatString (dest, destlen, elstr, sidebar_number_format,
+                       data, M_FORMAT_OPTIONAL);
+  return (src);
+}
+
+int sidebar_need_count (void) {
+  if (!option (OPTMBOXPANE) || SidebarWidth == 0 ||
+      !SidebarNumberFormat || !*SidebarNumberFormat)
+    return (0);
+  return (1);
 }
 
 /* print single item
- * FIXME this is completely fucked up right now
+ * returns:
+ *      0       item was not printed ('cause of $sidebar_newmail_only)
+ *      1       item was printed
  */
-char *make_sidebar_entry (char *box, int size, int new, int flagged)
+int make_sidebar_entry (char* box, int idx, size_t len)
 {
-  int i = 0, dlen, max, shortened = 0;
-  int offset;
+  int shortened = 0, lencnt = 0;
+  char no[SHORT_STRING], entry[SHORT_STRING];
+#if USE_IMAP
+  int l = str_len (ImapHomeNamespace);
+#endif
+  int l_m = str_len (Maildir);
 
   if (SidebarWidth > COLS)
     SidebarWidth = COLS;
 
-  dlen = safe_strlen (SidebarDelim);
-  max = SidebarWidth - dlen - 1;
+  if (option (OPTSIDEBARNEWMAILONLY) && box && Context && Context->path && 
+      !str_eq (Context->path, box) && ((BUFFY*) Incoming->data[idx])->new == 0)
+    /* if $sidebar_newmail_only is set, don't display the
+     * box only if it's not the currently opened
+     * (i.e. always display the currently opened) */
+    return (0);
+
+  mutt_FormatString (no, len, NONULL (SidebarNumberFormat),
+                     sidebar_number_format, idx, M_FORMAT_OPTIONAL);
+  lencnt = str_len (no);
+  memset (&entry, ' ', sizeof (entry));
 
-  safe_realloc (&entry, SidebarWidth + 1);
-  entry[SidebarWidth] = 0;
-  for (; i < SidebarWidth; entry[i++] = ' ');
 #if USE_IMAP
-  if (ImapHomeNamespace && safe_strlen (ImapHomeNamespace) > 0) {
-    if (strncmp (box, ImapHomeNamespace, safe_strlen (ImapHomeNamespace)) == 0
-        && safe_strcmp (box, ImapHomeNamespace) != 0) {
-      box += safe_strlen (ImapHomeNamespace) + 1;
-    }
-  }
+  if (l > 0 && str_ncmp (box, ImapHomeNamespace, l) == 0 && 
+      str_len (box) > l)
+    box += l + 1; /* we're trimming the ImapHomeNamespace, the "+ 1" is for the separator */
+  else
 #endif
-  max -= quick_log10 (size);
-  if (new)
-    max -= quick_log10 (new) + 2;
-  if (flagged > 0)
-    max -= quick_log10 (flagged) + 2;
-  if (option (OPTSHORTENHIERARCHY) && safe_strlen (box) > max) {
-    box = shortened_hierarchy (box);
-    shortened = 1;
-  }
-  i = safe_strlen (box);
-  strncpy (entry, box, i < SidebarWidth - dlen ? i : SidebarWidth - dlen);
-
-  if (new) {
-    if (flagged > 0) {
-      offset =
-        SidebarWidth - 5 - quick_log10 (size) - dlen - quick_log10 (new) -
-        quick_log10 (flagged);
-      if (offset < 0)
-        offset = 0;
-      snprintf (entry + offset, SidebarWidth - dlen - offset + 1,
-                "% d(%d)[%d]", size, new, flagged);
-    }
-    else {
-      offset =
-        SidebarWidth - 3 - quick_log10 (size) - dlen - quick_log10 (new);
-      if (offset < 0)
-        offset = 0;
-      snprintf (entry + offset, SidebarWidth - dlen - offset + 1,
-                "% d(%d)", size, new);
+  if (l_m > 0 && str_ncmp (box, Maildir, l_m) == 0 && 
+      str_len (box) > l_m) {
+    box += l_m;
+    if (Maildir[strlen(Maildir)-1]!='/') {
+      box += 1;
     }
-  }
-  else {
-    if (flagged > 0) {
-      offset =
-        SidebarWidth - 3 - quick_log10 (size) - dlen - quick_log10 (flagged);
-      if (offset < 0)
-        offset = 0;
-      snprintf (entry + offset, SidebarWidth - dlen - offset + 1,
-                "% d[%d]", size, flagged);
-    }
-    else {
-      offset = SidebarWidth - 1 - quick_log10 (size) - dlen;
-      if (offset < 0)
-        offset = 0;
-      snprintf (entry + offset, SidebarWidth - dlen - offset + 1,
-                "% d", size);
-    }
-  }
+  } else
+    box = basename (box);
 
-  if (option (OPTSHORTENHIERARCHY) && shortened) {
-    free (box);
+  if (option (OPTSHORTENHIERARCHY) && str_len (box) > len-lencnt-1) {
+    box = shortened_hierarchy (box, len-lencnt-1);
+    shortened = 1;
   }
-  return entry;
+
+  snprintf (entry, len-lencnt, "%s", box);
+  entry[str_len (entry)] = ' ';
+  strncpy (entry + (len - lencnt), no, lencnt);
+
+  addnstr (entry, len);
+
+  if (shortened)
+    mem_free(&box);
+
+  return (1);
 }
 
 /* returns folder name of currently 
@@ -210,22 +283,23 @@ void sidebar_set_buffystats (CONTEXT* Context) {
 
 /* actually draws something
  * FIXME this needs some clue when to do it
- * FIXME this is completely fucked up right now
  */
 int sidebar_draw (int menu)
 {
 
-  int lines = option (OPTHELP) ? 1 : 0;
+  int lines = option (OPTHELP) ? 1 : 0, draw_devider = 1, i = 0;
   BUFFY *tmp;
-  int i = 0;
-  short delim_len = safe_strlen (SidebarDelim);
+  short delim_len = str_len (SidebarDelim);
+  char blank[SHORT_STRING];
 
   /* initialize first time */
   if (!initialized) {
     prev_show_value = option (OPTMBOXPANE);
     saveSidebarWidth = SidebarWidth;
-    if (!option (OPTMBOXPANE))
+    if (!option (OPTMBOXPANE)){
       SidebarWidth = 0;
+      draw_devider = 1;
+    }
     initialized = 1;
   }
 
@@ -238,13 +312,13 @@ int sidebar_draw (int menu)
     else if (!prev_show_value && option (OPTMBOXPANE)) {
       SidebarWidth = saveSidebarWidth;
       /* after toggle: force recounting of all mail */
-      mutt_buffy_check (2);
+      buffy_check (2);
     }
     prev_show_value = option (OPTMBOXPANE);
   }
 
   if (SidebarWidth > 0 && option (OPTMBOXPANE)
-      && safe_strlen (SidebarDelim) >= SidebarWidth) {
+      && str_len (SidebarDelim) >= SidebarWidth) {
     mutt_error (_("Value for sidebar_delim is too long. Disabling sidebar."));
     sleep (2);
     unset_option (OPTMBOXPANE);
@@ -253,89 +327,55 @@ int sidebar_draw (int menu)
 
   if (SidebarWidth == 0 || !option (OPTMBOXPANE))
     return 0;
-
-  /* draw the divider */
-  SETCOLOR (MT_COLOR_SIDEBAR);
-  for (lines = 1;
-       lines < LINES - 1 - (menu != MENU_PAGER || option (OPTSTATUSONTOP));
-       lines++) {
-    move (lines, SidebarWidth - delim_len);
-    if (option (OPTASCIICHARS))
-      addstr (NONULL (SidebarDelim));
-    else if (!option (OPTASCIICHARS) && !safe_strcmp (SidebarDelim, "|"))
-      addch (ACS_VLINE);
-    else if ((Charset_is_utf8) && !safe_strcmp (SidebarDelim, "|"))
-      addstr ("\342\224\202");
-    else
-      addstr (NONULL (SidebarDelim));
+  /* draw devider only if necessary (if the sidebar becomes visible e.g.)*/
+  if (draw_devider == 1){
+    /* draw the divider */
+    SETCOLOR (MT_COLOR_SIDEBAR);
+    for (lines = 1;
+         lines < LINES - 1 - (menu != MENU_PAGER || option (OPTSTATUSONTOP));
+         lines++) {
+      move (lines, SidebarWidth - delim_len);
+      if (option (OPTASCIICHARS))
+        addstr (NONULL (SidebarDelim));
+      else if (!option (OPTASCIICHARS) && !str_cmp (SidebarDelim, "|"))
+        addch (ACS_VLINE);
+      else if ((Charset_is_utf8) && !str_cmp (SidebarDelim, "|"))
+        addstr ("\342\224\202");
+      else
+        addstr (NONULL (SidebarDelim));
+    }
   }
   SETCOLOR (MT_COLOR_NORMAL);
 
   if (list_empty(Incoming))
     return 0;
-
   lines = option (OPTHELP) ? 1 : 0;     /* go back to the top */
-
   calc_boundaries (menu);
 
+  /* actually print items */
   for (i = TopBuffy; i < Incoming->length && lines < LINES - 1 - 
        (menu != MENU_PAGER || option (OPTSTATUSONTOP)); i++) {
     tmp = (BUFFY*) Incoming->data[i];
+
     if (i == CurBuffy)
       SETCOLOR (MT_COLOR_INDICATOR);
+    else if (tmp->new > 0)
+      SETCOLOR (MT_COLOR_NEW);
     else if (tmp->msg_flagged > 0)
       SETCOLOR (MT_COLOR_FLAGGED);
-    else if (tmp->msg_unread > 0)
-      SETCOLOR (MT_COLOR_NEW);
     else
       SETCOLOR (MT_COLOR_NORMAL);
 
     move (lines, 0);
-    if (option (OPTSIDEBARNEWMAILONLY)) {
-      if (tmp->msg_unread > 0) {
-        if (Context && !safe_strcmp (tmp->path, Context->path)) {
-          printw ("%.*s", SidebarWidth - delim_len,
-                  make_sidebar_entry (basename (tmp->path),
-                                      Context->msgcount, Context->unread,
-                                      Context->flagged));
-          tmp->msg_unread = Context->unread;
-          tmp->msgcount = Context->msgcount;
-          tmp->msg_flagged = Context->flagged;
-        }
-        else
-          printw ("%.*s", SidebarWidth - delim_len,
-                  make_sidebar_entry (basename (tmp->path),
-                                      tmp->msgcount, tmp->msg_unread,
-                                      tmp->msg_flagged));
-        lines++;
-      }
-    }
-    else {
-      if (Context && !safe_strcmp (tmp->path, Context->path)) {
-        printw ("%.*s", SidebarWidth - delim_len,
-                make_sidebar_entry (basename (tmp->path),
-                                    Context->msgcount, Context->unread,
-                                    Context->flagged));
-        tmp->msg_unread = Context->unread;
-        tmp->msgcount = Context->msgcount;
-        tmp->msg_flagged = Context->flagged;
-      }
-      else
-        printw ("%.*s", SidebarWidth - delim_len,
-                make_sidebar_entry (basename (tmp->path),
-                                    tmp->msgcount, tmp->msg_unread,
-                                    tmp->msg_flagged));
-      lines++;
-    }
+    lines += make_sidebar_entry (tmp->path, i, SidebarWidth-delim_len);
   }
-  SETCOLOR (MT_COLOR_NORMAL);
-  for (; lines < LINES - 1 - (menu != MENU_PAGER || option (OPTSTATUSONTOP));
-       lines++) {
-    int i = 0;
 
+  /* fill with blanks to bottom */
+  memset (&blank, ' ', sizeof (blank));
+  SETCOLOR (MT_COLOR_NORMAL);
+  for (; lines < LINES - 1 - (menu != MENU_PAGER || option (OPTSTATUSONTOP)); lines++) {
     move (lines, 0);
-    for (; i < SidebarWidth - delim_len; i++)
-      addch (' ');
+    addnstr (blank, SidebarWidth-delim_len);
   }
   return 0;
 }
@@ -347,7 +387,7 @@ static int exist_next_new () {
     return (-1);
   i = CurBuffy + 1;
   while (i < Incoming->length)
-    if (((BUFFY*) Incoming->data[i++])->msg_unread)
+    if (((BUFFY*) Incoming->data[i++])->new > 0)
       return (i-1);
   return (-1);
 }
@@ -359,7 +399,7 @@ static int exist_prev_new () {
     return (-1);
   i = CurBuffy - 1;
   while (i >= 0)
-    if (((BUFFY*) Incoming->data[i--])->msg_unread)
+    if (((BUFFY*) Incoming->data[i--])->new > 0)
       return (i+1);
   return (-1);
 }
@@ -407,7 +447,7 @@ void sidebar_scroll (int op, int menu) {
     break;
 
   case OP_SIDEBAR_SCROLL_UP:
-    if (TopBuffy == 0) {
+    if (CurBuffy == 0) {
       mutt_error (_("You are on the first mailbox."));
       return;
     }
@@ -416,13 +456,13 @@ void sidebar_scroll (int op, int menu) {
       CurBuffy = 0;
     break;
   case OP_SIDEBAR_SCROLL_DOWN:
-    if (TopBuffy + known_lines >= Incoming->length) {
+    if (CurBuffy + 1 == Incoming->length) {
       mutt_error (_("You are on the last mailbox."));
       return;
     }
     CurBuffy += known_lines;
     if (CurBuffy >= Incoming->length)
-      CurBuffy = Incoming->length;
+      CurBuffy = Incoming->length - 1;
     break;
   default:
     return;