projects
/
apps
/
madmutt.git
/ blobdiff
commit
grep
author
committer
pickaxe
?
search:
re
summary
|
shortlog
|
log
|
commit
|
commitdiff
|
tree
raw
|
inline
| side by side
workarounds, I do not understand why it segfault, it should *NOT*
[apps/madmutt.git]
/
mutt_libesmtp.c
diff --git
a/mutt_libesmtp.c
b/mutt_libesmtp.c
index
f51bd2e
..
82e1a5f
100644
(file)
--- a/
mutt_libesmtp.c
+++ b/
mutt_libesmtp.c
@@
-10,25
+10,18
@@
* It's licensed under the GNU General Public License,
* please see the file GPL in the top level source directory.
*/
* It's licensed under the GNU General Public License,
* please see the file GPL in the top level source directory.
*/
-#if HAVE_CONFIG_H
-#include "config.h"
-#endif
-#include <lib-lib/mem.h>
-#include <lib-lib/str.h>
-#include <lib-lib/ascii.h>
-#include <lib-lib/macros.h>
+#include <lib-lib/lib-lib.h>
+
+#include <lib-ui/enter.h>
#include "mutt.h"
#include "mutt.h"
-#include "enter.h"
#if defined (USE_SSL) || (defined (USE_GNUTLS) && defined (HAVE_GNUTLS_OPENSSL_H))
#include <openssl/ssl.h>
#endif
#if defined (USE_SSL) || (defined (USE_GNUTLS) && defined (HAVE_GNUTLS_OPENSSL_H))
#include <openssl/ssl.h>
#endif
-#include <errno.h>
-
#include <auth-client.h>
#include <libesmtp.h>
#include <auth-client.h>
#include <libesmtp.h>
@@
-151,7
+144,7
@@
static const char *_mutt_libesmtp_messagefp_cb (void **buf, int *len,
int octets;
if (*buf == NULL)
int octets;
if (*buf == NULL)
- *buf =
malloc
(BUFLEN);
+ *buf =
xmalloc
(BUFLEN);
if (len == NULL) {
rewind ((FILE *) arg);
if (len == NULL) {
rewind ((FILE *) arg);
@@
-165,7
+158,7
@@
static const char *_mutt_libesmtp_messagefp_cb (void **buf, int *len,
char *p = strchr (*buf, '\0');
if (p[-1] == '\n' && p[-2] != '\r') {
char *p = strchr (*buf, '\0');
if (p[-1] == '\n' && p[-2] != '\r') {
-
strcpy (p -
1, "\r\n");
+
m_strcpy(p - 1, *buf + BUFLEN - p +
1, "\r\n");
p++;
}
octets = p - (char *) *buf;
p++;
}
octets = p - (char *) *buf;
@@
-255,7
+248,7
@@
static void do_dsn_notify (smtp_message_t message, const char* from) {
int flags = Notify_NOTSET;
smtp_recipient_t self = NULL;
int flags = Notify_NOTSET;
smtp_recipient_t self = NULL;
- if (
!DsnNotify || !*DsnNotify || !message || !from || !*from
||
+ if (
m_strisempty(DsnNotify) || !message || m_strisempty(from)
||
strstr (DsnNotify, "never") != NULL)
return;
strstr (DsnNotify, "never") != NULL)
return;
@@
-274,7
+267,7
@@
static void do_dsn_notify (smtp_message_t message, const char* from) {
}
static void do_dsn_ret (smtp_message_t message) {
}
static void do_dsn_ret (smtp_message_t message) {
- if (
!DsnReturn || !*DsnReturn
|| !message)
+ if (
m_strisempty(DsnReturn)
|| !message)
return;
if (ascii_strncasecmp (DsnReturn, "hdrs", 4) == 0)
smtp_dsn_set_ret (message, Ret_HDRS);
return;
if (ascii_strncasecmp (DsnReturn, "hdrs", 4) == 0)
smtp_dsn_set_ret (message, Ret_HDRS);
@@
-286,7
+279,7
@@
static void do_dsn_ret (smtp_message_t message) {
int mutt_libesmtp_check_usetls (const char* option, unsigned long p,
char* errbuf, size_t errlen) {
char* val = (char*) p;
int mutt_libesmtp_check_usetls (const char* option, unsigned long p,
char* errbuf, size_t errlen) {
char* val = (char*) p;
- if (
!val || !*val
)
+ if (
m_strisempty(val)
)
return (1);
if (m_strncmp(val, "enabled", 7) != 0 &&
m_strncmp(val, "required", 8) != 0) {
return (1);
if (m_strncmp(val, "enabled", 7) != 0 &&
m_strncmp(val, "required", 8) != 0) {
@@
-395,8
+388,7
@@
int mutt_libesmtp_invoke (address_t * from, /* the sender */
}
Done:
}
Done:
- if (fp != NULL)
- fclose (fp);
+ m_fclose(&fp);
if (hostportstr != NULL)
p_delete(&hostportstr);
if (session != NULL)
if (hostportstr != NULL)
p_delete(&hostportstr);
if (session != NULL)