Pierre Habouzit [Sat, 2 Dec 2006 22:54:35 +0000 (23:54 +0100)]
the ‘kids don't do this at home’ commit.
replace the unsigned long mutt API used to cast anything into ints pointer
and so on. Add 'anytype' that is a kind of dirty union that, thanks to gcc
__attribute__((transparent_union)) allows silent cast from any type into
that type.
eeeeeeek !
but that makes the code way easier to read !
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 2 Dec 2006 22:02:41 +0000 (23:02 +0100)]
fixes in the sidebar format, was completely braindead.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 2 Dec 2006 20:18:33 +0000 (21:18 +0100)]
let the caller deal with M_FORMAT_ARROWCURSOR, not the callee.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 2 Dec 2006 20:04:02 +0000 (21:04 +0100)]
mutt_FormatString -> m_strformat (will soon end up into the str lib \o/)
some tiny reworks, stylish issues.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 2 Dec 2006 19:55:57 +0000 (20:55 +0100)]
fully rework mutt_FormatString, fix a lot of issues, no more stack
squashing.
fix bugs with pads.
this is PASS1. soon, the number of columns to prepare the string for will
be computed by the caller rather than the callee.
enable nonliteral formats warning again, those are also meant to
disappear.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 2 Dec 2006 19:53:47 +0000 (20:53 +0100)]
add m_strpad to the string functions.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 2 Dec 2006 13:34:23 +0000 (14:34 +0100)]
oops, ascii_strncasecmp tried to compare one byte too far
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 1 Dec 2006 22:54:28 +0000 (23:54 +0100)]
more nonnull attributes.
simplify skipspaces as !isspace('\0') holds
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 1 Dec 2006 22:40:30 +0000 (23:40 +0100)]
string documentation.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 1 Dec 2006 15:25:49 +0000 (16:25 +0100)]
oops, small regresion
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Fri, 1 Dec 2006 15:16:53 +0000 (16:16 +0100)]
Fix compilation warnings
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Fri, 1 Dec 2006 15:16:51 +0000 (16:16 +0100)]
Fix compilation error
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 1 Dec 2006 15:00:32 +0000 (16:00 +0100)]
fix the real bug, that was hidden in the .h
I like when I understand what was wrong :)
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 1 Dec 2006 10:41:59 +0000 (11:41 +0100)]
workarounds, I do not understand why it segfault, it should *NOT*
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 1 Dec 2006 09:54:12 +0000 (10:54 +0100)]
should fix compilation.
Pierre Habouzit [Fri, 1 Dec 2006 00:41:02 +0000 (01:41 +0100)]
more documentation.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 23:23:15 +0000 (00:23 +0100)]
no more SHORT_STRING's. begin some doc.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 23:17:09 +0000 (00:17 +0100)]
update docs things.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 22:31:35 +0000 (23:31 +0100)]
prepare documentation of the APIs
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 22:04:23 +0000 (23:04 +0100)]
more cosmetics.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 21:45:11 +0000 (22:45 +0100)]
cosmetics
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 21:35:57 +0000 (22:35 +0100)]
cosmetics
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 21:25:35 +0000 (22:25 +0100)]
cosmetics
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 21:22:54 +0000 (22:22 +0100)]
cosmetics++
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 21:18:33 +0000 (22:18 +0100)]
cosmetics
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 08:03:39 +0000 (09:03 +0100)]
some simplifications.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Thu, 30 Nov 2006 00:24:35 +0000 (01:24 +0100)]
simplifications
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Wed, 29 Nov 2006 23:44:50 +0000 (00:44 +0100)]
small detail in m_dirname.
use m_dirname in recvattach.c rather than some cumbersome code.
also fix the 'last used folder' semantics
Pierre Habouzit [Wed, 29 Nov 2006 23:27:54 +0000 (00:27 +0100)]
add m_dirname that implement a non broken libgen-like function.
Pierre Habouzit [Wed, 29 Nov 2006 21:21:16 +0000 (22:21 +0100)]
simplifications around mutt_is_message_type
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Wed, 29 Nov 2006 01:16:30 +0000 (02:16 +0100)]
post ? -post : 0
that was a good one
Pierre Habouzit [Wed, 29 Nov 2006 01:10:17 +0000 (02:10 +0100)]
various code simplifications.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Tue, 28 Nov 2006 23:55:06 +0000 (00:55 +0100)]
make some code yet more simple, using the VERY good semantics of snprintf
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Tue, 28 Nov 2006 22:36:01 +0000 (23:36 +0100)]
remove reallocs, free and fix makedoc compilation
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Tue, 28 Nov 2006 22:28:05 +0000 (23:28 +0100)]
that was in fact a memcpy, nice try
Julien Danjou [Tue, 28 Nov 2006 17:59:29 +0000 (18:59 +0100)]
Use good m_ functions, because it smell like a flower, version 2.
This is a whole bunch of update for using more m_* functions.
Some calculation should be checked, maybe I made some mistakes.
Not good at math.
There is also some _CHECKED__ comments removed because I got
my head checked by a jumbot jet.
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Tue, 28 Nov 2006 18:47:29 +0000 (19:47 +0100)]
"gpg-sign" is not a valid token, this was a typo.
also drop some very old mutt things, just use x-action, the rest will be
re-parsed, too bad.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Mon, 27 Nov 2006 09:49:09 +0000 (10:49 +0100)]
force rfc2047_parameters to be set to yes, and non configureable.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sun, 26 Nov 2006 23:23:52 +0000 (00:23 +0100)]
Use m_functions(), you'll be fresh-faced.
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 23:27:43 +0000 (00:27 +0100)]
remove a mutt-ng thing that makes no sense at all.
rework OPTWEED handling a bit.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 23:02:35 +0000 (00:02 +0100)]
lots of simplifications.
add pattern.h
always set strict_mime off, we want to do a MUA that understands other,
right ? just keep the parse of that option for now, to avoid barfing
hopelessly on old mutt's config files
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 22:16:24 +0000 (23:16 +0100)]
more automake stuff
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 22:13:15 +0000 (23:13 +0100)]
more tweaks and fixes.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 22:03:59 +0000 (23:03 +0100)]
build system tweaks.
update-po.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 21:58:49 +0000 (22:58 +0100)]
always build support for mixmaster.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 21:10:38 +0000 (22:10 +0100)]
some code simplifications.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sun, 26 Nov 2006 19:26:57 +0000 (20:26 +0100)]
Remove unused code
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sun, 26 Nov 2006 19:46:23 +0000 (20:46 +0100)]
Use m_strncmp instead of strncmp
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sun, 26 Nov 2006 17:52:15 +0000 (18:52 +0100)]
m_strisempty is better, isn't it ?
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 17:40:06 +0000 (18:40 +0100)]
simplify mutt_write_references.
wibble
Pierre Habouzit [Sun, 26 Nov 2006 17:09:23 +0000 (18:09 +0100)]
make mutt_match_spam_list a generic rx function: rx_list_match2 that does
the same as rx_list_match + expand a template into the given buffer.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 16:38:21 +0000 (17:38 +0100)]
move more functions in file.c
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 16:31:33 +0000 (17:31 +0100)]
mutt_expand_file_fmt -> m_quotefile_fmt in file.c
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 26 Nov 2006 16:19:39 +0000 (17:19 +0100)]
wibble.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:19:03 +0000 (18:19 +0100)]
Use better error msgs for tempfile
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:19:02 +0000 (18:19 +0100)]
Better error msg in gpgme
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:19:01 +0000 (18:19 +0100)]
Use bette error msg too
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:19:00 +0000 (18:19 +0100)]
Replace mutt_perror with good error msgs
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:57 +0000 (18:10 +0100)]
Tag unused attributes
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:56 +0000 (18:10 +0100)]
Kill shadow declaratin of brk
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:55 +0000 (18:10 +0100)]
Tag unused and kill mktemp
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:54 +0000 (18:10 +0100)]
Fix shadow declaration and tag unused attribute
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:53 +0000 (18:10 +0100)]
Mark unused attributes
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:52 +0000 (18:10 +0100)]
Mark flags as unused
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:51 +0000 (18:10 +0100)]
Kill another mktemp
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:50 +0000 (18:10 +0100)]
mutt_*mktemp--
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:49 +0000 (18:10 +0100)]
Use m_tempfile and better errors msg
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:48 +0000 (18:10 +0100)]
Fix typo
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 17:10:47 +0000 (18:10 +0100)]
Use m_tempfile()
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 25 Nov 2006 01:01:36 +0000 (02:01 +0100)]
get the sloccount under 63000 lines :P
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 25 Nov 2006 00:58:27 +0000 (01:58 +0100)]
wibble
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 25 Nov 2006 00:53:36 +0000 (01:53 +0100)]
drop the stupid xterm.h header.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 25 Nov 2006 00:46:46 +0000 (01:46 +0100)]
various fixes, remove an adv_mktemp
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 25 Nov 2006 00:32:52 +0000 (01:32 +0100)]
fclose -> m_fclose
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sat, 25 Nov 2006 00:09:57 +0000 (01:09 +0100)]
Use m_tempfile instead of mutt_mktemp (again and again)
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sat, 25 Nov 2006 00:10:19 +0000 (01:10 +0100)]
small fixes, style and cosmetics.
Julien Danjou [Fri, 24 Nov 2006 23:46:11 +0000 (00:46 +0100)]
Use m_tempfile instead of mutt_mktemp
And crypt_write is static
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 24 Nov 2006 23:52:37 +0000 (00:52 +0100)]
safe_fclose -> m_fclose, and is now inlined.
Pierre Habouzit [Fri, 24 Nov 2006 23:47:26 +0000 (00:47 +0100)]
revert bogus patch part.
Julien Danjou [Fri, 24 Nov 2006 23:22:42 +0000 (00:22 +0100)]
Clean up code and use m_tempfile instead of mutt_mktemp
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 24 Nov 2006 23:24:40 +0000 (00:24 +0100)]
remove some mutt_mktemp
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 24 Nov 2006 23:01:43 +0000 (00:01 +0100)]
I'm such a fool
YES WE DO WANT TO WRITE IN OUR TEMPORARY FILES.
*g*
Pierre Habouzit [Fri, 24 Nov 2006 22:42:16 +0000 (23:42 +0100)]
small leftover
Julien Danjou [Fri, 24 Nov 2006 22:29:14 +0000 (23:29 +0100)]
Use m_tempfile instead of mutt_mktemp
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Fri, 24 Nov 2006 22:29:13 +0000 (23:29 +0100)]
Use m_tempfile instead of mutt_mktemp
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 24 Nov 2006 22:34:37 +0000 (23:34 +0100)]
mutt_mktemp--
Pierre Habouzit [Fri, 24 Nov 2006 15:31:33 +0000 (16:31 +0100)]
put old m_snsubst into file.c as m_file_fmt.
implement m_temp{fd,file} functions to replace mutt_(adv_)mktemp, that
work like that:
m_tempFOO(dst, dstlen, tmpdir, fmt).
it returns either a fd or a FILE* (check it's properly >= 0 or !NULL !!!)
and put the chose name in the buffer dst of size dstlen.
tmpdir is the directory where to create files.
fmp is a file format, where we strip any directory part, then use the
remains like that:
- if there is a %s specifier, fmt is used as a simple file format
specifier, and %s is substituted with a temporary file name.
- if there is no %s specifier, fmt is supposed to be a file name we
want to take as model, meaning we just want to copy its extension.
So if you pass "foo.jpg" as a fmt, the resulting file name will end
in .jpg
mark mutt_(adv_)?mktemp functions as obsolete, and currently
reimplement them with m_temp* functions as a proof of concept.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Fri, 24 Nov 2006 00:39:11 +0000 (01:39 +0100)]
fix completely braindead rfc2047 parsing, that choke on something as
stupid as:
=?UTF-8?Q?foobar??=
this is totally valid, and we choke on this because of the ? in that
string. it's not ambiguous, so deal with it correctly, and get "foobar?"
as a result instead of =?UTF-8?....?=
Pierre Habouzit [Sun, 19 Nov 2006 16:06:30 +0000 (17:06 +0100)]
fix regression in mutt_is_application_pgp \o/
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Julien Danjou [Sun, 19 Nov 2006 12:45:19 +0000 (13:45 +0100)]
Fix regression with comma handling in buffy
Signed-off-by: Julien Danjou <julien@danjou.info>
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Pierre Habouzit [Sun, 19 Nov 2006 02:13:55 +0000 (03:13 +0100)]
exit SPAM_LIST, just extend rx_t with the needed informations.
push some things into the rx lib.
horrors--.
Signed-off-by: Pierre Habouzit <madcoder@madism.org>
Pierre Habouzit [Sun, 19 Nov 2006 01:14:57 +0000 (02:14 +0100)]
move functions around.
replace mutt_expand_fmt with m_snsubst that has a more coherent API now.
Signed-off-by: Pierre Habouzit <madcoder@madism.org>
Pierre Habouzit [Sun, 19 Nov 2006 00:41:16 +0000 (01:41 +0100)]
simplify mutt_expand_path
Signed-off-by: Pierre Habouzit <madcoder@madism.org>
Pierre Habouzit [Sat, 18 Nov 2006 22:51:45 +0000 (23:51 +0100)]
simplifications
Signed-off-by: Pierre Habouzit <madcoder@madism.org>
Pierre Habouzit [Sat, 18 Nov 2006 22:16:36 +0000 (23:16 +0100)]
statics
Signed-off-by: Pierre Habouzit <madcoder@madism.org>
Pierre Habouzit [Sat, 18 Nov 2006 22:10:19 +0000 (23:10 +0100)]
remove -Inntp
Signed-off-by: Pierre Habouzit <madcoder@madism.org>
Pierre Habouzit [Sat, 18 Nov 2006 22:05:15 +0000 (23:05 +0100)]
small rewrites
Signed-off-by: Pierre Habouzit <madcoder@madism.org>
Pierre Habouzit [Sat, 18 Nov 2006 21:09:47 +0000 (22:09 +0100)]
simplifications.
fix a bug in mutt_gen_msgid
Signed-off-by: Pierre Habouzit <madcoder@madism.org>
Pierre Habouzit [Sat, 18 Nov 2006 21:01:19 +0000 (22:01 +0100)]
hide one more function
Signed-off-by: Pierre Habouzit <madcoder@madism.org>
Pierre Habouzit [Sat, 18 Nov 2006 20:58:29 +0000 (21:58 +0100)]
details
Signed-off-by: Pierre Habouzit <madcoder@madism.org>
projects / apps / madmutt.git / log